chukwa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eric Spishak (JIRA)" <j...@apache.org>
Subject [jira] [Created] (CHUKWA-641) PatternSyntaxException Crash from Unvalidated Regular Expression Usage
Date Wed, 09 May 2012 00:45:50 GMT
Eric Spishak created CHUKWA-641:
-----------------------------------

             Summary: PatternSyntaxException Crash from Unvalidated Regular Expression Usage
                 Key: CHUKWA-641
                 URL: https://issues.apache.org/jira/browse/CHUKWA-641
             Project: Chukwa
          Issue Type: Bug
    Affects Versions: 0.5.0
            Reporter: Eric Spishak


Chukwa sometimes crashes with an unhelpful stack trace.  In particular, a PatternSyntaxException
is thrown when an invalid regular expression is passed to the dumpChunk command. This exception
isn't useful to users to diagnose the error. I think it would be better to report a detailed
error message. The attached patch makes this change.

Steps to reproduce:

# Run 'bin/chukwa dumpChunk "tags.=(" file'
# dumpChunk command fails to start
# See exception:

{code}
Exception in thread "main" java.util.regex.PatternSyntaxException:
Unclosed group near index 1
(
 ^
       at java.util.regex.Pattern.error(Pattern.java:1713)
       at java.util.regex.Pattern.accept(Pattern.java:1571)
       at java.util.regex.Pattern.group0(Pattern.java:2533)
       at java.util.regex.Pattern.sequence(Pattern.java:1806)
       at java.util.regex.Pattern.expr(Pattern.java:1752)
       at java.util.regex.Pattern.compile(Pattern.java:1460)
       at java.util.regex.Pattern.<init>(Pattern.java:1133)
       at java.util.regex.Pattern.compile(Pattern.java:847)
       at org.apache.hadoop.chukwa.util.Filter.<init>(Filter.java:94)
       at org.apache.hadoop.chukwa.util.DumpChunks.dump(DumpChunks.java:88)
       at org.apache.hadoop.chukwa.util.DumpChunks.main(DumpChunks.java:53)
{code}

After applying the supplied patch the output is:

{code}
Error parsing "tags" regular expression: Unclosed group near index 1
(
 ^
{code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message