Return-Path: X-Original-To: apmail-incubator-chukwa-dev-archive@www.apache.org Delivered-To: apmail-incubator-chukwa-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A28066DF0 for ; Mon, 20 Jun 2011 22:16:09 +0000 (UTC) Received: (qmail 34300 invoked by uid 500); 20 Jun 2011 22:16:09 -0000 Delivered-To: apmail-incubator-chukwa-dev-archive@incubator.apache.org Received: (qmail 34280 invoked by uid 500); 20 Jun 2011 22:16:09 -0000 Mailing-List: contact chukwa-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: chukwa-dev@incubator.apache.org Delivered-To: mailing list chukwa-dev@incubator.apache.org Received: (qmail 34272 invoked by uid 99); 20 Jun 2011 22:16:09 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 20 Jun 2011 22:16:09 +0000 X-ASF-Spam-Status: No, hits=-0.0 required=5.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of jboulon@netflix.com designates 69.53.237.162 as permitted sender) Received: from [69.53.237.162] (HELO exout101.netflix.com) (69.53.237.162) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 20 Jun 2011 22:16:04 +0000 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; s=s1024;d=netflix.com; h=from:to:date:subject:message-id:in-reply-to:content-type:mime-version; bh=90HuRbw+kRqGmB9NA9e5MfGnc7A=; b=ApPYBudW4oFVyDRYtoxxx8STvjSgwyaqHz49uSTvMjhDNWIQSaSEMVbsS6dhf6VukBzoJ+ol pD9Z9JTrqyeSUJnQBQ56J+cybdrIw8IAhXHj6yamTOLybed+DPqgZDb7tZT69FjCri6PHaW0 2a14jw+fp9pflzW+1KTSsAHmFZo= DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=s1024;d=netflix.com; h=from:to:date:subject:message-id:in-reply-to:content-type:mime-version; b=kZdTS9tArd5imQ4lgR3y88AuxuEahaexwRyKVwYe+XgBb0fKmCqCbumHcvzD7wuJGk9LDh2n X5vcBPGFUW4LPIvcq523dXxa08rfki0weiRqfK714ZIYwGy9McqpSKtR57yt6xTAEuYxf5NJ jaPVCeaXPZ28ESCO+HBBR4snWus= Received: from exchnmc101.netflix.com (10.64.32.131) by exout101.netflix.com (10.64.240.73) with Microsoft SMTP Server (TLS) id 8.3.137.0; Mon, 20 Jun 2011 15:15:24 -0700 Received: from ExchMBX104.netflix.com ([fe80::409a:eb58:3def:adb6]) by exchnmc101.netflix.com ([fe80::4894:38ba:ac0c:e4bc%13]) with mapi; Mon, 20 Jun 2011 15:15:43 -0700 From: Jerome Boulon To: "chukwa-dev@incubator.apache.org" Date: Mon, 20 Jun 2011 15:15:41 -0700 Subject: Re: [jira] [Commented] (CHUKWA-589) Functionality allowing collectors to close .chukwa files at a fixed offset inside the rotateInterval Thread-Topic: [jira] [Commented] (CHUKWA-589) Functionality allowing collectors to close .chukwa files at a fixed offset inside the rotateInterval Thread-Index: Acwvl5gKBnMTggHZQ1eETmWqT4gf7g== Message-ID: In-Reply-To: <1441209521.22662.1308606767315.JavaMail.tomcat@hel.zones.apache.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Microsoft-MacOutlook/14.2.0.101115 acceptlanguage: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Yea, _JB_ should be changed to something else ;-) That's something I may have done as a quick workaround ... /Jerome On 6/20/11 2:52 PM, "Bill Graham (JIRA)" wrote: > > [=20 >https://issues.apache.org/jira/browse/CHUKWA-589?page=3Dcom.atlassian.jira= .p >lugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D13052241#c= om >ment-13052241 ]=20 > >Bill Graham commented on CHUKWA-589: >------------------------------------ > >Looks good to me too although I'd like to request one more small change. >In TestChukwaWriters you re-use the "testChukwaWriters_JB_" directory >prefix used in the test data. Can you change that to something that >implies the test name, so its content can be mapped to the test. >Something like "testChukwaWriters_testSeqWriterFixedCloseInterval_". > >I'm not sure how the "_JB_" convention was introduced in the pre-existing >test in that class (maybe Jerome's initials?), but you might a well >correct that in the other test as well (i.e. >"testChukwaWriters_testWriter_"). > >> Functionality allowing collectors to close .chukwa files at a fixed >>offset inside the rotateInterval >>=20 >>------------------------------------------------------------------------- >>--------------------------- >> >> Key: CHUKWA-589 >> URL: https://issues.apache.org/jira/browse/CHUKWA-589 >> Project: Chukwa >> Issue Type: New Feature >> Components: data collection >> Affects Versions: 0.5.0 >> Reporter: Himanshu Gahlot >> Attachments: CHUKWA-589_1.patch, CHUKWA-589_2.patch >> >> >> We have a system built on top of Chukwa that introduces the need to >>have all .chukwa files for a given rotateInterval closed and available >>at a predictable time. Currently, we are experience some drift in the >>times that the sequence files are closed due to the way the TimerTask is >>scheduled in the SeqFileWriter class. We would like to submit a >>solution that will allow people to configure the time all collectors >>should close their files for processing in a given interval, while still >>supporting the default functionality. > >-- >This message is automatically generated by JIRA. >For more information on JIRA, see: http://www.atlassian.com/software/jira > > =20 >