Mailing-List: contact chukwa-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: chukwa-dev@incubator.apache.org
Received-SPF: pass (nike.apache.org: domain of billgraham@gmail.com designates
 74.125.82.175 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:reply-to:in-reply-to:references:from:date:message-id
         :subject:to:content-type:content-transfer-encoding;
        b=lTJrxAuV9bkve7MNLAREw6jbzPBcaPAx7zD14W6DyM00ywOjkrLZDjR8l+lGwO/4SM
         X4W6Mxqb5cuib8pNMuseRPU+48zrrd/3czVgtcC2fO7Nxt5D0tTA921R6xjKA+dZornW
         SlWbtY53yF4zg1MJYQb9BBEqX4Xq5p+DNDYTo=
MIME-Version: 1.0
Reply-To: billgraham@gmail.com
In-Reply-To: <AANLkTi=jRpiRrfspRg78Kd8MHx2P1j8zHG97f9gQf0xE@mail.gmail.com>
References: <AANLkTinr_4cOOu0uwZPEtF_JcuyMasUc1MX+c9mg=Wug@mail.gmail.com>
 <AANLkTinkA6TL6RFTfam17neKx5wx53qz3m5pdpi1sP6Y@mail.gmail.com>
 <AANLkTi=jRpiRrfspRg78Kd8MHx2P1j8zHG97f9gQf0xE@mail.gmail.com>
From: Bill Graham <billgraham@gmail.com>
Date: Mon, 18 Oct 2010 08:21:45 -0700
Message-ID: <AANLkTi=ayWwMR6OMqdNdeXNYmoq_dSc871yQYpZ2eus-@mail.gmail.com>
Subject: Re: Simplify chukwa agent
To: chukwa-dev@incubator.apache.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

+1 on refactoring the agent code and it's related interfaces at some
point. Implementing an adaptor seems a bit more confusing than it
ought to be. Some of the methods on Adaptor, like getCurrentStatus for
instance, do quite a bit more than their javadoc implies, or the
method name would lead you to believe.


On Sun, Oct 17, 2010 at 11:14 PM, Eric Yang <eric818@gmail.com> wrote:
> Hi Ari,
>
> The list of TODO from my side for Chukwa 0.5 is:
>
> - Update demux parsers (New parser for parsing hadoop metrics, job
> history 0.20+ log, and hadoop logs)
> - Update data analytics scripts using pig 0.8
> - Update documentation
>
> I am waiting on pig to release 0.8 which contains support for using
> HBase as storage. =A0This will enable chukwa data analytics on top of
> pig+HBase.
> After pig 0.8 is released, then Chukwa 0.5 release will be ready. =A0I
> agree that refactoring the interface in Chukwa Agent could wait until
> Chukwa 0.5 is released.
>
> regards,
> Eric
>
> On Sun, Oct 17, 2010 at 10:54 PM, Ariel Rabkin <asrabkin@gmail.com> wrote=
:
>> Howdy.
>>
>> I agree that that part of the code is pretty snarly. Not sure how
>> urgent a priority it is to fix.
>>
>> I think a better short-term goal might be doing a 0.5 release. How
>> close are we to that?
>>
>> --Ari
>>
>> On Sun, Oct 17, 2010 at 3:31 PM, Eric Yang <eric818@gmail.com> wrote:
>>> Hi all,
>>>
>>> Chukwa agent code is not intuitive to understand. =A0This is mainly the
>>> interface in Chukwa agent is over complicating the implementation. =A0I
>>> don't see a rationale for having each class to be an interface.
>>> Connector and Chukwa Sender are two interfaces which are not very
>>> useful to be interface. =A0It creates over complicated subsystem to
>>> maintain collector list in agent, connector and sender. =A0Ideally,
>>> there should be a single place for configuration source of truth. =A0I
>>> am leaning toward making those interface abstract classes. =A0Connector
>>> should be rename to something more meaningful like multiplexer or MUX
>>> for short. =A0AgentControlSocketListener could be refactor into a jerse=
y
>>> like rest api, for easier to maintain the code base, and remove the
>>> 9093 protocol.
>>> This sounds like a major task. =A0I like to gather feedback to see if
>>> this change is necessary for creating more traction on chukwa
>>> development.
>>>
>>> regards,
>>> Eric
>>>
>>
>>
>>
>> --
>> Ari Rabkin asrabkin@gmail.com
>> UC Berkeley Computer Science Department
>>
>