chukwa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ahmed Fathalla (JIRA)" <j...@apache.org>
Subject [jira] Commented: (CHUKWA-4) Collectors don't finish writing .done datasink from last .chukwa datasink when stopped using bin/stop-collectors
Date Mon, 03 May 2010 21:25:00 GMT

    [ https://issues.apache.org/jira/browse/CHUKWA-4?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12863522#action_12863522
] 

Ahmed Fathalla commented on CHUKWA-4:
-------------------------------------

Hey, Ari. Thanks for reviewing the patch.

I tested it manually by stopping the collector while writing .chukwa files and starting it
again,this leaves .chukwa files in the local corrector directory.  When the collector is restarted,
the CopySequenceFile class I implemented correctly copies the contents to to a valid sequence
file and renames it to .done (except in the rare case I noted in previous comments). 

I also implemented a unit test "TestCopySequenceFile" which creates a .chukwa file and converts
it into a valid .done file using CopySequenceFile.

Yes, this implementation only covers the case of having a local collector directory. I suggest
we address the issue of writing directly to HDFS in a separate JIRA.

> Collectors don't finish writing .done datasink from last .chukwa datasink when stopped
using bin/stop-collectors
> ----------------------------------------------------------------------------------------------------------------
>
>                 Key: CHUKWA-4
>                 URL: https://issues.apache.org/jira/browse/CHUKWA-4
>             Project: Hadoop Chukwa
>          Issue Type: Bug
>          Components: data collection
>         Environment: I am running on our local cluster. This is a linux machine that
I also run Hadoop cluster from.
>            Reporter: Andy Konwinski
>            Priority: Minor
>         Attachments: CHUKWA-4.2.patch, CHUKWA-4.patch
>
>
> When I use start-collectors, it creates the datasink as expected, writes to it as per
normal, i.e. writes to the .chukwa file, and roll overs work fine when it renames the .chukwa
file to .done. However, when I use bin/stop-collectors to shut down the running collector
it leaves a .chukwa file in the HDFS file system. Not sure if this is a valid sink or not,
but I think that the collector should gracefully clean up the datasink and rename it .done
before exiting.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message