Mailing-List: contact chukwa-dev-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: chukwa-dev@hadoop.apache.org
Message-ID: <1360029234.206801268325927297.JavaMail.jira@brutus.apache.org>
Date: Thu, 11 Mar 2010 16:45:27 +0000 (UTC)
From: "Guille -bisho- (JIRA)" <jira@apache.org>
To: chukwa-dev@hadoop.apache.org
Subject: [jira] Commented: (CHUKWA-463) Improve pattern for getTag() method
In-Reply-To: <542291769.178731268236647171.JavaMail.jira@brutus.apache.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CHUKWA-463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12844126#action_12844126 ] 

Guille -bisho- commented on CHUKWA-463:
---------------------------------------

There is still one test failing:

Testcase: testFSMBuilder_JobHistory020(org.apache.hadoop.chukwa.analysis.salsa.fsm.TestFSMBuilder):	FAILED
Error running FSMBuilder: java.io.IOException: Job failed!
junit.framework.AssertionFailedError: Error running FSMBuilder: java.io.IOException: Job failed!
	at org.apache.hadoop.chukwa.analysis.salsa.fsm.TestFSMBuilder.testFSMBuilder_JobHistory020(TestFSMBuilder.java:354)

I don't know why, because the cluster is extracted correctly. I will continue with this on tuesday, I'm on a travel. If anyone know what could be happening here, please tell me.

> Improve pattern for getTag() method
> -----------------------------------
>
>                 Key: CHUKWA-463
>                 URL: https://issues.apache.org/jira/browse/CHUKWA-463
>             Project: Hadoop Chukwa
>          Issue Type: Improvement
>          Components: Data Processors
>            Reporter: Guille -bisho-
>         Attachments: improve_tags_pattern-v2.diff, improve_tags_pattern.diff
>
>
> The current pattern used for extracting tags from the tags field:
>     Pattern tagPattern = Pattern.compile(".*"+tagName+"=\"(.*?)\".*");
> Doesn't work very well. If you pass tagName "bar", will also match (and return) the content of foobar="dssad" tag.
> The proposed path is more correct, and also faster than using .*

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.