Return-Path: Delivered-To: apmail-hadoop-chukwa-dev-archive@minotaur.apache.org Received: (qmail 17906 invoked from network); 17 Mar 2010 17:27:48 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 17 Mar 2010 17:27:48 -0000 Received: (qmail 96321 invoked by uid 500); 17 Mar 2010 17:27:48 -0000 Delivered-To: apmail-hadoop-chukwa-dev-archive@hadoop.apache.org Received: (qmail 96306 invoked by uid 500); 17 Mar 2010 17:27:48 -0000 Mailing-List: contact chukwa-dev-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: chukwa-dev@hadoop.apache.org Delivered-To: mailing list chukwa-dev@hadoop.apache.org Received: (qmail 96298 invoked by uid 99); 17 Mar 2010 17:27:48 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 17 Mar 2010 17:27:48 +0000 X-ASF-Spam-Status: No, hits=-1043.2 required=10.0 tests=ALL_TRUSTED,AWL X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 17 Mar 2010 17:27:47 +0000 Received: from brutus.apache.org (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 45E5F234C48D for ; Wed, 17 Mar 2010 17:27:27 +0000 (UTC) Message-ID: <1253255095.316951268846847285.JavaMail.jira@brutus.apache.org> Date: Wed, 17 Mar 2010 17:27:27 +0000 (UTC) From: "Ari Rabkin (JIRA)" To: chukwa-dev@hadoop.apache.org Subject: [jira] Updated: (CHUKWA-463) Improve pattern for getTag() method In-Reply-To: <542291769.178731268236647171.JavaMail.jira@brutus.apache.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CHUKWA-463?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ari Rabkin updated CHUKWA-463: ------------------------------ Resolution: Fixed Status: Resolved (was: Patch Available) I just committed this. > Improve pattern for getTag() method > ----------------------------------- > > Key: CHUKWA-463 > URL: https://issues.apache.org/jira/browse/CHUKWA-463 > Project: Hadoop Chukwa > Issue Type: Improvement > Components: Data Processors > Reporter: Guille -bisho- > Assignee: Ari Rabkin > Attachments: fixpat.patch, improve_tags_pattern-v2.diff, improve_tags_pattern.diff > > > The current pattern used for extracting tags from the tags field: > Pattern tagPattern = Pattern.compile(".*"+tagName+"=\"(.*?)\".*"); > Doesn't work very well. If you pass tagName "bar", will also match (and return) the content of foobar="dssad" tag. > The proposed path is more correct, and also faster than using .* -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.