chukwa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ari Rabkin (JIRA)" <j...@apache.org>
Subject [jira] Resolved: (CHUKWA-463) Improve pattern for getTag() method
Date Thu, 11 Mar 2010 17:07:27 GMT

     [ https://issues.apache.org/jira/browse/CHUKWA-463?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Ari Rabkin resolved CHUKWA-463.
-------------------------------

    Resolution: Fixed

Just committed revised patch.  Moral of the story:  Unit tests are your friends. ;)

> Improve pattern for getTag() method
> -----------------------------------
>
>                 Key: CHUKWA-463
>                 URL: https://issues.apache.org/jira/browse/CHUKWA-463
>             Project: Hadoop Chukwa
>          Issue Type: Improvement
>          Components: Data Processors
>            Reporter: Guille -bisho-
>         Attachments: improve_tags_pattern-v2.diff, improve_tags_pattern.diff
>
>
> The current pattern used for extracting tags from the tags field:
>     Pattern tagPattern = Pattern.compile(".*"+tagName+"=\"(.*?)\".*");
> Doesn't work very well. If you pass tagName "bar", will also match (and return) the content
of foobar="dssad" tag.
> The proposed path is more correct, and also faster than using .*

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message