Mailing-List: contact chukwa-dev-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: chukwa-dev@hadoop.apache.org
Message-ID: <822089712.231841265977587946.JavaMail.jira@brutus.apache.org>
Date: Fri, 12 Feb 2010 12:26:27 +0000 (UTC)
From: "Gerrit Jansen van Vuuren (JIRA)" <jira@apache.org>
To: chukwa-dev@hadoop.apache.org
Subject: [jira] Updated: (CHUKWA-453) Shell scripts should use !/bin/bash
 not !/bin/sh
In-Reply-To: <1985573155.231461265976627936.JavaMail.jira@brutus.apache.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/CHUKWA-453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gerrit Jansen van Vuuren updated CHUKWA-453:
--------------------------------------------

    Attachment: CHUKWA-453.patch

The patch only modifies the sh files that have !/bin/sh and makes it !/bin/bash

I've noticed that some of the .sh files already had !/bin/bash and some of the helper scripts like start-all.sh have !/usr/bin/env bash.


> Shell scripts should use !/bin/bash not !/bin/sh
> ------------------------------------------------
>
>                 Key: CHUKWA-453
>                 URL: https://issues.apache.org/jira/browse/CHUKWA-453
>             Project: Hadoop Chukwa
>          Issue Type: Bug
>    Affects Versions: 0.4.0
>            Reporter: Gerrit Jansen van Vuuren
>             Fix For: 0.4.0
>
>         Attachments: CHUKWA-453.patch
>
>
> Some of the scripts uses the function key word which is a feature in bash and not supported in shell. 
> Running the agent.sh for example gives bin/agent.sh: 24: function: not found
> The script headers should be changes to !/bin/bash and then it works.
> I propose this be done for all of the sh scripts for consistency.
> I'll attach a patch today.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.