chukwa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gerrit Jansen van Vuuren (JIRA)" <j...@apache.org>
Subject [jira] Commented: (CHUKWA-453) Shell scripts should use !/bin/bash not !/bin/sh
Date Tue, 16 Feb 2010 11:57:27 GMT

    [ https://issues.apache.org/jira/browse/CHUKWA-453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12834176#action_12834176
] 

Gerrit Jansen van Vuuren commented on CHUKWA-453:
-------------------------------------------------

Pleasure. :)

Eric mentioned changing the /bin/bash to #!/usr/bin/env bash. 
I've finally got round to applying these changes, I'll submit the patch with these new changes.



> Shell scripts should use !/bin/bash not !/bin/sh
> ------------------------------------------------
>
>                 Key: CHUKWA-453
>                 URL: https://issues.apache.org/jira/browse/CHUKWA-453
>             Project: Hadoop Chukwa
>          Issue Type: Bug
>    Affects Versions: 0.4.0
>            Reporter: Gerrit Jansen van Vuuren
>             Fix For: 0.4.0
>
>         Attachments: CHUKWA-453.patch
>
>
> Some of the scripts uses the function key word which is a feature in bash and not supported
in shell. 
> Running the agent.sh for example gives bin/agent.sh: 24: function: not found
> The script headers should be changes to !/bin/bash and then it works.
> I propose this be done for all of the sh scripts for consistency.
> I'll attach a patch today.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message