Mailing-List: contact chukwa-dev-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: chukwa-dev@hadoop.apache.org
Message-ID: <453847332.1252905537569.JavaMail.jira@brutus>
Date: Sun, 13 Sep 2009 22:18:57 -0700 (PDT)
From: "Ari Rabkin (JIRA)" <jira@apache.org>
To: chukwa-dev@hadoop.apache.org
Subject: [jira] Commented: (CHUKWA-97) FileTailingAdaptor.tailFile should be
 refactored and made more flexible
In-Reply-To: <888816803.1239052453270.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CHUKWA-97?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12754828#action_12754828 ] 

Ari Rabkin commented on CHUKWA-97:
----------------------------------

Will commit within a few days barring objection, and after testing. It's a refactoring, and passes unit tests.

> FileTailingAdaptor.tailFile should be refactored and made more flexible
> -----------------------------------------------------------------------
>
>                 Key: CHUKWA-97
>                 URL: https://issues.apache.org/jira/browse/CHUKWA-97
>             Project: Hadoop Chukwa
>          Issue Type: Improvement
>          Components: data collection
>            Reporter: Ari Rabkin
>            Assignee: Ari Rabkin
>            Priority: Minor
>         Attachments: CHUKWA-97.patch
>
>
> FileTailingAdaptor.tailFile() is 150 lines long, and scary. An awful lot lof policy, for things like log file rotation, is hardcoded and shouldn't be.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.