chukwa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ari Rabkin (JIRA)" <j...@apache.org>
Subject [jira] Commented: (CHUKWA-97) FileTailingAdaptor.tailFile should be refactored and made more flexible
Date Wed, 16 Sep 2009 23:29:57 GMT

    [ https://issues.apache.org/jira/browse/CHUKWA-97?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12756285#action_12756285
] 

Ari Rabkin commented on CHUKWA-97:
----------------------------------

This patch very carefully does not replace the current file tailing adaptor.  It does two
things.

1) It makes it easier to write file tailing adaptors that behave differently in the presence
of files that have been rotated, deleted, not yet created, etc.  
2) It offers a simple lightweight adaptor to handle the use case where there are thousands
of files being watched, and the behavior when files are deleted isn't particularly crucial.

And yes, unit tests still pass.

> FileTailingAdaptor.tailFile should be refactored and made more flexible
> -----------------------------------------------------------------------
>
>                 Key: CHUKWA-97
>                 URL: https://issues.apache.org/jira/browse/CHUKWA-97
>             Project: Hadoop Chukwa
>          Issue Type: Improvement
>          Components: data collection
>            Reporter: Ari Rabkin
>            Assignee: Ari Rabkin
>            Priority: Minor
>         Attachments: CHUKWA-97.patch
>
>
> FileTailingAdaptor.tailFile() is 150 lines long, and scary. An awful lot lof policy,
for things like log file rotation, is hardcoded and shouldn't be.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message