chukwa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ari Rabkin (JIRA)" <j...@apache.org>
Subject [jira] Commented: (CHUKWA-270) undesired ChukwaAgentController message injected to stdout of the running program
Date Wed, 22 Jul 2009 06:14:14 GMT

    [ https://issues.apache.org/jira/browse/CHUKWA-270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12734007#action_12734007
] 

Ari Rabkin commented on CHUKWA-270:
-----------------------------------

Hey, Rushin.

In general, Apache projects tend to have many contributors and few committers. The usual process
is that if you have a patch, you post it as an attachment, mark it as available, and get someone
(not necessarily a committer) to review it.  Once it's been approved, one of the committers
will get to it and check it in, usually within a day or two.

To generate a patch, you say "svn diff [files you want in the patch] > patchfilenanme.patch".
 Then post just the patch, not the whole modified file. This makes it clearer what's being
changed and prevents extraneous and unexpected changes from creeping in.

One other process note. If at all possible, your patch should include new or modified unit
tests to demonstrate that it's functioning correctly.  That's probably neither feasible nor
useful here, so don't worry about it on this issue. 

This may sound like a fair bit of trouble for a small and simple change. But that's the way
Hadoop, Chukwa, and I believe all apache projects are run. It makes it much, MUCH easier to
keep the codebase stable and working correctly.

> undesired ChukwaAgentController message injected to stdout of the running program
> ---------------------------------------------------------------------------------
>
>                 Key: CHUKWA-270
>                 URL: https://issues.apache.org/jira/browse/CHUKWA-270
>             Project: Hadoop Chukwa
>          Issue Type: Improvement
>          Components: data collection
>         Environment: Redhat EL 5.1, Java 6
>            Reporter: Eric Yang
>            Assignee: rushin barot
>         Attachments: ChukwaAgentController.java
>
>
> Agent Controller currently prints it's messages to the stdout of the running program.
 This should be changed to using logger to prevent messages showing up in the unexpected places.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message