Mailing-List: contact chukwa-dev-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: chukwa-dev@hadoop.apache.org
Message-ID: <2084522578.1245885127423.JavaMail.jira@brutus>
Date: Wed, 24 Jun 2009 16:12:07 -0700 (PDT)
From: "Jerome Boulon (JIRA)" <jira@apache.org>
To: chukwa-dev@hadoop.apache.org
Subject: [jira] Commented: (CHUKWA-330) controller should not create
 duplicates for adaptors with offsets
In-Reply-To: <910696553.1245800347383.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CHUKWA-330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12723791#action_12723791 ] 

Jerome Boulon commented on CHUKWA-330:
--------------------------------------

- How do you know that you don't need the optional part to compute the adaptor's name?
What if the optional part says use this extractRecord method unless there's already someone watching the file?

- What the purpose of parseArgs()? returns only the part of the argument that is required for duplicate detection? so that's basically my proposal with the isDuplicate method. At least with a isDuplicate method's name you kind of know what is used for.
And if you don't maintain the registry part (the AdaptorType lookup from the factory) then you are always going to create a new instance just to get the name, is that correct?


> controller should not create duplicates for adaptors with offsets
> -----------------------------------------------------------------
>
>                 Key: CHUKWA-330
>                 URL: https://issues.apache.org/jira/browse/CHUKWA-330
>             Project: Hadoop Chukwa
>          Issue Type: Bug
>          Components: input tools
>            Reporter: Ari Rabkin
>            Assignee: Ari Rabkin
>            Priority: Blocker
>             Fix For: 0.2.0, 0.3.0
>
>         Attachments: CHUKWA-330-big.patch, CHUKWA-330.patch
>
>   Original Estimate: 1.5h
>  Remaining Estimate: 1.5h
>
> The offset-of-first-byte param to FileTailingAdaptor is hashed into the default adaptor name.  This changes the semantics of adaptor uniqueness, and broke metrics and the log4jappender.
> Proposed fix:
>   Add a new "addByName()" method to ChukwaAgentController that lets callers specify names.  
>   Use this new method whenever finer control of adaptor uniqueness is needed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.