Return-Path: Delivered-To: apmail-hadoop-chukwa-dev-archive@minotaur.apache.org Received: (qmail 91773 invoked from network); 24 Jun 2009 17:34:18 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 24 Jun 2009 17:34:18 -0000 Received: (qmail 68343 invoked by uid 500); 24 Jun 2009 17:34:29 -0000 Delivered-To: apmail-hadoop-chukwa-dev-archive@hadoop.apache.org Received: (qmail 68324 invoked by uid 500); 24 Jun 2009 17:34:29 -0000 Mailing-List: contact chukwa-dev-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: chukwa-dev@hadoop.apache.org Delivered-To: mailing list chukwa-dev@hadoop.apache.org Received: (qmail 68314 invoked by uid 99); 24 Jun 2009 17:34:29 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 24 Jun 2009 17:34:29 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 24 Jun 2009 17:34:27 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 56CD4234C004 for ; Wed, 24 Jun 2009 10:34:07 -0700 (PDT) Message-ID: <2063007815.1245864847341.JavaMail.jira@brutus> Date: Wed, 24 Jun 2009 10:34:07 -0700 (PDT) From: "Ari Rabkin (JIRA)" To: chukwa-dev@hadoop.apache.org Subject: [jira] Commented: (CHUKWA-330) controller should not create duplicates for adaptors with offsets In-Reply-To: <910696553.1245800347383.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/CHUKWA-330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12723650#action_12723650 ] Ari Rabkin commented on CHUKWA-330: ----------------------------------- Good catch. How about org.apache.hadoop.chukwa.util.AdaptorNamingUtils? > controller should not create duplicates for adaptors with offsets > ----------------------------------------------------------------- > > Key: CHUKWA-330 > URL: https://issues.apache.org/jira/browse/CHUKWA-330 > Project: Hadoop Chukwa > Issue Type: Bug > Components: input tools > Reporter: Ari Rabkin > Assignee: Ari Rabkin > Priority: Blocker > Attachments: CHUKWA-330.patch > > Original Estimate: 1.5h > Remaining Estimate: 1.5h > > The offset-of-first-byte param to FileTailingAdaptor is hashed into the default adaptor name. This changes the semantics of adaptor uniqueness, and broke metrics and the log4jappender. > Proposed fix: > Add a new "addByName()" method to ChukwaAgentController that lets callers specify names. > Use this new method whenever finer control of adaptor uniqueness is needed. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.