chukwa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Eric Yang <ey...@yahoo-inc.com>
Subject Re: giving Adaptors an abstract class?
Date Mon, 08 Jun 2009 06:04:56 GMT
+1 It has been difficult to troubleshoot what is going on with the adaptors
because adaptorsPosition and adaptorByNumber seem to fall apart after
15,000+ adaptors processed.  Adaptor management interface would bring more
clarity to the inner interaction between adaptors and agent.

Regards,
Eric

On 6/7/09 8:22 PM, "Ariel Rabkin" <asrabkin@gmail.com> wrote:

> Hi all.
> 
> There's a lot of clunky repetitive code in the adaptors, for counting
> the number of bytes sent, and holding onto the send queue, and the
> adaptor metadata. I'd like to factor that out. I think we should
> create an AbstractAdaptor class that adaptors can derive from.
> 
> The motivation for this is CHUKWA-268, creating an adaptor management
> interface. I'd like to be able to pass an instance of this interface
> to each adaptor, without the adaptor author having to track it
> explicitly.
> 
> Thoughts?  It shouldn't be a huge change, but I wanted to discuss first.
> 
> --Ari


Mime
View raw message