chukwa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jerome Boulon (JIRA)" <j...@apache.org>
Subject [jira] Commented: (CHUKWA-330) controller should not create duplicates for adaptors with offsets
Date Tue, 23 Jun 2009 23:45:07 GMT

    [ https://issues.apache.org/jira/browse/CHUKWA-330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12723366#action_12723366
] 

Jerome Boulon commented on CHUKWA-330:
--------------------------------------

It will be better only if the client has enough knowledge on how the underlying implementation
is done and if the client want to take care of that ....
It's good to have the ability to create your own naming convention for the adaptor but I assume
that most developers will just use the implementation that do not specify the name as it simple
and they will not have to worry about duplicate and so on .... 

Solution that will not change the semantics of adaptor uniqueness, and broke metrics and the
log4jappender :

- add a method to the adaptor interface (isDuplicate, that takes the same parameters as the
start method) 
- each adaptor will register to the factory class so AdaptorManager will be able to call the
isDuplicate's method on the right Adaptor 
- if there's no instance for  specific adaptor then it's because there's no duplicate

At the AdaptorManager level:
- if name is present then do not check anything 
- if name not there then rely on the adaptor to found if it's a duplicate or not.



> controller should not create duplicates for adaptors with offsets
> -----------------------------------------------------------------
>
>                 Key: CHUKWA-330
>                 URL: https://issues.apache.org/jira/browse/CHUKWA-330
>             Project: Hadoop Chukwa
>          Issue Type: Bug
>          Components: input tools
>            Reporter: Ari Rabkin
>            Assignee: Ari Rabkin
>            Priority: Blocker
>   Original Estimate: 1.5h
>  Remaining Estimate: 1.5h
>
> The offset-of-first-byte param to FileTailingAdaptor is hashed into the default adaptor
name.  This changes the semantics of adaptor uniqueness, and broke metrics and the log4jappender.
> Proposed fix:
>   Add a new "addByName()" method to ChukwaAgentController that lets callers specify names.
 
>   Use this new method whenever finer control of adaptor uniqueness is needed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message