Mailing-List: contact chukwa-dev-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: chukwa-dev@hadoop.apache.org
Message-ID: <1354668205.1239648194822.JavaMail.jira@brutus>
Date: Mon, 13 Apr 2009 11:43:14 -0700 (PDT)
From: "Cheng (JIRA)" <jira@apache.org>
To: chukwa-dev@hadoop.apache.org
Subject: [jira] Commented: (CHUKWA-124) Metrics Data Loader doesn't close
 connection when data loading is finished.
In-Reply-To: <484407426.1239559935074.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CHUKWA-124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12698487#action_12698487 ] 

Cheng commented on CHUKWA-124:
------------------------------

The commit statement is in the finally block. Shall it be in the try block? If we leave it in the finally block, we should catch the exception. Otherwise if something is wrong with the commit, the close statements will never get called.

> Metrics Data Loader doesn't close connection when data loading is finished.
> ---------------------------------------------------------------------------
>
>                 Key: CHUKWA-124
>                 URL: https://issues.apache.org/jira/browse/CHUKWA-124
>             Project: Hadoop Chukwa
>          Issue Type: Bug
>          Components: Data Processors
>    Affects Versions: 0.1.2
>         Environment: Redhat EL 5.1, Java 6
>            Reporter: Eric Yang
>            Assignee: Eric Yang
>            Priority: Blocker
>             Fix For: 0.1.2
>
>         Attachments: CHUKWA-124.patch
>
>
> PostProcessManager is running as a deamon now, and jdbc connection without closing becomes a serious issue.  Database loader needs to close the connection when sequence file is finished loading to the database.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.