chukwa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jerome Boulon (JIRA)" <j...@apache.org>
Subject [jira] Commented: (CHUKWA-44) FileAdaptor not closing RandomAccessFile
Date Fri, 27 Mar 2009 19:00:52 GMT

    [ https://issues.apache.org/jira/browse/CHUKWA-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12690006#action_12690006
] 

Jerome Boulon commented on CHUKWA-44:
-------------------------------------

This patch fix what this Jira is about. 

However yes this class was very badly designed in the first place, the start method should
not have the reading part CHUKWA-57 will be a way to fix that.

Adding retry in the start method will just add more latency on the remote client side and
would still be a bad design decision.




> FileAdaptor not closing RandomAccessFile
> ----------------------------------------
>
>                 Key: CHUKWA-44
>                 URL: https://issues.apache.org/jira/browse/CHUKWA-44
>             Project: Hadoop Chukwa
>          Issue Type: Bug
>            Reporter: Jerome Boulon
>            Assignee: Jerome Boulon
>            Priority: Blocker
>         Attachments: CHUKWA-44.patch
>
>
> FileAdaptor should close the reader in a finally block

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message