Return-Path: Delivered-To: apmail-hadoop-chukwa-commits-archive@minotaur.apache.org Received: (qmail 19956 invoked from network); 31 Aug 2009 16:49:23 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 31 Aug 2009 16:49:23 -0000 Received: (qmail 90069 invoked by uid 500); 31 Aug 2009 16:49:23 -0000 Delivered-To: apmail-hadoop-chukwa-commits-archive@hadoop.apache.org Received: (qmail 90056 invoked by uid 500); 31 Aug 2009 16:49:23 -0000 Mailing-List: contact chukwa-commits-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: chukwa-dev@hadoop.apache.org Delivered-To: mailing list chukwa-commits@hadoop.apache.org Received: (qmail 90046 invoked by uid 99); 31 Aug 2009 16:49:23 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 31 Aug 2009 16:49:23 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 31 Aug 2009 16:49:20 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id 3FCC32388872; Mon, 31 Aug 2009 16:48:59 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r809657 - in /hadoop/chukwa/trunk: CHANGES.txt src/java/org/apache/hadoop/chukwa/hicc/Iframe.java Date: Mon, 31 Aug 2009 16:48:59 -0000 To: chukwa-commits@hadoop.apache.org From: eyang@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20090831164859.3FCC32388872@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: eyang Date: Mon Aug 31 16:48:58 2009 New Revision: 809657 URL: http://svn.apache.org/viewvc?rev=809657&view=rev Log: CHUKWA-386. Fix a bug in echo id to the browser for the iframe servlet. (Eric Yang) Modified: hadoop/chukwa/trunk/CHANGES.txt hadoop/chukwa/trunk/src/java/org/apache/hadoop/chukwa/hicc/Iframe.java Modified: hadoop/chukwa/trunk/CHANGES.txt URL: http://svn.apache.org/viewvc/hadoop/chukwa/trunk/CHANGES.txt?rev=809657&r1=809656&r2=809657&view=diff ============================================================================== --- hadoop/chukwa/trunk/CHANGES.txt (original) +++ hadoop/chukwa/trunk/CHANGES.txt Mon Aug 31 16:48:58 2009 @@ -130,6 +130,8 @@ BUG FIXES + CHUKWA-386. Fix a bug in echo id to the browser for the iframe servlet. (Eric Yang) + CHUKWA-380. FTA shouldn't emit empty chunks. (asrabkin) CHUKWA-378. Disable TestArchive unit test. (asrabkin) Modified: hadoop/chukwa/trunk/src/java/org/apache/hadoop/chukwa/hicc/Iframe.java URL: http://svn.apache.org/viewvc/hadoop/chukwa/trunk/src/java/org/apache/hadoop/chukwa/hicc/Iframe.java?rev=809657&r1=809656&r2=809657&view=diff ============================================================================== --- hadoop/chukwa/trunk/src/java/org/apache/hadoop/chukwa/hicc/Iframe.java (original) +++ hadoop/chukwa/trunk/src/java/org/apache/hadoop/chukwa/hicc/Iframe.java Mon Aug 31 16:48:58 2009 @@ -13,17 +13,17 @@ public class Iframe extends HttpServlet { public static final long serialVersionUID = 100L; - private String id; - private String height = "100%"; - private XssFilter xf = null; public void doGet(HttpServletRequest request, HttpServletResponse response) throws IOException, ServletException { + String id; + String height = "100%"; + XssFilter xf = null; xf = new XssFilter(request); if (xf.getParameter("boxId") != null) { - this.id = xf.getParameter("boxId"); + id = xf.getParameter("boxId"); } else { - this.id = "0"; + id = "0"; } response.setContentType("text/html; chartset=UTF-8//IGNORE"); response.setHeader("boxId", xf.getParameter("boxId")); @@ -48,9 +48,15 @@ } } } - out.println(""); + StringBuffer output = new StringBuffer(); + output.append(""); + out.println(output.toString()); } public void doPost(HttpServletRequest request, HttpServletResponse response)