From dev-return-10233-archive-asf-public=cust-asf.ponee.io@chemistry.apache.org Tue May 14 09:15:04 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id E97FE18065D for ; Tue, 14 May 2019 11:15:03 +0200 (CEST) Received: (qmail 54057 invoked by uid 500); 14 May 2019 09:15:03 -0000 Mailing-List: contact dev-help@chemistry.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@chemistry.apache.org Delivered-To: mailing list dev@chemistry.apache.org Received: (qmail 53973 invoked by uid 99); 14 May 2019 09:15:02 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 14 May 2019 09:15:02 +0000 Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 3DE15E2B3C for ; Tue, 14 May 2019 09:15:02 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id D371425819 for ; Tue, 14 May 2019 09:15:00 +0000 (UTC) Date: Tue, 14 May 2019 09:15:00 +0000 (UTC) From: "Mark Struberg (JIRA)" To: dev@chemistry.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CMIS-1075) Allow exclusion of Woodstox dependency MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CMIS-1075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16839237#comment-16839237 ] Mark Struberg commented on CMIS-1075: ------------------------------------- If the class in question (XMLUtils) has any imports oruse of another class which is not on the ClassPath, then the JVM will blow up witha {{NoClassDefFoundError}}. The check used to be less strict in the very past, but since Java-1.6 did introduce stack frame validation it will now even bomb up if you reference this unavailable class from somewhere within the middle of your code. Even if you don't import it but use FQCN. This is exactly what we got here. The solution is to move the code in question to a static inner class. Thus it will technically become a new class file and the JVM will be fine if the NCDFE is catched. Attention: NCDFE is an Error, not an Exception. Thus {{catch Exception}} didn't work neither. > Allow exclusion of Woodstox dependency > -------------------------------------- > > Key: CMIS-1075 > URL: https://issues.apache.org/jira/browse/CMIS-1075 > Project: Chemistry > Issue Type: Bug > Components: opencmis-commons > Affects Versions: OpenCMIS 1.1.0 > Reporter: Manfred Huber > Priority: Critical > Labels: build, easyfix, patch, usability > Attachments: opencmis_xmlutils.patch > > Original Estimate: 3h > Remaining Estimate: 3h > > We need to exlcude the Woodstox dependency from opencmis in our project, which is currently not possible. > If you exclude Woodstox you'll get an {{NoClassDefFoundError}} at runtime. > The reason is that the class {{XMLUtils}} imports Woodstox classes. The attached patch resolves this logic in a static inner class. > Please note that we created this patch based on the {{chemistry-opencmis-1.1.0}} tag. > I pushed this change to my fork of opencmis on [Github|https://github.com/downdrown/chemistry-opencmis/commit/ff047559e077cf4d57566a0f43e5f08d29d46b07] but was not able to create a PR since there's no maintenance branch for 1.1.0. > Edit: the above link to Github is wrong, the correct one is [this|https://github.com/downdrown/chemistry-opencmis/commit/26c3be7583ca6ad74ac30ac06c3b0ea02c588bfb] -- This message was sent by Atlassian JIRA (v7.6.3#76005)