From dev-return-10230-archive-asf-public=cust-asf.ponee.io@chemistry.apache.org Thu May 9 18:24:02 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 1487F180763 for ; Thu, 9 May 2019 20:24:01 +0200 (CEST) Received: (qmail 54743 invoked by uid 500); 9 May 2019 18:24:01 -0000 Mailing-List: contact dev-help@chemistry.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@chemistry.apache.org Delivered-To: mailing list dev@chemistry.apache.org Received: (qmail 54695 invoked by uid 99); 9 May 2019 18:24:01 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 09 May 2019 18:24:01 +0000 Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 8673BE03EE for ; Thu, 9 May 2019 18:24:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 4552A20FEB for ; Thu, 9 May 2019 18:24:00 +0000 (UTC) Date: Thu, 9 May 2019 18:24:00 +0000 (UTC) From: "Manfred Huber (JIRA)" To: dev@chemistry.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CMIS-1075) Allow exclusion of Woodstox dependency MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CMIS-1075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16836604#comment-16836604 ] Manfred Huber commented on CMIS-1075: ------------------------------------- Of course I did not see that you compile back to 1.8 ... So that one is correct. Regarding the imports we can tell that we expierienced it differently... It seemed the classloader tried to load the imports while loading the class and because of that we got an {{NoClasDefFoundError}} at runtime... I can't tell you in detail how the class loading mechanism works, but I had a discussion with [~struberg] about that and in the end it seemed he was right... In the moment we moved the {{woodstox}} stuff into a private static inner class (which is handled as separate .class file at runtime, therefore loaded separate) the exclusion worked fine. You still get the error logged to the console but will be able to use the XMLIn - or OutputFactory loaded by {{XMLInputFactory#newInstance}} ... > Allow exclusion of Woodstox dependency > -------------------------------------- > > Key: CMIS-1075 > URL: https://issues.apache.org/jira/browse/CMIS-1075 > Project: Chemistry > Issue Type: Bug > Components: opencmis-commons > Affects Versions: OpenCMIS 1.1.0 > Reporter: Manfred Huber > Priority: Critical > Labels: build, easyfix, patch, usability > Attachments: opencmis_xmlutils.patch > > Original Estimate: 3h > Remaining Estimate: 3h > > We need to exlcude the Woodstox dependency from opencmis in our project, which is currently not possible. > If you exclude Woodstox you'll get an {{NoClassDefFoundError}} at runtime. > The reason is that the class {{XMLUtils}} imports Woodstox classes. The attached patch resolves this logic in a static inner class. > Please note that we created this patch based on the {{chemistry-opencmis-1.1.0}} tag. > I pushed this change to my fork of opencmis on [Github|https://github.com/downdrown/chemistry-opencmis/commit/ff047559e077cf4d57566a0f43e5f08d29d46b07] but was not able to create a PR since there's no maintenance branch for 1.1.0. > Edit: the above link to Github is wrong, the correct one is [this|https://github.com/downdrown/chemistry-opencmis/commit/26c3be7583ca6ad74ac30ac06c3b0ea02c588bfb] -- This message was sent by Atlassian JIRA (v7.6.3#76005)