Mailing-List: contact dev-help@chemistry.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@chemistry.apache.org
Date: Tue, 27 Oct 2015 15:30:28 +0000 (UTC)
From: =?utf-8?Q?Florian_M=C3=BCller_=28JIRA=29?= <jira@apache.org>
To: dev@chemistry.apache.org
Message-ID: <JIRA.12908157.1445936415000.72956.1445959828146@Atlassian.JIRA>
In-Reply-To: <JIRA.12908157.1445936415000@Atlassian.JIRA>
References: <JIRA.12908157.1445936415000@Atlassian.JIRA>
 <JIRA.12908157.1445936415898@arcas>
Subject: [jira] [Resolved] (CMIS-954) getRepositoryInfo always returns
 available top repository from the list even if the repository id passed
 into getRepositoryInfo is set to a different repository
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


     [ https://issues.apache.org/jira/browse/CMIS-954?page=3Dcom.atlassian.=
jira.plugin.system.issuetabpanels:all-tabpanel ]

Florian M=C3=BCller resolved CMIS-954.
---------------------------------
    Resolution: Fixed

> getRepositoryInfo always returns available top repository from the list e=
ven if the repository id passed into getRepositoryInfo is set to a differen=
t repository
> -------------------------------------------------------------------------=
---------------------------------------------------------------------------=
------------
>
>                 Key: CMIS-954
>                 URL: https://issues.apache.org/jira/browse/CMIS-954
>             Project: Chemistry
>          Issue Type: Bug
>          Components: opencmis-client, opencmis-client-bindings
>    Affects Versions: OpenCMIS 0.13.0
>         Environment: Windows Server 2012/ RHEL, tomcat/ WAS. Open CMIS 0.=
13.0 / Tip build, IBM FileNet repository=20
>            Reporter: Srinivas Gannavarapu
>            Assignee: Florian M=C3=BCller
>            Priority: Critical
>              Labels: easyfix
>             Fix For: OpenCMIS 0.14.0
>
>   Original Estimate: 48h
>  Remaining Estimate: 48h
>
> The issues is in "Apache Chemistry client code" within the jar file "chem=
istry-opencmis-client-bindings-0.13.0".
> - The getRepositoryInfo() on the client side is implemented in the class =
"RepositoryServiceImpl" (under the package "org.apache.chemistry.opencmis.c=
lient.bindings.spi.browser"). JAR file "chemistry-opencmis-client-bindings-=
0.13.0".
> - This method has a snippet which does something unexpected. When the len=
gth of the repository infos list is 1, it returns that SOLE repository.
> Code Snippet below:
> public RepositoryInfo getRepositoryInfo(String repositoryId, ExtensionsDa=
ta extension) {
>     List repositoryInfos =3D getRepositoriesInternal(repositoryId);
>     if (repositoryInfos.isEmpty()) {
>       throw new CmisObjectNotFoundException("Repository '" + repositoryId=
 + "'not found!");
>     }
>    if (repositoryInfos.size() =3D=3D 1) {
>       return (RepositoryInfo)repositoryInfos.get(0);
>     }
>     for (RepositoryInfo info : repositoryInfos) {
>       if (info.getId() =3D=3D null)
>       {
>         continue;
>       }
>       if (info.getId().equals(repositoryId)) {
>         return info;
>       }
>     }
>     throw new CmisObjectNotFoundException("Repository '" + repositoryId +=
 "'not found!");
>   }
> - So, when the number of repositories in the given domain is just one, it=
 always returns that irrespective what the user has set in the property "or=
g.apache.chemistry.opencmis.session.repository.id"
> Proposed solution:
> The "if " condition above checking for repositoryInfos.size, which return=
s the only available repository should be removed.=20


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)