Mailing-List: contact dev-help@chemistry.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@chemistry.apache.org
Date: Sat, 20 Sep 2014 22:35:33 +0000 (UTC)
From: =?utf-8?Q?Florian_M=C3=BCller_=28JIRA=29?= <jira@apache.org>
To: dev@chemistry.apache.org
Message-ID: <JIRA.12742920.1411189727000.88139.1411252533815@Atlassian.JIRA>
In-Reply-To: <JIRA.12742920.1411189727000@Atlassian.JIRA>
References: <JIRA.12742920.1411189727000@Atlassian.JIRA>
 <JIRA.12742920.1411189727435@arcas>
Subject: [jira] [Commented] (CMIS-844) POSTHttpServletRequestWrapper should
 accommodate prior consumption of request body by a filter
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


    [ https://issues.apache.org/jira/browse/CMIS-844?page=3Dcom.atlassian.j=
ira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D141422=
20#comment-14142220 ]=20

Florian M=C3=BCller commented on CMIS-844:
-------------------------------------

This has been changed for a reason. Most servlet engines use ISO-8859-1 to =
decode the values. Newer RFCs recommend UTF-8 and that makes a lot of sense=
 for CMIS. For example, creating a folder with a Chinese name requires a ch=
arset that has Chinese characters. ISO-8859-1 is too limited. That=E2=80=99=
s why OpenCMIS does all the decoding and doesn't leave it to the servlet en=
gine.

If you use request.getParameterMap() in filter, you are back to ISO-8859-1.=
 The code change that you have proposed would give you inconsistent results=
 =E2=80=93 depending on whether you have called request.getParameterMap() i=
n filter or not.

I=E2=80=99ll look into it, but I=E2=80=99m not sure that there is a good so=
lution.

> POSTHttpServletRequestWrapper should accommodate prior consumption of req=
uest body by a filter
> -------------------------------------------------------------------------=
---------------------
>
>                 Key: CMIS-844
>                 URL: https://issues.apache.org/jira/browse/CMIS-844
>             Project: Chemistry
>          Issue Type: Bug
>          Components: opencmis-server
>    Affects Versions: OpenCMIS 0.12.0
>            Reporter: Ron Gavlin
>            Assignee: Florian M=C3=BCller
>
> POSTHttpServletRequestWrapper should accommodate prior consumption of the=
 request body by a filter.
> The 0.7.0 release provided this accommodation. This appears to have been =
broken by the major post-0.7.0 refactoring.
> The following POSTHttpServletRequestWrapper constructor modification fixe=
s the problem:
> {code}
> ...
>         if (isMultipart) {
> ...
>         } else {
>             // form data processing
>             StringBuilder sb =3D new StringBuilder();
>             InputStreamReader sr =3D new InputStreamReader(request.getInp=
utStream(), IOUtils.UTF8);
>             char[] buffer =3D new char[4096];
>             int c =3D 0;
>             while ((c =3D sr.read(buffer)) > -1) {
>                 sb.append(buffer, 0, c);
>             }
>             if (sb.length() < 3) {
>                 @SuppressWarnings("unchecked")
>                 Map<String, String[]> parameterMap =3D request.getParamet=
erMap();
>                 getParameterMap().putAll(parameterMap);
>             } else {
>                 parseFormData(sb.toString());
>             }
>         }
> ...
> {code}


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)