chemistry-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ron Gavlin (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (CMIS-820) AtomPub GetRepositories mishandles repositoryId parameter
Date Wed, 02 Jul 2014 09:15:31 GMT

     [ https://issues.apache.org/jira/browse/CMIS-820?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Ron Gavlin updated CMIS-820:
----------------------------

    Description: 
AtomPub GetRepositories.serve() asserts repositoryId != null and then a few lines later sets
repositoryId = getStringParameter(request, Constants.PARAM_REPOSITORY_ID).

This causes problems in the following CmisAtomPubServlet.dispatch() code where the Dispatcher
invokes AtomPub GetRepositories.serve() with a null repositoryId:

{code}
            if (pathFragments.length < 2) {
                // root -> service document
                dispatcher.dispatch("", METHOD_GET, context, service, null, request, response);
                return;
            }
{code}

The simple fix is to remove the repositoryId != null assertion from GetRepositories.serve().

  was:
AtomPub GetRepositories.serve() asserts repositoryId != null and then a few lines later sets
repositoryId = getStringParameter(request, Constants.PARAM_REPOSITORY_ID).

This causes problems in the following CmisAtomPubServlet.dispatch() code where the Dispatcher
invokes AtomPub GetRepositories.serve() with a null repositoryId:

{code}
            if (pathFragments.length < 2) {
                // root -> service document
                dispatcher.dispatch("", METHOD_GET, context, service, null, request, response);
                return;
            }
{code}


> AtomPub GetRepositories mishandles repositoryId parameter
> ---------------------------------------------------------
>
>                 Key: CMIS-820
>                 URL: https://issues.apache.org/jira/browse/CMIS-820
>             Project: Chemistry
>          Issue Type: Bug
>          Components: opencmis-server
>    Affects Versions: OpenCMIS 0.11.0
>            Reporter: Ron Gavlin
>
> AtomPub GetRepositories.serve() asserts repositoryId != null and then a few lines later
sets repositoryId = getStringParameter(request, Constants.PARAM_REPOSITORY_ID).
> This causes problems in the following CmisAtomPubServlet.dispatch() code where the Dispatcher
invokes AtomPub GetRepositories.serve() with a null repositoryId:
> {code}
>             if (pathFragments.length < 2) {
>                 // root -> service document
>                 dispatcher.dispatch("", METHOD_GET, context, service, null, request,
response);
>                 return;
>             }
> {code}
> The simple fix is to remove the repositoryId != null assertion from GetRepositories.serve().



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message