chemistry-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gross, Lukas" <lukas.gr...@sap.com>
Subject Re: ObjectiveCMIS updates complete
Date Fri, 18 Jul 2014 13:20:43 GMT
Hi,

Mike has some valid points regarding the escaping implementation. Please
find my comments below.

1- I used Œ?¹ as parameter token because I basically followed the OpenCMIS
implementation. Furthermore this is a common pattern also in other
Prepared Statement implementations.
If I got you right you suggest to use {1} Š {n} parameters in the string
and then use rangeOf to find and replace them instead of parsing the
string character by character.

2 - I will change this one

3 - The new syntax is definitively nicer and I use it especially when
initializing large arrays or dictionaries. However I¹m still kind of used
to writing old-fashioned code... but I can change this, if it makes you
sleep better :)

4- I will  check this

Is 1) something we should consider changing before releasing 0.4? Is
everyone the same opinion as Mike? The current approach follows the
OpenCMIS implementation. Do we want to have something different here?

Regards,
Lukas

On 18/07/14 02:39 pm, "Gavin Cornwell" <gavin.cornwell@alfresco.com> wrote:

>Hi,
>
>I raised and fixed https://issues.apache.org/jira/browse/CMIS-823 to
>cover the category issue I mentioned in the status call earlier this week.
>
>I¹ve also committed an update to release.sh to use the version number
>defined in ObjectiveCMIS.xcconfig so we only have to change it in one
>place.
>
>I had a quick look at the query escaping changes, I don¹t have anything
>else to add over and above what Mike said.
>
>That completes all the changes we wanted to make for 0.4.
>
>Regards,
>
>Gavin
>
>


Mime
View raw message