chemistry-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Carlo Sciolla (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CMIS-816) Allow custom error handling in the AtomPub and Browser bindings
Date Tue, 24 Jun 2014 14:32:24 GMT

    [ https://issues.apache.org/jira/browse/CMIS-816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14042172#comment-14042172
] 

Carlo Sciolla commented on CMIS-816:
------------------------------------

I will have a look at the wrapper, thanks for the pointer.

{quote}
Regarding the CSS: It only exists in the AtomPub binding implementation and an end-user should
never see this. There is also some OpenCMIS specific convention in the returned HTML message.
It's easy to break that if you return something custom. So, better not touch it.
{quote}

So, are you saying that OpenCMIS clients rely on the content of the error message in their
behavior? Is it documented somewhere? Besides, the Browser binding is even more interesting
as it's delivering a JSON back to the client, which is even more an interesting place where
custom elements can help (first use case that comes to mind: i18n message keys for the error).

The core of my position here is that Chemistry should not claim complete ownership of what
it sends over the wire, especially for the parts that are not strictly related to CMIS.

> Allow custom error handling in the AtomPub and Browser bindings
> ---------------------------------------------------------------
>
>                 Key: CMIS-816
>                 URL: https://issues.apache.org/jira/browse/CMIS-816
>             Project: Chemistry
>          Issue Type: Improvement
>          Components: opencmis-server
>    Affects Versions: OpenCMIS 0.11.0
>            Reporter: Carlo Sciolla
>            Priority: Critical
>         Attachments: protected-error-handling.patch
>
>
> The AtomPub and Browser bindings servlets implement exception handling through private
methods which are thus not extensible by end users. 
> This effectively inhibit fine grained control over error reporting, logging or contents
of the error messages.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message