chemistry-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Carlo Sciolla (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CMIS-816) Allow custom error handling in the AtomPub and Browser bindings
Date Tue, 24 Jun 2014 11:05:24 GMT

    [ https://issues.apache.org/jira/browse/CMIS-816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14041969#comment-14041969
] 

Carlo Sciolla commented on CMIS-816:
------------------------------------

This means that each service call needs to e.g. replicate the HTTP status code inference from
the exceptions. There is a reason why getErrorCode() / printError() live within the servlet,
i.e. it's the most valid catch-all location for errors before sending a reply to the client.
Especially for reporting runtime exceptions and programming errors, I would still consider
it a logical extension point.

If you think about it, pushing it to the service layer means that if one is not happy with,
say, the CSS of the rendered error message, the whole exception handling system, which nicely
maps 1-to-1 Exceptions to CMIS errors, must be reimplemented by the service layer. That doesn't
sound proper to me.

> Allow custom error handling in the AtomPub and Browser bindings
> ---------------------------------------------------------------
>
>                 Key: CMIS-816
>                 URL: https://issues.apache.org/jira/browse/CMIS-816
>             Project: Chemistry
>          Issue Type: Improvement
>          Components: opencmis-server
>    Affects Versions: OpenCMIS 0.11.0
>            Reporter: Carlo Sciolla
>            Priority: Critical
>         Attachments: protected-error-handling.patch
>
>
> The AtomPub and Browser bindings servlets implement exception handling through private
methods which are thus not extensible by end users. 
> This effectively inhibit fine grained control over error reporting, logging or contents
of the error messages.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message