Return-Path: X-Original-To: apmail-chemistry-dev-archive@www.apache.org Delivered-To: apmail-chemistry-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5618510D12 for ; Thu, 3 Apr 2014 12:34:26 +0000 (UTC) Received: (qmail 27643 invoked by uid 500); 3 Apr 2014 12:34:25 -0000 Delivered-To: apmail-chemistry-dev-archive@chemistry.apache.org Received: (qmail 27601 invoked by uid 500); 3 Apr 2014 12:34:24 -0000 Mailing-List: contact dev-help@chemistry.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@chemistry.apache.org Delivered-To: mailing list dev@chemistry.apache.org Received: (qmail 27593 invoked by uid 99); 3 Apr 2014 12:34:23 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 03 Apr 2014 12:34:23 +0000 X-ASF-Spam-Status: No, hits=-5.0 required=5.0 tests=RCVD_IN_DNSWL_HI,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of lukas.gross@sap.com designates 155.56.66.97 as permitted sender) Received: from [155.56.66.97] (HELO smtpgw.sap-ag.de) (155.56.66.97) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 03 Apr 2014 12:34:18 +0000 From: "Gross, Lukas" To: "dev@chemistry.apache.org" Subject: Re: Initial ObjectiveCMIS browser binding commit Thread-Topic: Initial ObjectiveCMIS browser binding commit Thread-Index: AQHPS5tzGJ2TYiPIMUugKHW7jupck5r/2q0A Date: Thu, 3 Apr 2014 12:33:43 +0000 Message-ID: In-Reply-To: <4BAD4139-3F45-462C-B5A7-EEDA16AEDF4D@alfresco.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Microsoft-MacOutlook/14.3.8.130913 x-originating-ip: [10.21.40.35] Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Virus-Checked: Checked by ClamAV on apache.org Hi, This sounds awesome. We'll have a look at the branch as soon as we have some time (probably tomorrow). So far I totally agree with your suggestions. However we should definitively have a call next week to discuss the next steps and to assign a first bunch of tasks :) Regards, Lukas On 3/29/14 11:08 PM, "Gavin Cornwell" wrote: >Hi, > >As you may have seen I have just committed my initial skeleton >implementation of the browser binding to the "browser-binding" branch of >ObjectiveCMIS. > >All services that have been implemented for the AtomPub binding are >stubbed out, each unimplemented method throws an exception. > >All JSON properties have been defined as constants in >CMISBrowserConstants and all parsing is currently performed in >CMISBrowserUtil. > >I've removed any binding specific items from CMISBindingSession, this >class (in my opinion) should remain binding agnostic. The atom pub >constants were moved to the CMISAtomPubConstants class and I've renamed >the "kCMISBindingSessionKeyAtomPubUrl" constant to >"kCMISBindingSessionKeyUrl". > >Tests obviously require a server that supports the browser binding and >requires a new key called "binding" set to "browser" in the >configuration, for example: > > > username > admin > password > admin > url > =20 >http://localhost:8080/alfresco/api/cmis/versions/1.1/browserng> > repositoryId > -default- > binding > browser > > >The first four tests are passing. My approach so far has been to take >each test as it comes and implement the underlying methods that are >required to make it pass. > >There's obviously still lots to do (marked as such in the code) and this >exercise has also highlighted some re-factoring I would like to suggest >we do: > >- Several classes that are using "id" and "description" as property >names, we should change these as they have other meanings in ObjectiveC >- All AtomPub related classes should be renamed to include the word Atom >- All the URIBuilder classes should be moved up a folder as I don't think >they are specific to AtomPub, they could be re-used across other bindings > >We can discuss this and the approach for implementing the rest of the >binding in our next status call, which I'll arrange first thing next week. > >Regards, > >Gavin >