Return-Path: 
 <dev-return-6881-apmail-chemistry-dev-archive=chemistry.apache.org@chemistry.apache.org>
X-Original-To: apmail-chemistry-dev-archive@www.apache.org
Delivered-To: apmail-chemistry-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id D72DF10488
	for <apmail-chemistry-dev-archive@www.apache.org>;
 Mon,  7 Oct 2013 15:30:48 +0000 (UTC)
Received: (qmail 30887 invoked by uid 500); 7 Oct 2013 15:30:44 -0000
Delivered-To: apmail-chemistry-dev-archive@chemistry.apache.org
Received: (qmail 30810 invoked by uid 500); 7 Oct 2013 15:30:43 -0000
Mailing-List: contact dev-help@chemistry.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@chemistry.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@chemistry.apache.org>
List-Post: <mailto:dev@chemistry.apache.org>
List-Id: <dev.chemistry.apache.org>
Reply-To: dev@chemistry.apache.org
Delivered-To: mailing list dev@chemistry.apache.org
Received: (qmail 30779 invoked by uid 99); 7 Oct 2013 15:30:42 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 07 Oct 2013 15:30:42 +0000
Date: Mon, 7 Oct 2013 15:30:42 +0000 (UTC)
From: =?utf-8?Q?Florian_M=C3=BCller_=28JIRA=29?= <jira@apache.org>
To: dev@chemistry.apache.org
Message-ID: <JIRA.12668645.1379185388097.25808.1381159842871@arcas>
In-Reply-To: <JIRA.12668645.1379185388097@arcas>
References: <JIRA.12668645.1379185388097@arcas>
Subject: [jira] [Commented] (CMIS-722) getContentChanges doesn't renew
 Holder<String>changeLogToken in AtomPub Client
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/CMIS-722?page=3Dcom.atlassian.j=
ira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D137882=
19#comment-13788219 ]=20

Florian M=C3=BCller commented on CMIS-722:
-------------------------------------

If nobody objects, this extra XML element will stay. It's not part of the C=
MIS standard, though =E2=80=93 don't rely on it!
The default next link was wrong. If there is no next page (hasMoreItems =3D=
=3D false), the next link doesn=E2=80=99t make sense. So, I removed it.

> getContentChanges doesn't renew Holder<String>changeLogToken in AtomPub C=
lient
> -------------------------------------------------------------------------=
-----
>
>                 Key: CMIS-722
>                 URL: https://issues.apache.org/jira/browse/CMIS-722
>             Project: Chemistry
>          Issue Type: Bug
>          Components: opencmis-client-bindings
>    Affects Versions: OpenCMIS 0.10.0
>            Reporter: linzhixing
>
> org.apache.chemistry.opencmis.client.bindings.spi.atompub.DiscoveryServic=
eImpl#getContentChanges, which is called from SessionImpl(Line:326), seems =
not to return a new Holder<String>changeLogToken argument. When I execute g=
etContentChange from OpenCMIS client, changeLogToken remains the same as it=
s input value.=20
> I confirmed that my CMIS server updates Holder<String>changeLogToken to t=
he latest token in the returned list both in debugging and Atom feed <atom:=
link rel=3D"next">.
> To see org.apache.chemistry.opencmis.client.bindings.spi.webservices.Disc=
overyServiceImpl#getContentChanges(Line:66), one can find
>     setHolderValue(portChangeLokToken, changeLogToken);
> but I can't find any such code in atompub DiscoveryServiceImpl.
> So I suppose some codes should be added that sets a renewed changeLogToke=
n reading from an atom feed page link.



--
This message was sent by Atlassian JIRA
(v6.1#6144)