chemistry-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maciej Jankowski (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CMIS-726) AbstractCmisService.addTypeChildren
Date Tue, 01 Oct 2013 14:42:24 GMT

    [ https://issues.apache.org/jira/browse/CMIS-726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13783000#comment-13783000
] 

Maciej Jankowski commented on CMIS-726:
---------------------------------------

Now I see it. My test failed and i thought it is because of a bug in the framework. Apparently,
my test was incorrect. I didn't take hierarchical structure of TypeDefinitionContainer into
account.

> AbstractCmisService.addTypeChildren
> -----------------------------------
>
>                 Key: CMIS-726
>                 URL: https://issues.apache.org/jira/browse/CMIS-726
>             Project: Chemistry
>          Issue Type: Bug
>          Components: opencmis-commons
>    Affects Versions: OpenCMIS 0.10.0
>            Reporter: Maciej Jankowski
>
> getTypeDescendants should recursively go down the tree of types and collect them. There
is a code:
>  if (children != null && children.getList() != null && children.getList().size()
> 0) {
>             List<TypeDefinitionContainer> list = new ArrayList<TypeDefinitionContainer>();
>             container.setChildren(list);
> It means that there is always an empty list added to the resulting list. Is that  how
it should work? 
> In the end, the method always returns children instead of descendants.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message