chemistry-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "linzhixing (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CMIS-722) getContentChanges doesn't renew Holder<String>changeLogToken in AtomPub Client
Date Tue, 24 Sep 2013 12:00:06 GMT

    [ https://issues.apache.org/jira/browse/CMIS-722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13776236#comment-13776236
] 

linzhixing commented on CMIS-722:
---------------------------------

As mentioned above, I need the latest token of the returned change events object, not of the
repository info.
Because when I call the first getContentChanges with the lower maxNumitems than repositoryInfo's
latest token implies, I have to call the second getContentChanges again specifying the latest
token of the first result as the starting point, and so forth until the result has no more
items. That is the problem.

I also thought that Itemiterable<ChangeEvent> getContentChanges is intended to return
all the entries to the repositoryInfo's latest token at a call regardless of maxNumItems.
In that case, I don't need a latest token of the result for the second call, for i can retrieve
all the change logs at that time at one call.
The fact is, it returns only the specified number of entries while some other entries are
not returned.

I suppose simply it goes well that the method returns an atom next link or a token value parsed
from it as ChangeEvents object's CmisExtension or as ExtendedHolder<String>changeLogToken.
They are accessible for API users. 
                
> getContentChanges doesn't renew Holder<String>changeLogToken in AtomPub Client
> ------------------------------------------------------------------------------
>
>                 Key: CMIS-722
>                 URL: https://issues.apache.org/jira/browse/CMIS-722
>             Project: Chemistry
>          Issue Type: Bug
>          Components: opencmis-client-bindings
>    Affects Versions: OpenCMIS 0.10.0
>            Reporter: linzhixing
>
> org.apache.chemistry.opencmis.client.bindings.spi.atompub.DiscoveryServiceImpl#getContentChanges,
which is called from SessionImpl(Line:326), seems not to return a new Holder<String>changeLogToken
argument. When I execute getContentChange from OpenCMIS client, changeLogToken remains the
same as its input value. 
> I confirmed that my CMIS server updates Holder<String>changeLogToken to the latest
token in the returned list both in debugging and Atom feed <atom:link rel="next">.
> To see org.apache.chemistry.opencmis.client.bindings.spi.webservices.DiscoveryServiceImpl#getContentChanges(Line:66),
one can find
>     setHolderValue(portChangeLokToken, changeLogToken);
> but I can't find any such code in atompub DiscoveryServiceImpl.
> So I suppose some codes should be added that sets a renewed changeLogToken reading from
an atom feed page link.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message