chemistry-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Florian Müller (JIRA) <j...@apache.org>
Subject [jira] [Commented] (CMIS-722) getContentChanges doesn't renew Holder<String>changeLogToken in AtomPub Client
Date Tue, 17 Sep 2013 07:41:53 GMT

    [ https://issues.apache.org/jira/browse/CMIS-722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13769293#comment-13769293
] 

Florian Müller commented on CMIS-722:
-------------------------------------

The spec only defines that the next link must *somehow* include a change log token.

It's totally valid that a repository that has been called wit this URL:
{{http://example.org/rep1/changelog?maxItems=100&changeLogToken=abc}}
provides a next link that looks like this:
{{http://example.org/rep1/changelog?pageSize=100&token=xyz}}
or even this:
{{http://example.org/rep1/changelog?maxItems=100&changeLogToken=abc+100}}
                
> getContentChanges doesn't renew Holder<String>changeLogToken in AtomPub Client
> ------------------------------------------------------------------------------
>
>                 Key: CMIS-722
>                 URL: https://issues.apache.org/jira/browse/CMIS-722
>             Project: Chemistry
>          Issue Type: Bug
>          Components: opencmis-client-bindings
>    Affects Versions: OpenCMIS 0.10.0
>            Reporter: linzhixing
>
> org.apache.chemistry.opencmis.client.bindings.spi.atompub.DiscoveryServiceImpl#getContentChanges,
which is called from SessionImpl(Line:326), seems not to return a new Holder<String>changeLogToken
argument. When I execute getContentChange from OpenCMIS client, changeLogToken remains the
same as its input value. 
> I confirmed that my CMIS server updates Holder<String>changeLogToken to the latest
token in the returned list both in debugging and Atom feed <atom:link rel="next">.
> To see org.apache.chemistry.opencmis.client.bindings.spi.webservices.DiscoveryServiceImpl#getContentChanges(Line:66),
one can find
>     setHolderValue(portChangeLokToken, changeLogToken);
> but I can't find any such code in atompub DiscoveryServiceImpl.
> So I suppose some codes should be added that sets a renewed changeLogToken reading from
an atom feed page link.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message