chemistry-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jaime Porras López (JIRA) <j...@apache.org>
Subject [jira] [Commented] (CMIS-715) MimeHelper.decodeContentDispositionFilename() decoding issue
Date Thu, 05 Sep 2013 09:40:52 GMT

    [ https://issues.apache.org/jira/browse/CMIS-715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13758952#comment-13758952
] 

Jaime Porras López commented on CMIS-715:
-----------------------------------------

By the way, reviewing this I have detected a minor bug in the method org.apache.chemistry.opencmis.commons.impl.MimeHelper.encodeRFC2231value(String,
StringBuilder)

The code:
{code}
        try {
            bytes = value.getBytes(charset);
        } catch (UnsupportedEncodingException e) {
            return true;
        }
{code}
Should return false, not true.

Actually is not important because this only can happen when UTF-8 is not supported.
                
> MimeHelper.decodeContentDispositionFilename() decoding issue
> ------------------------------------------------------------
>
>                 Key: CMIS-715
>                 URL: https://issues.apache.org/jira/browse/CMIS-715
>             Project: Chemistry
>          Issue Type: Bug
>          Components: opencmis-client
>    Affects Versions: OpenCMIS 0.10.0, OpenCMIS 1.0.0
>            Reporter: jay brown
>
> Note: problem did not happen in version 0.9.0
> but occurs in latest versions and snapshot
> Problem:
> In a general case we have a file that is named 'flask-docs.pdf'
> When the stream is retrieved by OpenCMIS the respose from our server looks like this:
>        Content-Disposition: attachment; filename*=UTF-8''%66%6c%61%73%6b%2d%64%6f%63%73.pdf;
size=893099; creation-date=Mon, 12 Aug 2013 22:02:54 -0700; modification-date=Mon, 12 Aug
2013 22:02:55 -0700;
> But the call
>     contentStream = getBinding().getObjectService().getContentStream(getRepositoryId(),
docId.getId(), streamId, offset, length, null) which GET ContentStream/idd_B7569CE7-47B8-46F4-BF30-67FD2A903B32/-1/doc0
  
> returns a corrupted string like "f ` as` do`a" or something like that.  
> (some encoding that is not right)
> Opencmis code  below to set filename for content
>        String filename = null;
>         String contentDisposition = resp.getHeader("Content-Disposition");   
>         if (contentDisposition != null) {
>             filename = MimeHelper.decodeContentDispositionFilename(contentDisposition);
>         }  
> You can use our interop server to reproduce (contact me for credentials)
> Need to fix for 1.0.0

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message