Mailing-List: contact dev-help@chemistry.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@chemistry.apache.org
Received-SPF: pass (nike.apache.org: local policy)
From: "Denis Andreev" <andreev@elilink.com>
To: <dev@chemistry.apache.org>
Cc: "Alfresco Team" <ticoreb@elilink.com>
Subject: DotCMIS issue in
 DotCMIS.Binding.AtomPub.AtomEntryWriter.WriteContent()
Date: Tue, 15 Jan 2013 13:59:19 +0300
Message-ID: <001a01cdf30f$5f04edf0$1d0ec9d0$@com>
MIME-Version: 1.0
Content-Type: multipart/alternative;
	boundary="----=_NextPart_000_001B_01CDF328.845225F0"
Thread-Index: Ac3zD13yUY8o8hx8RXix3jCfeTJfJQ==
Content-Language: en-us

------=_NextPart_000_001B_01CDF328.845225F0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: 7bit

Hi Everyone

There is an issue in the method
DotCMIS.Binding.AtomPub.AtomEntryWriter.WriteContent()

 
        private void WriteContent(XmlWriter writer)

        {

            using (var br = new BinaryReader(stream))

            {

                var buffer = new byte[BufferSize];

                int readBytes = 0;

                do

                {

                    readBytes = br.Read(buffer, 0, BufferSize);

                    writer.WriteBase64(buffer, 0, readBytes);

                } while (BufferSize <= readBytes);

            }

        }

 
The problem is that the method "Stream.Read() or BinaryReader.Read()" may
read  less amount of bytes than the provided buffer size when the end of the
stream has not been reached yet.

For example.

The file "File1.txt" of size 30K is requested by HttpWebRequest to download
from a server and transfer it to Alfresco.

HttpWebRequest returns System.Net.ConnectStream. 

The  buffer size to read from stream is 65K.

In the code above the first read operation returns 4K from the stream and
the condition "while (BufferSize <= readBytes)" finishes the read cycle. 

 
I've fixed the problem with the code below. The read cycle should continue
working unit Read returns the value != 0:

 
        private void WriteContent(XmlWriter writer)

        {

            using (var br = new BinaryReader(stream))

            {

                var buffer = new byte[BufferSize];

                int readBytes = 0;

                while ((readBytes = br.Read(buffer, 0, BufferSize)) != 0)

                {

                    writer.WriteBase64(buffer, 0, readBytes);

                }

 
                /*

                do

                {

                    readBytes = br.Read(buffer, 0, BufferSize);

                    writer.WriteBase64(buffer, 0, readBytes);

                } while (BufferSize <= readBytes);

                */

            }

        }

 
Would you please consider this code and update DotCMIS library.

 
Best regards,

Denis Andreev

 
------=_NextPart_000_001B_01CDF328.845225F0--