chemistry-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jose Carlos Campanero (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CMIS-511) Full text search still is incomplete
Date Thu, 12 Apr 2012 16:41:20 GMT

    [ https://issues.apache.org/jira/browse/CMIS-511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13252556#comment-13252556
] 

Jose Carlos Campanero commented on CMIS-511:
--------------------------------------------

Michael, I attached a modified version of the patch: mostly everything works fine, but for
phrase searching the implementation provided changes the phrase itself.

I changed line 50 of the patch to include blank spaces with "OR" in the following class method
EvaluatorXPath:
{code}
    public XPathBuilder textOr(List<XPathBuilder> ops) {
        return new TextOpBuilder(ops, " OR ");
    }
{code}
 And the line 138, in the implementation of the method xPath() in TextOpBuilder:

{{sep = "" + RelOp + "" -> sep = RelOp;}}

I have eliminated also some strange characters that appear in the comments of the method {{escape()}}.

I attached also the test cases modified to include some tests about the new functionality.

Michael, I hope that this will solve the problem. Please, if you need anything, please tell
me.

Thank you.
                
> Full text search still is incomplete
> ------------------------------------
>
>                 Key: CMIS-511
>                 URL: https://issues.apache.org/jira/browse/CMIS-511
>             Project: Chemistry
>          Issue Type: Improvement
>          Components: opencmis-server-jcr
>            Reporter: Jose Carlos Campanero
>            Assignee: Michael Dürig
>         Attachments: CMIS-511.patch, CMIS-511.patch, QueryTranslatorTest.java, XPathBuilderTest.java
>
>
> Full text search still is incomplete: it's not possible query by content.
> In org.apache.chemistry.opencmis.jcr.query.ParseTreeWalker you can find:
>     private T walkTextAnd(Evaluator<T> evaluator2, Tree node) {
>         // TODO Auto-generated method stub
>         return null;
>     }
>     
>     private T walkTextOr(Evaluator<T> evaluator2, Tree node) {
>         // TODO Auto-generated method stub
>         return null;
>     }
>     
>     private T walkTextMinus(Evaluator<T> evaluator2, Tree node) {
>         // TODO Auto-generated method stub
>         return null;
>     }
>     
>     private T walkTextWord(Evaluator<T> evaluator2, Tree node) {
>         // TODO Auto-generated method stub
>         return null;
>     }
>     
>     private T walkTextPhrase(Evaluator<T> evaluator2, Tree node) {
>         // TODO Auto-generated method stub
>         return null;
>     }

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

Mime
View raw message