Mailing-List: contact dev-help@chemistry.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@chemistry.apache.org
Date: Tue, 6 Dec 2011 18:55:41 +0000 (UTC)
From: =?utf-8?Q?Florian_M=C3=BCller_=28Commented=29_=28JIRA=29?=
 <jira@apache.org>
To: dev@chemistry.apache.org
Message-ID: 
 <1787239987.46349.1323197741295.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1250317158.44907.1323164260187.JavaMail.tomcat@hel.zones.apache.org>
Subject: =?utf-8?Q?[jira]_[Commented]_(CMIS-483)_URLEncoder_for_g?=
 =?utf-8?Q?etObjectByPath_with_folder_name_like_CAR=C3=88_CARLA?=
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


    [ https://issues.apache.org/jira/browse/CMIS-483?page=3Dcom.atlassian.j=
ira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D131637=
38#comment-13163738 ]=20

Florian M=C3=BCller commented on CMIS-483:
-------------------------------------

UTF-8 is strongly recommended [1][2] for interoperability. Why should the e=
ncoding be configurable?

[1] http://tools.ietf.org/html/rfc3986#section-2.5
[2] http://www.w3.org/TR/html40/appendix/notes.html#non-ascii-chars
               =20
> URLEncoder for getObjectByPath with folder name like CAR=C3=88 CARLA
> ---------------------------------------------------------------
>
>                 Key: CMIS-483
>                 URL: https://issues.apache.org/jira/browse/CMIS-483
>             Project: Chemistry
>          Issue Type: Bug
>          Components: opencmis-client-bindings
>    Affects Versions: OpenCMIS 0.5.0
>            Reporter: Marco Spasiano
>              Labels: patch
>
> What do you think about this patch?
> {noformat}
> ### Eclipse Workspace Patch 1.0
> #P chemistry-opencmis-client-bindings
> Index: src/main/java/org/apache/chemistry/opencmis/client/bindings/spi/at=
ompub/LinkCache.java
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> --- src/main/java/org/apache/chemistry/opencmis/client/bindings/spi/atomp=
ub/LinkCache.java=09(revisione 1124118)
> +++ src/main/java/org/apache/chemistry/opencmis/client/bindings/spi/atomp=
ub/LinkCache.java=09(copia locale)
> @@ -68,6 +68,7 @@
>      private final Cache templateCache;
>      private final Cache repositoryLinkCache;
> =20
> +    private final String encoding;
>      /**
>       * Constructor.
>       */
> @@ -87,6 +88,8 @@
>              objCount =3D CACHE_SIZE_OBJECTS;
>          }
> =20
> +        encoding =3D (String) session.get(SessionParameter.LOCALE_VARIAN=
T, "UTF-8");
> +       =20
>          linkCache =3D new CacheImpl("Link Cache");
>          linkCache.initialize(new String[] {
>                  MapCacheLevelImpl.class.getName() + " " + MapCacheLevelI=
mpl.CAPACITY + "=3D" + repCount, // repository
> @@ -257,7 +260,7 @@
>                      String paramValue =3D UrlBuilder.normalizeParameter(=
parameters.get(param.toString()));
>                      if (paramValue !=3D null) {
>                          try {
> -                            result.append(URLEncoder.encode(paramValue, =
"UTF-8"));
> +                            result.append(URLEncoder.encode(paramValue, =
encoding));
>                          } catch (UnsupportedEncodingException e) {
>                              result.append(paramValue);
>                          }
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrato=
rs: https://issues.apache.org/jira/secure/ContactAdministrators!default.jsp=
a
For more information on JIRA, see: http://www.atlassian.com/software/jira