chemistry-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Florian Müller <>
Subject Re: AtomPub empty getAllVersions
Date Wed, 09 Nov 2011 18:43:26 GMT
Hi Florent,

Here is my view:
If the document type is versionable then there is always one version because the version series
is not empty. So the version list is not empty.
If the document type is not versionable then the allowable action for getAllVersions should
not be set and clients should not call it.
If a client ignores the allowable action the repository can either throw an exception (the
right way) or return a list with one version (the safe way).
In no case is the version list empty.

- Florian

On 09/11/2011 08:59, Florent Guillaume wrote:
> Hi,
> o.a.c.o.server.impl.atompub.VersioningService.getAllVersions fails if
> the underlying service returns no version.
> However, as discussed in the TC, the PWC should not really be
> considered a version, and returning nothing is a legitimate behavior
> if there never was a checkin.
> Does anyone object if I remove the code that requires the versions to
> not be empty?
> Regards,
> Florent

View raw message