Return-Path: X-Original-To: apmail-chemistry-dev-archive@www.apache.org Delivered-To: apmail-chemistry-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5AE229E66 for ; Tue, 11 Oct 2011 12:51:36 +0000 (UTC) Received: (qmail 14734 invoked by uid 500); 11 Oct 2011 12:51:36 -0000 Delivered-To: apmail-chemistry-dev-archive@chemistry.apache.org Received: (qmail 14699 invoked by uid 500); 11 Oct 2011 12:51:35 -0000 Mailing-List: contact dev-help@chemistry.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@chemistry.apache.org Delivered-To: mailing list dev@chemistry.apache.org Received: (qmail 14691 invoked by uid 99); 11 Oct 2011 12:51:35 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 11 Oct 2011 12:51:35 +0000 X-ASF-Spam-Status: No, hits=-2000.5 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 11 Oct 2011 12:51:33 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id CEDF4303E83 for ; Tue, 11 Oct 2011 12:51:11 +0000 (UTC) Date: Tue, 11 Oct 2011 12:51:11 +0000 (UTC) From: =?utf-8?Q?Michael_D=C3=BCrig_=28Commented=29_=28JIRA=29?= To: dev@chemistry.apache.org Message-ID: <1311470707.535.1318337471848.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <936830849.11350.1317815975381.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (CMIS-438) JcrDocument.setContentStream() should call getContextNode() to get content node MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/CMIS-438?page=3Dcom.atlassian.j= ira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D131249= 91#comment-13124991 ]=20 Michael D=C3=BCrig commented on CMIS-438: ------------------------------------ Although it might look wrong, the current code is correct: setContentStream= must set the stream on the content node of the current node. Not on the co= ntent node of the context node. The patch causes setting the content stream= of a version series to fail.=20 I suggest to add a comment in the code for clarification and to resolve thi= s issue as invalid.=20 =20 > JcrDocument.setContentStream() should call getContextNode() to get conten= t node > -------------------------------------------------------------------------= ------ > > Key: CMIS-438 > URL: https://issues.apache.org/jira/browse/CMIS-438 > Project: Chemistry > Issue Type: Bug > Components: opencmis-server-jcr > Affects Versions: OpenCMIS 0.6.0 > Reporter: Tobias Mattsson > Priority: Minor > Attachments: JcrDocument.patch > > > While all other methods in JcrFolder calls getContextNode() to get the co= ntent node setContentStream() does getNode().getNode(Node.JCR_CONTENT) to f= ind it. This makes extending JcrFolder to fit a custom node structure cumbe= rsome. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrato= rs: https://issues.apache.org/jira/secure/ContactAdministrators!default.jsp= a For more information on JIRA, see: http://www.atlassian.com/software/jira