Mailing-List: contact dev-help@chemistry.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@chemistry.apache.org
Date: Tue, 20 Sep 2011 14:46:08 +0000 (UTC)
From: =?utf-8?Q?Florian_M=C3=BCller_=28JIRA=29?= <jira@apache.org>
To: dev@chemistry.apache.org
Message-ID: 
 <617685453.46367.1316529968888.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <215372227.45578.1316514069332.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (CMIS-432) AbstractCmisService is not thread
 safe
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


    [ https://issues.apache.org/jira/browse/CMIS-432?page=3Dcom.atlassian.j=
ira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D131087=
50#comment-13108750 ]=20

Florian M=C3=BCller commented on CMIS-432:
-------------------------------------

See also http://chemistry.apache.org/java/developing/dev-server.html

> AbstractCmisService is not thread safe
> --------------------------------------
>
>                 Key: CMIS-432
>                 URL: https://issues.apache.org/jira/browse/CMIS-432
>             Project: Chemistry
>          Issue Type: Improvement
>          Components: opencmis-commons
>    Affects Versions: OpenCMIS 0.5.0
>            Reporter: Carlo Sciolla
>              Labels: concurrency, multithread, thread-safety
>
> The use of an unsynchronized HashMap for storing AbstractCmisService.obje=
ctInfoMap (see AbstractCmisService.getObjectInfoMap) makes it inherently th=
read unsafe. When extending that class, we ran in busy waits on HashMap.get=
, which we fixed overriding the following two methods to which we added the=
 {{syncronized}} bit:
> {code:java}
>     @Override
>     public synchronized ObjectInfo getObjectInfo(String repositoryId, Str=
ing objectId) {
>         return super.getObjectInfo(repositoryId, objectId);
>     }
>     @Override
>     public synchronized void addObjectInfo(ObjectInfo objectInfo) {
>         super.addObjectInfo(objectInfo);
>     }
> {code}
> It would still be nice if thread safety is provided by the library itself=
 without the need for external synchronization.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira