Return-Path: X-Original-To: apmail-chemistry-dev-archive@www.apache.org Delivered-To: apmail-chemistry-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6875D7B73 for ; Thu, 25 Aug 2011 11:15:16 +0000 (UTC) Received: (qmail 91473 invoked by uid 500); 25 Aug 2011 11:15:15 -0000 Delivered-To: apmail-chemistry-dev-archive@chemistry.apache.org Received: (qmail 91319 invoked by uid 500); 25 Aug 2011 11:15:04 -0000 Mailing-List: contact dev-help@chemistry.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@chemistry.apache.org Delivered-To: mailing list dev@chemistry.apache.org Received: (qmail 91310 invoked by uid 99); 25 Aug 2011 11:15:02 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 25 Aug 2011 11:15:02 +0000 X-ASF-Spam-Status: No, hits=-5.0 required=5.0 tests=RCVD_IN_DNSWL_HI,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of achim.weigel@sap.com designates 155.56.66.99 as permitted sender) Received: from [155.56.66.99] (HELO smtpgw.sap-ag.de) (155.56.66.99) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 25 Aug 2011 11:14:55 +0000 From: "Weigel, Achim" To: =?iso-8859-1?Q?Florian_M=FCller?= CC: "dev@chemistry.apache.org" Date: Thu, 25 Aug 2011 13:14:33 +0200 Subject: RE: Not set properties Thread-Topic: Not set properties Thread-Index: AcxjFjCqaeCC6+FJS2CCLucK4LKzvgAAJemQ Message-ID: <57FB0D12D0E5F3478D329465E18D056515ADB9FAE4@DEWDFECCR09.wdf.sap.corp> References: <57FB0D12D0E5F3478D329465E18D056515ADA5D00C@DEWDFECCR09.wdf.sap.corp> <4E526070.9030005@alfresco.com> <57FB0D12D0E5F3478D329465E18D056515ADADDC39@DEWDFECCR09.wdf.sap.corp> <4E536282.3060601@alfresco.com> <57FB0D12D0E5F3478D329465E18D056515ADB9FA8A@DEWDFECCR09.wdf.sap.corp> <4E562B3A.7050408@alfresco.com> In-Reply-To: <4E562B3A.7050408@alfresco.com> Accept-Language: en-US, de-DE Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US, de-DE Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Hi Florian, if my implementation returns all properties in case of an empty filter I go= t no errors. If I change this there are many errors like this one:=20 FAILURE: Root folder children check (RootFolderTest.java:91) FAILURE: Child and object fetched by path don't match! Id: 4e548ef9c64904= db9097cc01 (AbstractSessionTest.java:1414) FAILURE: Number of properties don't match (AbstractSessionTest.java:2036) INFO: expected: 14 / actual: 13 Best Regards, Achim -----Original Message----- From: Florian M=FCller [mailto:florian.mueller@alfresco.com]=20 Sent: Donnerstag, 25. August 2011 13:00 To: Weigel, Achim Cc: dev@chemistry.apache.org Subject: Re: Not set properties Hi Achim, The TCK should always set a "*" filter. If that's not the case, then it's a= bug. Please let me know if you find one of those. The Workbench sets different filters based on the data it requires and base= d on the Workbench configuration. - Florian On 25/08/2011 11:50, Weigel, Achim wrote: > Hi Florian, >=20 > the problem is gone with the new version of the workbench but might it be= , that the TCK of the workbench has the same problem, i.e. that it expects = all properties if the filter is not set? >=20 > Best Regards, > Achim >=20 >=20 > -----Original Message----- > From: Florian M=FCller [mailto:florian.mueller@alfresco.com]=20 > Sent: Dienstag, 23. August 2011 10:19 > To: Weigel, Achim > Cc: dev@chemistry.apache.org > Subject: Re: Not set properties >=20 > Hi Achim, >=20 > Please get the latest Workbench code. The problem with the compliance but= ton has been fixed. >=20 > getObjectInfo() only requires a small set of standard CMIS properties. Bu= t the implementation provided by OpenCMIS is only there for convenience. > In order to improve the performance you should override getObjectInfo() o= r getObjectInfoIntern() with your own implementation. >=20 >=20 > - Florian >=20 >=20 > On 23/08/2011 07:53, Weigel, Achim wrote: >> Hi Florian, >> >> thank you for the clarification.=20 >> >> >> Now I have the following problem. When I'm using "Check specification co= mpliance" button of the CMIS Workbench I get errors that some properties ar= e not returned. I have debugged and found out that the filter is always set= to "". I thought that in this case the repository could determine the prop= erties it wants to return. >> If I handle this case as if the filter is set to "*" the errors are gone= .=20 >> >> Another point is the method getObjectInfo which is called several times,= which has no filter parameter. Does this method pose any demands on the se= t of properties to return or is this also repository specific.=20 >> >> Best Regards, >> Achim >> >> -----Original Message----- >> From: Florian M=FCller [mailto:florian.mueller@alfresco.com]=20 >> Sent: Montag, 22. August 2011 15:58 >> To: dev@chemistry.apache.org; Weigel, Achim >> Subject: Re: Not set properties >> >> Hi Achim, >> >> Not-set properties have to be returned (see CMIS spec). There must be a = PropertyData object for each property. The value can be either null or an e= mpty list. OpenCMIS understands both. >> getProperties() and getPropertyList() have to return the same objects fo= r a property. The easiest way to assure that is to use the PropertiesImpl c= lass. >> >> >> - Florian >> >> >> On 22/08/2011 14:47, Weigel, Achim wrote: >>> Hello, >>> >>> I'm not sure what is expected if no value is set at an object for some = property X and this property is requested e.g. via a '*' filter. >>> >>> a) ObjectService.getProperties(...) >>> For the resulting Properties object should getProperties() contain a= n entry for X with a null value or a not null value PropertyData object? >>> For the resulting Properties object should getPropertyList() contain= an element for X? >>> >>> b) If in the case before getProperties() and getPropertyList() contain = a PropertyData entry for X what is expected for the method 'PropertyData= .getValues()': null or an empty list? >>> >>> Thank you very much in advance and best regards, >>> Achim >> >=20