Mailing-List: contact dev-help@chemistry.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@chemistry.apache.org
Received-SPF: pass (athena.apache.org: domain of jhuebel@opentext.com
 designates 149.235.128.48 as permitted sender)
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Subject: Re: svn commit: r1098638 -
 /chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-inmemory/src/main/java/org/apache/chemistry/opencmis/inmemory/types/DocumentTypeCreationHelper.java
Date: Tue, 10 May 2011 20:52:55 +0200
Message-ID: <11E8705F4573E64FB42C724ADC742F6F03353331@MUCXGC2.opentext.net>
In-Reply-To: <BANLkTikp2sw9ZqpBiFg6m0+BbA9HmvGsXQ@mail.gmail.com>
Thread-Topic: svn commit: r1098638 -
 /chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-inmemory/src/main/java/org/apache/chemistry/opencmis/inmemory/types/DocumentTypeCreationHelper.java
Thread-Index: AcwPMyY6LndkqPWYSkGbwNbeb7L8EAAEFLWX
From: =?iso-8859-1?Q?Jens_H=FCbel?= <jhuebel@opentext.com>
To: <dev@chemistry.apache.org>


This looks like needing a fix in the errata. If it is not specified.=20

I wonder how much sense this property makes at all if cmis:name is uses =
for path composition and the unique name constraint within a folder? =
Does anyone use contentFileName for this? =20

-------------
This message is sent from a mobile device.


----- Original Message -----
From: Florent Guillaume <fg@nuxeo.com>
To: dev@chemistry.apache.org <dev@chemistry.apache.org>
Sent: Tue May 10 18:55:31 2011
Subject: Re: svn commit: r1098638 - =
/chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-se=
rver-inmemory/src/main/java/org/apache/chemistry/opencmis/inmemory/types/=
DocumentTypeCreationHelper.java

On Tue, May 10, 2011 at 6:15 PM, Florian M=FCller
<florian.mueller@alfresco.com> wrote:
> The spec allows cmis:contentStreamFileName to be read-write but I =
think it would be inconsistent. It's probably an oversight since the =
Updatability is set for all properties except for this one. It doesn't =
not even say it is repository specific - it's just missing.

I can see a clear use case for wanting to change the filename of an
existing document without rewriting the whole content stream. In this
case having cmis:contentStreamFileName writable is a clear win. It's
much less common to want to change the mime type after the fact.

> The file name and the MIME type are set together with the content in =
the contentStream structure when a document is created or content is =
updated.
> If a client sets the file name in contentStream and sets =
cmis:contentStreamFileName during document creation, which one is =
authoritative?

Repo-specific.

> cmis:contentStreamMimeType is read-only. So, why should =
cmis:contentStreamFileName be read-write?
> And the other way round: If there is a reason to make =
cmis:contentStreamFileName read-write then cmis:contentStreamMimeType =
should also be read-write.

See above.

> Most repositories I have seen so far set cmis:contentStreamFileName to =
read-only.
> The change is more about clarity than spec compliance.

Anyway our repo is happy to allow writes to cmis:contentStreamFileName
and as long as the OpenCMIS library doesn't prevent this use case I'm
happy. If in-memory wants to be restrictive then why not, but I still
don't see the point when the implementation is cheap.

Florent


>
>
> Florian
>
>
>
> On 10/05/2011 16:22, Jens H=FCbel wrote:
>> Hmmm,
>>
>> looking at section 2.1.4.3.3 Property Definitions line 1357, I really =
don't see that updatability is enforced as read-only.
>>
>> @Florian: Florian, I think you pointed out that the original =
implementation does not behave correctly. Can you refer to the spec? Or =
did I misunderstand and changed the wrong place?
>>
>> Jens
>>
>>
>> -----Original Message-----
>> From: Florent Guillaume [mailto:fg@nuxeo.com]
>> Sent: Dienstag, 10. Mai 2011 16:37
>> To: jens@apache.org
>> Cc: dev@chemistry.apache.org
>> Subject: Re: svn commit: r1098638 - =
/chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-se=
rver-inmemory/src/main/java/org/apache/chemistry/opencmis/inmemory/types/=
DocumentTypeCreationHelper.java
>>
>> Why?
>>
>> On Mon, May 2, 2011 at 6:04 PM,<jens@apache.org> =A0wrote:
>>> Author: jens
>>> Date: Mon May =A02 16:04:49 2011
>>> New Revision: 1098638
>>>
>>> URL: http://svn.apache.org/viewvc?rev=3D1098638&view=3Drev
>>> Log:
>>> make cmis:contentStreamFileName read-only for InMemory
>>>
>>> Modified:
>>> =A0 =A0 =
chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-ser=
ver-inmemory/src/main/java/org/apache/chemistry/opencmis/inmemory/types/D=
ocumentTypeCreationHelper.java
>>>
>>> Modified: =
chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-ser=
ver-inmemory/src/main/java/org/apache/chemistry/opencmis/inmemory/types/D=
ocumentTypeCreationHelper.java
>>> URL: =
http://svn.apache.org/viewvc/chemistry/opencmis/trunk/chemistry-opencmis-=
server/chemistry-opencmis-server-inmemory/src/main/java/org/apache/chemis=
try/opencmis/inmemory/types/DocumentTypeCreationHelper.java?rev=3D1098638=
&r1=3D1098637&r2=3D1098638&view=3Ddiff
>>> =
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D
>>> --- =
chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-ser=
ver-inmemory/src/main/java/org/apache/chemistry/opencmis/inmemory/types/D=
ocumentTypeCreationHelper.java (original)
>>> +++ =
chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-ser=
ver-inmemory/src/main/java/org/apache/chemistry/opencmis/inmemory/types/D=
ocumentTypeCreationHelper.java Mon May =A02 16:04:49 2011
>>> @@ -194,6 +194,7 @@ public class DocumentTypeCreationHelper
>>>
>>> =A0 =A0 =A0 =A0 =A0propS =3D =
PropertyCreationHelper.createStringDefinition(PropertyIds.CONTENT_STREAM_=
FILE_NAME,
>>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0"CMIS Content Stream File Name =
Property");
>>> + =A0 =A0 =A0 =A0propS.setUpdatability(Updatability.READONLY);
>>> =A0 =A0 =A0 =A0 =A0propertyDefinitions.put(propS.getId(), propS);
>>>
>>> =A0 =A0 =A0 =A0 =A0propId =3D =
PropertyCreationHelper.createIdDefinition(PropertyIds.CONTENT_STREAM_ID, =
"CMIS Stream Id Property");
>>>
>>>
>>>
>>
>>
>>
>
>


--=20
Florent Guillaume, Director of R&D, Nuxeo
Open Source, Java EE based, Enterprise Content Management (ECM)
http://www.nuxeo.com=A0=A0 http://www.nuxeo.org=A0=A0 +33 1 40 33 79 87