chemistry-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Klevenz, Stephan" <stephan.klev...@sap.com>
Subject FW: [jira] [Commented] (CMIS-369) OSGi Bundling: wrong package export in commons.impl bundle
Date Mon, 09 May 2011 09:07:54 GMT
Felix, 

Agree. Nevertheless the impl package is exported through 'commons.*' which
exports more than actually necessary. I would suggest the following:

1) Restrict export from 'commons.*' to 'commons.impl'. This will solve the
urgent issue that some bundles can not resolve dependencies.
2) Create new JIRA issue for refactoring task. I did not analyze in detail
but one option could be to change implementation bundles to OSGi fragments
that have access to implementation classes without the need to export them.

WYT?

Regards,
Stephan

 

 
>Hi,
>
>Am Freitag, den 06.05.2011, 14:55 +0000 schrieb Dieter Guendisch
>(JIRA): 
>> [ 
>>https://issues.apache.org/jira/browse/CMIS-369?page=com.atlassian.jira.pl
>>ugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13029966#com
>>ment-13029966 ] 
>> 
>> Dieter Guendisch commented on CMIS-369:
>> ---------------------------------------
>> 
>> Restricting package exports to
>>"org.apache.chemistry.opencmis.commons.impl.*" will do the trick.
>>Removing is not possible as e.g. the client-bindings bundle uses impl
>>packages from the commons-impl bundle.
>
>While not technically forbidden by the spec, exporting a package
>containing the name "impl" sounds completely wrong...
>
>By convention packages with "internal" or "impl" in them are kept
>private to bundles generally implementing publicly available API.
>
>Regards
>Felix
>
>> 
>> > OSGi Bundling: wrong package export in commons.impl bundle
>> > ----------------------------------------------------------
>> >
>> >                 Key: CMIS-369
>> >                 URL: https://issues.apache.org/jira/browse/CMIS-369
>> >             Project: Chemistry
>> >          Issue Type: Bug
>> >          Components: opencmis-commons
>> >    Affects Versions: OpenCMIS 0.3.0
>> >         Environment: Equinox based OSGi runtime
>> >            Reporter: Stephan Klevenz
>> >            Assignee: Stephan Klevenz
>> >             Fix For: OpenCMIS 0.4.0
>> >
>> >
>> > The bundle *.commons.impl wrongly exports many packages from client
>>and commons API, though no classes of these packages are contained in
>>the commons.impl bundle. This leads to "package uses conflicts" in the
>>OSGi runtime, which hinders some of the OpenCMIS bundles to successfully
>>resolve. 
>> 
>> --
>> This message is automatically generated by JIRA.
>> For more information on JIRA, see:
>>http://www.atlassian.com/software/jira
>> 
>
>


Mime
View raw message