chemistry-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Guendisch, Dieter" <dieter.guendi...@sap.com>
Subject Re: [jira] [Commented] (CMIS-369) OSGi Bundling: wrong package export in commons.impl bundle
Date Wed, 11 May 2011 12:06:17 GMT
Hi Felix,

you are right that impl packages should not be exposed.
However currently the bundle commons.impl exposes the impl packages plus a lot more packages
that it doesn't even contain.
So Stephan's proposed fix is not about fixing bad OpenCMIS bundle slicing (which results in
impl packages being exported) but about eliminating the exported packages that are not contained
in the respective bundle.
The fact that impl packages are exported is a different issue.

Regards,
Dieter

>Hi,
>
>Am Freitag, den 06.05.2011, 14:55 +0000 schrieb Dieter Guendisch
>(JIRA):
>> [ https://issues.apache.org/jira/browse/CMIS-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment->tabpanel&focusedCommentId=13029966#comment-13029966
>]
>>
>> Dieter Guendisch commented on CMIS-369:
> ---------------------------------------
>
> Restricting package exports to "org.apache.chemistry.opencmis.commons.impl.*" will do
>the trick. Removing is not possible as e.g. the client-bindings bundle uses impl packages
>from the commons-impl bundle.
>
>While not technically forbidden by the spec, exporting a package
>containing the name "impl" sounds completely wrong...
>
>By convention packages with "internal" or "impl" in them are kept
>private to bundles generally implementing publicly available API.
>
>Regards
>Felix
>
>>
>> > OSGi Bundling: wrong package export in commons.impl bundle
>> > ----------------------------------------------------------
>> >
>> >                 Key: CMIS-369
>> >                 URL: https://issues.apache.org/jira/browse/CMIS-369
>> >             Project: Chemistry
>> >          Issue Type: Bug
>> >          Components: opencmis-commons
>> >    Affects Versions: OpenCMIS 0.3.0
>> >         Environment: Equinox based OSGi runtime
>> >            Reporter: Stephan Klevenz
>> >            Assignee: Stephan Klevenz
>> >             Fix For: OpenCMIS 0.4.0
>> >
>> >
>> > The bundle *.commons.impl wrongly exports many packages from client and commons
>API, though no classes of these packages are contained in the commons.impl bundle. This
leads
>to "package uses conflicts" in the OSGi runtime, which hinders some of the OpenCMIS bundles
>to successfully resolve.
>>
>> --
>> This message is automatically generated by JIRA.
>> For more information on JIRA, see: http://www.atlassian.com/software/jira
>>



Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message