chemistry-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From David Caruana <david.caru...@alfresco.com>
Subject Re: svn commit: r936966 - /incubator/chemistry/opencmis/trunk/chemistry-opencmis-client/chemistry-opencmis-client-impl/src/main/java/org/apache/chemistry/opencmis/client/runtime/util/DefaultPagingIterator.java
Date Thu, 22 Apr 2010 18:10:39 GMT
Thank you for the nudge. Added.

On 22 Apr 2010, at 18:27, Florent Guillaume wrote:

> Hi,
> 
> Please make sure you add unit tests when fixing things like this...
> 
> Thanks,
> Florent
> 
> On Thu, Apr 22, 2010 at 7:07 PM, dcaruana <dcaruana@apache.org> wrote:
>> Author: dcaruana
>> Date: Thu Apr 22 17:07:46 2010
>> New Revision: 936966
>> 
>> URL: http://svn.apache.org/viewvc?rev=936966&view=rev
>> Log:
>> Fix issue where paging iterator did not reset total number of items after fetching
next page of results.
>> 
>> Modified:
>>    incubator/chemistry/opencmis/trunk/chemistry-opencmis-client/chemistry-opencmis-client-impl/src/main/java/org/apache/chemistry/opencmis/client/runtime/util/DefaultPagingIterator.java
>> 
>> Modified: incubator/chemistry/opencmis/trunk/chemistry-opencmis-client/chemistry-opencmis-client-impl/src/main/java/org/apache/chemistry/opencmis/client/runtime/util/DefaultPagingIterator.java
>> URL: http://svn.apache.org/viewvc/incubator/chemistry/opencmis/trunk/chemistry-opencmis-client/chemistry-opencmis-client-impl/src/main/java/org/apache/chemistry/opencmis/client/runtime/util/DefaultPagingIterator.java?rev=936966&r1=936965&r2=936966&view=diff
>> ==============================================================================
>> --- incubator/chemistry/opencmis/trunk/chemistry-opencmis-client/chemistry-opencmis-client-impl/src/main/java/org/apache/chemistry/opencmis/client/runtime/util/DefaultPagingIterator.java
(original)
>> +++ incubator/chemistry/opencmis/trunk/chemistry-opencmis-client/chemistry-opencmis-client-impl/src/main/java/org/apache/chemistry/opencmis/client/runtime/util/DefaultPagingIterator.java
Thu Apr 22 17:07:46 2010
>> @@ -119,6 +119,7 @@ public class DefaultPagingIterator<T> im
>>             skipCount += skipOffset;
>>             skipOffset = 0;
>>             this.page = pageFetch.fetchPage(skipCount);
>> +            this.totalItems = null;
>>             currentPage = this.page;
>>             if (currentPage != null) {
>>                 items = currentPage.getPage();
>> 
>> 
>> 
> 
> 
> 
> -- 
> Florent Guillaume, Director of R&D, Nuxeo
> Open Source, Java EE based, Enterprise Content Management (ECM)
> http://www.nuxeo.com   http://www.nuxeo.org   +33 1 40 33 79 87


Mime
View raw message