chemistry-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sfermig...@apache.org
Subject svn commit: r1094656 [3/4] - in /chemistry/opencmis/trunk: chemistry-opencmis-client/chemistry-opencmis-client-bindings/src/main/java/org/apache/chemistry/opencmis/client/bindings/cache/impl/ chemistry-opencmis-client/chemistry-opencmis-client-bindings...
Date Mon, 18 Apr 2011 17:08:29 GMT
Modified: chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-inmemory/src/test/java/org/apache/chemistry/opencmis/inmemory/MultiFilingTest.java
URL: http://svn.apache.org/viewvc/chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-inmemory/src/test/java/org/apache/chemistry/opencmis/inmemory/MultiFilingTest.java?rev=1094656&r1=1094655&r2=1094656&view=diff
==============================================================================
--- chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-inmemory/src/test/java/org/apache/chemistry/opencmis/inmemory/MultiFilingTest.java (original)
+++ chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-inmemory/src/test/java/org/apache/chemistry/opencmis/inmemory/MultiFilingTest.java Mon Apr 18 17:08:24 2011
@@ -36,7 +36,6 @@ import org.apache.chemistry.opencmis.com
 import org.apache.chemistry.opencmis.commons.enums.BaseTypeId;
 import org.apache.chemistry.opencmis.commons.enums.IncludeRelationships;
 import org.apache.chemistry.opencmis.commons.enums.VersioningState;
-import org.apache.chemistry.opencmis.commons.exceptions.CmisConstraintException;
 import org.apache.chemistry.opencmis.commons.exceptions.CmisNameConstraintViolationException;
 import org.apache.chemistry.opencmis.commons.exceptions.CmisNotSupportedException;
 import org.apache.chemistry.opencmis.commons.spi.Holder;
@@ -49,7 +48,7 @@ import org.junit.Test;
 
 public class MultiFilingTest extends AbstractServiceTst {
 
-    private static Log LOG = LogFactory.getLog(MultiFilingTest.class);
+    private static final Log LOG = LogFactory.getLog(MultiFilingTest.class);
     private static final String DOCUMENT_TYPE_ID = UnitTestTypeSystemCreator.COMPLEX_TYPE;
     private static final String FOLDER_TYPE_ID = InMemoryFolderTypeDefinition.getRootFolderType().getId();
     private static final String UNFILED_DOC_NAME = "Unfiled document";

Modified: chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-inmemory/src/test/java/org/apache/chemistry/opencmis/inmemory/NavigationServiceTest.java
URL: http://svn.apache.org/viewvc/chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-inmemory/src/test/java/org/apache/chemistry/opencmis/inmemory/NavigationServiceTest.java?rev=1094656&r1=1094655&r2=1094656&view=diff
==============================================================================
--- chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-inmemory/src/test/java/org/apache/chemistry/opencmis/inmemory/NavigationServiceTest.java (original)
+++ chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-inmemory/src/test/java/org/apache/chemistry/opencmis/inmemory/NavigationServiceTest.java Mon Apr 18 17:08:24 2011
@@ -47,7 +47,7 @@ import org.junit.Test;
  * @author Jens
  */
 public class NavigationServiceTest extends AbstractServiceTst {
-    private static Log log = LogFactory.getLog(NavigationServiceTest.class);
+    private static final Log log = LogFactory.getLog(NavigationServiceTest.class);
     private static final int NUM_ROOT_FOLDERS = 10;
     private String fLevel1FolderId;
 

Modified: chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-inmemory/src/test/java/org/apache/chemistry/opencmis/inmemory/ObjectCreator.java
URL: http://svn.apache.org/viewvc/chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-inmemory/src/test/java/org/apache/chemistry/opencmis/inmemory/ObjectCreator.java?rev=1094656&r1=1094655&r2=1094656&view=diff
==============================================================================
--- chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-inmemory/src/test/java/org/apache/chemistry/opencmis/inmemory/ObjectCreator.java (original)
+++ chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-inmemory/src/test/java/org/apache/chemistry/opencmis/inmemory/ObjectCreator.java Mon Apr 18 17:08:24 2011
@@ -43,9 +43,9 @@ import org.apache.chemistry.opencmis.com
 
 public class ObjectCreator {
 
-    private BindingsObjectFactory fFactory;
-    private ObjectService fObjSvc;
-    private String fRepositoryId;
+    private final BindingsObjectFactory fFactory;
+    private final ObjectService fObjSvc;
+    private final String fRepositoryId;
 
     public ObjectCreator(BindingsObjectFactory factory, ObjectService objSvc, String repositoryId) {
         fObjSvc = objSvc;

Modified: chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-inmemory/src/test/java/org/apache/chemistry/opencmis/inmemory/ObjectServiceTest.java
URL: http://svn.apache.org/viewvc/chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-inmemory/src/test/java/org/apache/chemistry/opencmis/inmemory/ObjectServiceTest.java?rev=1094656&r1=1094655&r2=1094656&view=diff
==============================================================================
--- chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-inmemory/src/test/java/org/apache/chemistry/opencmis/inmemory/ObjectServiceTest.java (original)
+++ chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-inmemory/src/test/java/org/apache/chemistry/opencmis/inmemory/ObjectServiceTest.java Mon Apr 18 17:08:24 2011
@@ -76,7 +76,7 @@ import org.junit.Test;
 
 public class ObjectServiceTest extends AbstractServiceTst {
 
-    private static Log log = LogFactory.getLog(ObjectServiceTest.class);
+    private static final Log log = LogFactory.getLog(ObjectServiceTest.class);
     public static final String TEST_FOLDER_TYPE_ID = "MyFolderType";
     public static final String TEST_DOCUMENT_TYPE_ID = "MyDocumentType";
     public static final String TEST_DOC_TYPE_WITH_DEFAULTS_ID = "DocumentTypeWithDefault";

Modified: chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-inmemory/src/test/java/org/apache/chemistry/opencmis/inmemory/RepositoryServiceTest.java
URL: http://svn.apache.org/viewvc/chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-inmemory/src/test/java/org/apache/chemistry/opencmis/inmemory/RepositoryServiceTest.java?rev=1094656&r1=1094655&r2=1094656&view=diff
==============================================================================
--- chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-inmemory/src/test/java/org/apache/chemistry/opencmis/inmemory/RepositoryServiceTest.java (original)
+++ chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-inmemory/src/test/java/org/apache/chemistry/opencmis/inmemory/RepositoryServiceTest.java Mon Apr 18 17:08:24 2011
@@ -75,10 +75,10 @@ public class RepositoryServiceTest exten
 
     // private CmisProvider fProvider;
 
-    private static Log log = LogFactory.getLog(RepositoryServiceTest.class);
+    private static final Log log = LogFactory.getLog(RepositoryServiceTest.class);
     private static final String REPOSITORY_ID = "UnitTestRepository";
 
-    static public class UnitTestRepositoryInfo implements RepositoryInfoCreator {
+    public static class UnitTestRepositoryInfo implements RepositoryInfoCreator {
 
         public RepositoryInfo createRepositoryInfo() {
             RepositoryCapabilitiesImpl caps = new RepositoryCapabilitiesImpl();
@@ -575,7 +575,7 @@ public class RepositoryServiceTest exten
         public static final String LEVEL1_TYPE = "DocumentLevel1";;
         public static final String LEVEL2_TYPE = "DocumentLevel2";
 
-        static public List<TypeDefinition> singletonTypes = buildTypesList();
+        public static List<TypeDefinition> singletonTypes = buildTypesList();
 
         public List<TypeDefinition> createTypesList() {
             return singletonTypes;
@@ -772,7 +772,7 @@ public class RepositoryServiceTest exten
             return singletonTypes;
         }
 
-        static public TypeDefinition getTypeById(String typeId) {
+        public static TypeDefinition getTypeById(String typeId) {
             for (TypeDefinition typeDef : singletonTypes)
                 if (typeDef.getId().equals(typeId))
                     return typeDef;

Modified: chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-inmemory/src/test/java/org/apache/chemistry/opencmis/inmemory/UnitTestTypeSystemCreator.java
URL: http://svn.apache.org/viewvc/chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-inmemory/src/test/java/org/apache/chemistry/opencmis/inmemory/UnitTestTypeSystemCreator.java?rev=1094656&r1=1094655&r2=1094656&view=diff
==============================================================================
--- chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-inmemory/src/test/java/org/apache/chemistry/opencmis/inmemory/UnitTestTypeSystemCreator.java (original)
+++ chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-inmemory/src/test/java/org/apache/chemistry/opencmis/inmemory/UnitTestTypeSystemCreator.java Mon Apr 18 17:08:24 2011
@@ -46,7 +46,7 @@ import org.apache.chemistry.opencmis.inm
 import org.apache.chemistry.opencmis.inmemory.types.PropertyCreationHelper;
 
 public class UnitTestTypeSystemCreator implements TypeCreator {
-    static public List<TypeDefinition> singletonTypes = buildTypesList();
+    public static List<TypeDefinition> singletonTypes = buildTypesList();
     public static final String COMPLEX_TYPE = "ComplexType";
     public static final String TOPLEVEL_TYPE = "DocumentTopLevel";
     public static final String LEVEL1_TYPE = "DocumentLevel1";;
@@ -84,7 +84,7 @@ public class UnitTestTypeSystemCreator i
         return singletonTypes;
     }
 
-    static public TypeDefinition getTypeById(String typeId) {
+    public static TypeDefinition getTypeById(String typeId) {
         for (TypeDefinition typeDef : singletonTypes)
             if (typeDef.getId().equals(typeId))
                 return typeDef;

Modified: chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-inmemory/src/test/java/org/apache/chemistry/opencmis/inmemory/VersionTestTypeSystemCreator.java
URL: http://svn.apache.org/viewvc/chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-inmemory/src/test/java/org/apache/chemistry/opencmis/inmemory/VersionTestTypeSystemCreator.java?rev=1094656&r1=1094655&r2=1094656&view=diff
==============================================================================
--- chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-inmemory/src/test/java/org/apache/chemistry/opencmis/inmemory/VersionTestTypeSystemCreator.java (original)
+++ chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-inmemory/src/test/java/org/apache/chemistry/opencmis/inmemory/VersionTestTypeSystemCreator.java Mon Apr 18 17:08:24 2011
@@ -30,9 +30,9 @@ import org.apache.chemistry.opencmis.inm
 import org.apache.chemistry.opencmis.inmemory.types.PropertyCreationHelper;
 
 public class VersionTestTypeSystemCreator implements TypeCreator {
-    static public String VERSION_TEST_DOCUMENT_TYPE_ID = "MyVersionedType";
-    static public String PROPERTY_ID = "StringProp";
-    static public List<TypeDefinition> singletonTypes = buildTypesList();
+    public static String VERSION_TEST_DOCUMENT_TYPE_ID = "MyVersionedType";
+    public static String PROPERTY_ID = "StringProp";
+    public static List<TypeDefinition> singletonTypes = buildTypesList();
 
     /**
      * in the public interface of this class we return the singleton containing
@@ -46,7 +46,7 @@ public class VersionTestTypeSystemCreato
         return singletonTypes;
     }
 
-    static public TypeDefinition getTypeById(String typeId) {
+    public static TypeDefinition getTypeById(String typeId) {
         for (TypeDefinition typeDef : singletonTypes)
             if (typeDef.getId().equals(typeId))
                 return typeDef;

Modified: chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-inmemory/src/test/java/org/apache/chemistry/opencmis/inmemory/VersioningTest.java
URL: http://svn.apache.org/viewvc/chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-inmemory/src/test/java/org/apache/chemistry/opencmis/inmemory/VersioningTest.java?rev=1094656&r1=1094655&r2=1094656&view=diff
==============================================================================
--- chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-inmemory/src/test/java/org/apache/chemistry/opencmis/inmemory/VersioningTest.java (original)
+++ chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-inmemory/src/test/java/org/apache/chemistry/opencmis/inmemory/VersioningTest.java Mon Apr 18 17:08:24 2011
@@ -61,7 +61,7 @@ import org.junit.Before;
 import org.junit.Test;
 
 public class VersioningTest extends AbstractServiceTst {
-    private static Log log = LogFactory.getLog(ObjectServiceTest.class);
+    private static final Log log = LogFactory.getLog(ObjectServiceTest.class);
     private static final String PROP_VALUE = "Mickey Mouse";
     private static final String PROP_VALUE_NEW = "Donald Duck";
     private static final String PROP_NAME = "My Versioned Document";
@@ -666,8 +666,8 @@ public class VersioningTest extends Abst
     }
 
     public static class VersionTestTypeSystemCreator implements TypeCreator {
-        static public String VERSION_TEST_DOCUMENT_TYPE_ID = "MyVersionedType";
-        static public String PROPERTY_ID = "StringProp";
+        public static String VERSION_TEST_DOCUMENT_TYPE_ID = "MyVersionedType";
+        public static String PROPERTY_ID = "StringProp";
 
         public List<TypeDefinition> createTypesList() {
             // always add CMIS default types

Modified: chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-inmemory/src/test/java/org/apache/chemistry/opencmis/inmemory/query/AbstractQueryConditionProcessor.java
URL: http://svn.apache.org/viewvc/chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-inmemory/src/test/java/org/apache/chemistry/opencmis/inmemory/query/AbstractQueryConditionProcessor.java?rev=1094656&r1=1094655&r2=1094656&view=diff
==============================================================================
--- chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-inmemory/src/test/java/org/apache/chemistry/opencmis/inmemory/query/AbstractQueryConditionProcessor.java (original)
+++ chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-inmemory/src/test/java/org/apache/chemistry/opencmis/inmemory/query/AbstractQueryConditionProcessor.java Mon Apr 18 17:08:24 2011
@@ -44,58 +44,58 @@ import org.apache.commons.logging.LogFac
 
 public abstract class AbstractQueryConditionProcessor implements QueryConditionProcessor {
 
-    private static Log LOG = LogFactory.getLog(ProcessQueryTest.class);
-    abstract public void onStartProcessing(Tree whereNode);
-    abstract public void onStopProcessing();
+    private static final Log LOG = LogFactory.getLog(ProcessQueryTest.class);
+    public abstract void onStartProcessing(Tree whereNode);
+    public abstract void onStopProcessing();
 
     // Compare operators
-    abstract public void onEquals(Tree eqNode, Tree leftNode, Tree rightNode);
-    abstract public void onNotEquals(Tree neNode, Tree leftNode, Tree rightNode);
-    abstract public void onGreaterThan(Tree gtNode, Tree leftNode, Tree rightNode);
-    abstract public void onGreaterOrEquals(Tree geNode, Tree leftNode, Tree rightNode);
-    abstract public void onLessThan(Tree ltNode, Tree leftNode, Tree rightNode);
-    abstract public void onLessOrEquals(Tree leqNode, Tree leftNode, Tree rightNode);
+    public abstract void onEquals(Tree eqNode, Tree leftNode, Tree rightNode);
+    public abstract void onNotEquals(Tree neNode, Tree leftNode, Tree rightNode);
+    public abstract void onGreaterThan(Tree gtNode, Tree leftNode, Tree rightNode);
+    public abstract void onGreaterOrEquals(Tree geNode, Tree leftNode, Tree rightNode);
+    public abstract void onLessThan(Tree ltNode, Tree leftNode, Tree rightNode);
+    public abstract void onLessOrEquals(Tree leqNode, Tree leftNode, Tree rightNode);
 
     // Boolean operators
     public void onPreNot(Tree opNode, Tree leftNode) {
     }
-    abstract public void onNot(Tree opNode, Tree leftNode);
+    public abstract void onNot(Tree opNode, Tree leftNode);
     public void onPostNot(Tree opNode, Tree leftNode) {
     }
     public void onPreAnd(Tree opNode, Tree leftNode, Tree rightNode) {
     }
-    abstract public void onAnd(Tree opNode, Tree leftNode, Tree rightNode);
+    public abstract void onAnd(Tree opNode, Tree leftNode, Tree rightNode);
     public void onPostAnd(Tree opNode, Tree leftNode, Tree rightNode) {
     }
     public void onPreOr(Tree opNode, Tree leftNode, Tree rightNode) {
     }
-    abstract public void onOr(Tree opNode, Tree leftNode, Tree rightNode);
+    public abstract void onOr(Tree opNode, Tree leftNode, Tree rightNode);
     public void onPostOr(Tree opNode, Tree leftNode, Tree rightNode) {
     }
 
     // Multi-value:
-    abstract public void onIn(Tree node, Tree colNode, Tree listNode);
-    abstract public void onNotIn(Tree node, Tree colNode, Tree listNode);
-    abstract public void onInAny(Tree node, Tree colNode, Tree listNode);
-    abstract public void onNotInAny(Tree node, Tree colNode, Tree listNode);
-    abstract public void onEqAny(Tree node, Tree literalNode, Tree colNode);
+    public abstract void onIn(Tree node, Tree colNode, Tree listNode);
+    public abstract void onNotIn(Tree node, Tree colNode, Tree listNode);
+    public abstract void onInAny(Tree node, Tree colNode, Tree listNode);
+    public abstract void onNotInAny(Tree node, Tree colNode, Tree listNode);
+    public abstract void onEqAny(Tree node, Tree literalNode, Tree colNode);
 
     // Null comparisons:
-    abstract public void onIsNull(Tree nullNode, Tree colNode);
-    abstract public void onIsNotNull(Tree notNullNode, Tree colNode);
+    public abstract void onIsNull(Tree nullNode, Tree colNode);
+    public abstract void onIsNotNull(Tree notNullNode, Tree colNode);
 
     // String matching:
-    abstract public void onIsLike(Tree node, Tree colNode, Tree stringNode);
-    abstract public void onIsNotLike(Tree node, Tree colNode, Tree stringNode);
+    public abstract void onIsLike(Tree node, Tree colNode, Tree stringNode);
+    public abstract void onIsNotLike(Tree node, Tree colNode, Tree stringNode);
 
     // Functions:
-    abstract public void onContains(Tree node, Tree colNode, Tree paramNode);
-    abstract public void onInFolder(Tree node, Tree colNode, Tree paramNode);
-    abstract public void onInTree(Tree node, Tree colNode, Tree paramNode);
-    abstract public void onScore(Tree node);
+    public abstract void onContains(Tree node, Tree colNode, Tree paramNode);
+    public abstract void onInFolder(Tree node, Tree colNode, Tree paramNode);
+    public abstract void onInTree(Tree node, Tree colNode, Tree paramNode);
+    public abstract void onScore(Tree node);
 
     // convenience method because everybody needs this piece of code
-    static public CmisQueryWalker getWalker(String statement) throws UnsupportedEncodingException, IOException, RecognitionException {
+    public static CmisQueryWalker getWalker(String statement) throws UnsupportedEncodingException, IOException, RecognitionException {
         CharStream input = new ANTLRInputStream(new ByteArrayInputStream(statement.getBytes("UTF-8")));
         TokenSource lexer = new CmisQlStrictLexer(input);
         TokenStream tokens = new CommonTokenStream(lexer);

Modified: chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-inmemory/src/test/java/org/apache/chemistry/opencmis/inmemory/query/AbstractQueryTest.java
URL: http://svn.apache.org/viewvc/chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-inmemory/src/test/java/org/apache/chemistry/opencmis/inmemory/query/AbstractQueryTest.java?rev=1094656&r1=1094655&r2=1094656&view=diff
==============================================================================
--- chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-inmemory/src/test/java/org/apache/chemistry/opencmis/inmemory/query/AbstractQueryTest.java (original)
+++ chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-inmemory/src/test/java/org/apache/chemistry/opencmis/inmemory/query/AbstractQueryTest.java Mon Apr 18 17:08:24 2011
@@ -31,8 +31,6 @@ import org.apache.chemistry.opencmis.com
 import org.apache.chemistry.opencmis.commons.definitions.PropertyDefinition;
 import org.apache.chemistry.opencmis.commons.definitions.PropertyStringDefinition;
 import org.apache.chemistry.opencmis.commons.definitions.TypeDefinition;
-import org.apache.chemistry.opencmis.commons.exceptions.CmisBaseException;
-import org.apache.chemistry.opencmis.commons.exceptions.CmisInvalidArgumentException;
 import org.apache.chemistry.opencmis.commons.impl.dataobjects.PropertyBooleanDefinitionImpl;
 import org.apache.chemistry.opencmis.commons.impl.dataobjects.PropertyDateTimeDefinitionImpl;
 import org.apache.chemistry.opencmis.commons.impl.dataobjects.PropertyIntegerDefinitionImpl;

Modified: chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-inmemory/src/test/java/org/apache/chemistry/opencmis/inmemory/query/EvalQueryTest.java
URL: http://svn.apache.org/viewvc/chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-inmemory/src/test/java/org/apache/chemistry/opencmis/inmemory/query/EvalQueryTest.java?rev=1094656&r1=1094655&r2=1094656&view=diff
==============================================================================
--- chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-inmemory/src/test/java/org/apache/chemistry/opencmis/inmemory/query/EvalQueryTest.java (original)
+++ chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-inmemory/src/test/java/org/apache/chemistry/opencmis/inmemory/query/EvalQueryTest.java Mon Apr 18 17:08:24 2011
@@ -43,7 +43,7 @@ import org.junit.Test;
 
 public class EvalQueryTest extends AbstractServiceTst {
     
-    private static Log log = LogFactory.getLog(EvalQueryTest.class);
+    private static final Log log = LogFactory.getLog(EvalQueryTest.class);
     private QueryTestDataCreator dataCreator;
     
     @Before

Modified: chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-inmemory/src/test/java/org/apache/chemistry/opencmis/inmemory/query/ProcessQueryTest.java
URL: http://svn.apache.org/viewvc/chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-inmemory/src/test/java/org/apache/chemistry/opencmis/inmemory/query/ProcessQueryTest.java?rev=1094656&r1=1094655&r2=1094656&view=diff
==============================================================================
--- chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-inmemory/src/test/java/org/apache/chemistry/opencmis/inmemory/query/ProcessQueryTest.java (original)
+++ chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-inmemory/src/test/java/org/apache/chemistry/opencmis/inmemory/query/ProcessQueryTest.java Mon Apr 18 17:08:24 2011
@@ -42,9 +42,9 @@ import org.junit.Test;
 
 public class ProcessQueryTest extends AbstractQueryTest {
 
-    private static Log LOG = LogFactory.getLog(ProcessQueryTest.class);
+    private static final Log LOG = LogFactory.getLog(ProcessQueryTest.class);
 
-    static private class TestQueryProcessor extends AbstractQueryConditionProcessor {
+    private static class TestQueryProcessor extends AbstractQueryConditionProcessor {
 
         private static final String ON_START = "onStartWasCalled";
         private static final String ON_STOP = "onStopWasCalled";

Modified: chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-inmemory/src/test/java/org/apache/chemistry/opencmis/inmemory/query/QueryParseTest.java
URL: http://svn.apache.org/viewvc/chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-inmemory/src/test/java/org/apache/chemistry/opencmis/inmemory/query/QueryParseTest.java?rev=1094656&r1=1094655&r2=1094656&view=diff
==============================================================================
--- chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-inmemory/src/test/java/org/apache/chemistry/opencmis/inmemory/query/QueryParseTest.java (original)
+++ chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-inmemory/src/test/java/org/apache/chemistry/opencmis/inmemory/query/QueryParseTest.java Mon Apr 18 17:08:24 2011
@@ -48,7 +48,7 @@ import org.junit.Test;
 
 public class QueryParseTest extends AbstractQueryTest {
 
-    private static Log LOG = LogFactory.getLog(QueryParseTest.class);
+    private static final Log LOG = LogFactory.getLog(QueryParseTest.class);
 
     @Before
     public void setUp() throws Exception {

Modified: chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-inmemory/src/test/java/org/apache/chemistry/opencmis/inmemory/query/QueryTestDataCreator.java
URL: http://svn.apache.org/viewvc/chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-inmemory/src/test/java/org/apache/chemistry/opencmis/inmemory/query/QueryTestDataCreator.java?rev=1094656&r1=1094655&r2=1094656&view=diff
==============================================================================
--- chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-inmemory/src/test/java/org/apache/chemistry/opencmis/inmemory/query/QueryTestDataCreator.java (original)
+++ chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-inmemory/src/test/java/org/apache/chemistry/opencmis/inmemory/query/QueryTestDataCreator.java Mon Apr 18 17:08:24 2011
@@ -37,7 +37,6 @@ import org.apache.chemistry.opencmis.com
 import org.apache.chemistry.opencmis.commons.data.ObjectData;
 import org.apache.chemistry.opencmis.commons.data.Properties;
 import org.apache.chemistry.opencmis.commons.data.PropertyData;
-import org.apache.chemistry.opencmis.commons.data.PropertyId;
 import org.apache.chemistry.opencmis.commons.enums.IncludeRelationships;
 import org.apache.chemistry.opencmis.commons.enums.VersioningState;
 import org.apache.chemistry.opencmis.commons.impl.dataobjects.BindingsObjectFactoryImpl;
@@ -46,7 +45,6 @@ import org.apache.chemistry.opencmis.com
 import org.apache.chemistry.opencmis.commons.spi.ObjectService;
 import org.apache.chemistry.opencmis.commons.spi.VersioningService;
 import org.apache.chemistry.opencmis.inmemory.UnitTestTypeSystemCreator;
-import org.apache.chemistry.opencmis.inmemory.VersioningTest.VersionTestTypeSystemCreator;
 
 import static org.apache.chemistry.opencmis.inmemory.UnitTestTypeSystemCreator.*;
 
@@ -73,11 +71,11 @@ import static org.apache.chemistry.openc
  */
 public class QueryTestDataCreator {
     
-    private BindingsObjectFactory fFactory = new BindingsObjectFactoryImpl();
-    private String rootFolderId;
-    private String repositoryId;
-    private ObjectService fObjSvc;
-    private VersioningService fVerSvc;
+    private final BindingsObjectFactory fFactory = new BindingsObjectFactoryImpl();
+    private final String rootFolderId;
+    private final String repositoryId;
+    private final ObjectService fObjSvc;
+    private final VersioningService fVerSvc;
     private String doc1, doc2, doc3, doc4, doc5;
     private String folder1;
     private String folder2;

Modified: chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-inmemory/src/test/java/org/apache/chemistry/opencmis/inmemory/query/QueryTypesTest.java
URL: http://svn.apache.org/viewvc/chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-inmemory/src/test/java/org/apache/chemistry/opencmis/inmemory/query/QueryTypesTest.java?rev=1094656&r1=1094655&r2=1094656&view=diff
==============================================================================
--- chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-inmemory/src/test/java/org/apache/chemistry/opencmis/inmemory/query/QueryTypesTest.java (original)
+++ chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-inmemory/src/test/java/org/apache/chemistry/opencmis/inmemory/query/QueryTypesTest.java Mon Apr 18 17:08:24 2011
@@ -19,9 +19,6 @@
 package org.apache.chemistry.opencmis.inmemory.query;
 
 import static org.junit.Assert.*;
-import static org.junit.Assert.assertEquals;
-import static org.junit.Assert.assertTrue;
-import static org.junit.Assert.fail;
 
 import java.util.List;
 import java.util.Map;
@@ -29,7 +26,6 @@ import java.util.Map;
 import org.antlr.runtime.RecognitionException;
 import org.apache.chemistry.opencmis.commons.definitions.TypeDefinition;
 import org.apache.chemistry.opencmis.inmemory.TypeManagerImpl;
-import org.apache.chemistry.opencmis.server.support.query.CmisQueryException;
 import org.apache.chemistry.opencmis.server.support.query.CmisQueryWalker;
 import org.apache.chemistry.opencmis.server.support.query.CmisSelector;
 import org.apache.chemistry.opencmis.server.support.query.ColumnReference;
@@ -43,7 +39,7 @@ import org.junit.Test;
 
 public class QueryTypesTest extends AbstractQueryTest {
 
-    private static Log LOG = LogFactory.getLog(QueryTypesTest.class);
+    private static final Log LOG = LogFactory.getLog(QueryTypesTest.class);
     private TypeManagerImpl tm;
 
     @Before

Modified: chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-support/src/main/java/org/apache/chemistry/opencmis/server/support/CmisServiceWrapper.java
URL: http://svn.apache.org/viewvc/chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-support/src/main/java/org/apache/chemistry/opencmis/server/support/CmisServiceWrapper.java?rev=1094656&r1=1094655&r2=1094656&view=diff
==============================================================================
--- chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-support/src/main/java/org/apache/chemistry/opencmis/server/support/CmisServiceWrapper.java (original)
+++ chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-support/src/main/java/org/apache/chemistry/opencmis/server/support/CmisServiceWrapper.java Mon Apr 18 17:08:24 2011
@@ -71,7 +71,7 @@ public class CmisServiceWrapper<T extend
     private BigInteger defaultMaxItems = null;
     private BigInteger defaultDepth = MINUS_ONE;
 
-    private T service;
+    private final T service;
 
     /**
      * Constructor.

Modified: chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-support/src/main/java/org/apache/chemistry/opencmis/server/support/query/ColumnReference.java
URL: http://svn.apache.org/viewvc/chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-support/src/main/java/org/apache/chemistry/opencmis/server/support/query/ColumnReference.java?rev=1094656&r1=1094655&r2=1094656&view=diff
==============================================================================
--- chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-support/src/main/java/org/apache/chemistry/opencmis/server/support/query/ColumnReference.java (original)
+++ chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-support/src/main/java/org/apache/chemistry/opencmis/server/support/query/ColumnReference.java Mon Apr 18 17:08:24 2011
@@ -23,8 +23,8 @@ import org.apache.chemistry.opencmis.com
 
 public class ColumnReference extends CmisSelector {
 
-    private String typeQueryName;  // type query name coming from query statement
-    private String propQueryName;  // property query name coming from query statement
+    private final String typeQueryName;  // type query name coming from query statement
+    private final String propQueryName;  // property query name coming from query statement
 
     // The following fields are set when the types are resolved:
     private String propertyId;

Modified: chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-support/src/main/java/org/apache/chemistry/opencmis/server/support/query/FunctionReference.java
URL: http://svn.apache.org/viewvc/chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-support/src/main/java/org/apache/chemistry/opencmis/server/support/query/FunctionReference.java?rev=1094656&r1=1094655&r2=1094656&view=diff
==============================================================================
--- chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-support/src/main/java/org/apache/chemistry/opencmis/server/support/query/FunctionReference.java (original)
+++ chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-support/src/main/java/org/apache/chemistry/opencmis/server/support/query/FunctionReference.java Mon Apr 18 17:08:24 2011
@@ -22,7 +22,7 @@ public class FunctionReference extends C
 
     public enum CmisQlFunction { SCORE, };
 
-    private CmisQlFunction function;
+    private final CmisQlFunction function;
 
     public FunctionReference(CmisQlFunction func) {
         this.function = func;

Modified: chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-support/src/main/java/org/apache/chemistry/opencmis/server/support/query/QueryObject.java
URL: http://svn.apache.org/viewvc/chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-support/src/main/java/org/apache/chemistry/opencmis/server/support/query/QueryObject.java?rev=1094656&r1=1094655&r2=1094656&view=diff
==============================================================================
--- chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-support/src/main/java/org/apache/chemistry/opencmis/server/support/query/QueryObject.java (original)
+++ chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-support/src/main/java/org/apache/chemistry/opencmis/server/support/query/QueryObject.java Mon Apr 18 17:08:24 2011
@@ -28,7 +28,6 @@ import java.util.Map;
 
 import org.antlr.runtime.tree.Tree;
 import org.apache.chemistry.opencmis.commons.definitions.TypeDefinition;
-import org.apache.chemistry.opencmis.commons.exceptions.CmisInvalidArgumentException;
 import org.apache.chemistry.opencmis.server.support.TypeManager;
 import org.apache.chemistry.opencmis.server.support.TypeValidator;
 import org.apache.commons.logging.Log;
@@ -43,7 +42,7 @@ import org.apache.commons.logging.LogFac
  */
 public class QueryObject {
 
-    private static Log LOG = LogFactory.getLog(QueryObject.class);
+    private static final Log LOG = LogFactory.getLog(QueryObject.class);
 
     // For error handling see:
     // http://www.antlr.org/pipermail/antlr-interest/2008-April/027600.html

Modified: chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-support/src/test/java/org/apache/chemistry/opencmis/server/support/query/AbstractParserTst.java
URL: http://svn.apache.org/viewvc/chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-support/src/test/java/org/apache/chemistry/opencmis/server/support/query/AbstractParserTst.java?rev=1094656&r1=1094655&r2=1094656&view=diff
==============================================================================
--- chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-support/src/test/java/org/apache/chemistry/opencmis/server/support/query/AbstractParserTst.java (original)
+++ chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-support/src/test/java/org/apache/chemistry/opencmis/server/support/query/AbstractParserTst.java Mon Apr 18 17:08:24 2011
@@ -42,7 +42,7 @@ import org.apache.commons.logging.LogFac
  */
 public class AbstractParserTst{
     
-    private static Log log = LogFactory.getLog(AbstractParserTst.class);
+    private static final Log log = LogFactory.getLog(AbstractParserTst.class);
         
     protected String superGrammarName;
     Class<?> lexer;

Modified: chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-support/src/test/java/org/apache/chemistry/opencmis/server/support/query/TestParserExt.java
URL: http://svn.apache.org/viewvc/chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-support/src/test/java/org/apache/chemistry/opencmis/server/support/query/TestParserExt.java?rev=1094656&r1=1094655&r2=1094656&view=diff
==============================================================================
--- chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-support/src/test/java/org/apache/chemistry/opencmis/server/support/query/TestParserExt.java (original)
+++ chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-support/src/test/java/org/apache/chemistry/opencmis/server/support/query/TestParserExt.java Mon Apr 18 17:08:24 2011
@@ -26,7 +26,7 @@ import org.junit.Test;
 
 public class TestParserExt extends AbstractParserTst {
 
-    private static Log log = LogFactory.getLog(TestParserStrict.class);
+    private static final Log log = LogFactory.getLog(TestParserStrict.class);
 
     @Before
     public void setUp() throws Exception {

Modified: chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-support/src/test/java/org/apache/chemistry/opencmis/server/support/query/TestParserStrict.java
URL: http://svn.apache.org/viewvc/chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-support/src/test/java/org/apache/chemistry/opencmis/server/support/query/TestParserStrict.java?rev=1094656&r1=1094655&r2=1094656&view=diff
==============================================================================
--- chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-support/src/test/java/org/apache/chemistry/opencmis/server/support/query/TestParserStrict.java (original)
+++ chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-support/src/test/java/org/apache/chemistry/opencmis/server/support/query/TestParserStrict.java Mon Apr 18 17:08:24 2011
@@ -30,7 +30,7 @@ import org.junit.Test;
  */
 public class TestParserStrict extends AbstractParserTst{
 
-    private static Log log = LogFactory.getLog(TestParserStrict.class);
+    private static final Log log = LogFactory.getLog(TestParserStrict.class);
 
     @Before
     public void setUp() throws Exception {

Modified: chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-browser/src/main/java/org/apache/chemistry/opencmis/browser/BrowseServlet.java
URL: http://svn.apache.org/viewvc/chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-browser/src/main/java/org/apache/chemistry/opencmis/browser/BrowseServlet.java?rev=1094656&r1=1094655&r2=1094656&view=diff
==============================================================================
--- chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-browser/src/main/java/org/apache/chemistry/opencmis/browser/BrowseServlet.java (original)
+++ chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-browser/src/main/java/org/apache/chemistry/opencmis/browser/BrowseServlet.java Mon Apr 18 17:08:24 2011
@@ -57,7 +57,7 @@ public class BrowseServlet extends HttpS
 
     private static final long serialVersionUID = 1L;
 
-    private static Log log = LogFactory.getLog(BrowseServlet.class);
+    private static final Log log = LogFactory.getLog(BrowseServlet.class);
 
     private static final String CONTEXT_PREFIX = "{ctx}";
     private static final String PARAM_URL = "url";

Modified: chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-fit/src/test/java/org/apache/chemistry/opencmis/fit/runtime/Fixture.java
URL: http://svn.apache.org/viewvc/chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-fit/src/test/java/org/apache/chemistry/opencmis/fit/runtime/Fixture.java?rev=1094656&r1=1094655&r2=1094656&view=diff
==============================================================================
--- chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-fit/src/test/java/org/apache/chemistry/opencmis/fit/runtime/Fixture.java (original)
+++ chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-fit/src/test/java/org/apache/chemistry/opencmis/fit/runtime/Fixture.java Mon Apr 18 17:08:24 2011
@@ -47,7 +47,7 @@ public class Fixture {
     public static final String SESSION_FACTORY = "org.apache.chemistry.opencmis.fit.runtime.session.factory";
     public static final String TEST_ROOT_FOLDER_ID = "org.apache.chemistry.opencmis.fit.runtime.root.folder.id";
 
-    private static Log log = LogFactory.getLog(Fixture.class);
+    private static final Log log = LogFactory.getLog(Fixture.class);
 
     /*
      * general
@@ -57,7 +57,7 @@ public class Fixture {
     /*
      * test data setup
      */
-    private FixtureSetup testData = new FixtureSetup(this);
+    private final FixtureSetup testData = new FixtureSetup(this);
 
     /**
      * @return session parameter

Modified: chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-fit/src/test/java/org/apache/chemistry/opencmis/fit/runtime/FixtureData.java
URL: http://svn.apache.org/viewvc/chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-fit/src/test/java/org/apache/chemistry/opencmis/fit/runtime/FixtureData.java?rev=1094656&r1=1094655&r2=1094656&view=diff
==============================================================================
--- chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-fit/src/test/java/org/apache/chemistry/opencmis/fit/runtime/FixtureData.java (original)
+++ chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-fit/src/test/java/org/apache/chemistry/opencmis/fit/runtime/FixtureData.java Mon Apr 18 17:08:24 2011
@@ -37,7 +37,7 @@ public enum FixtureData {
 			PROPERTY_NAME_STRING_MULTI_VALUED("org.apache.chemistry.opencmis.fit.runtime.multi.valued.property.name", null);
 			;
 
-	private String key;
+	private final String key;
 	private String value;
 
 	FixtureData(String key, String value) {

Modified: chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-fit/src/test/java/org/apache/chemistry/opencmis/fit/runtime/misc/AbstractReadOnlyCreateSessionIT.java
URL: http://svn.apache.org/viewvc/chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-fit/src/test/java/org/apache/chemistry/opencmis/fit/runtime/misc/AbstractReadOnlyCreateSessionIT.java?rev=1094656&r1=1094655&r2=1094656&view=diff
==============================================================================
--- chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-fit/src/test/java/org/apache/chemistry/opencmis/fit/runtime/misc/AbstractReadOnlyCreateSessionIT.java (original)
+++ chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-fit/src/test/java/org/apache/chemistry/opencmis/fit/runtime/misc/AbstractReadOnlyCreateSessionIT.java Mon Apr 18 17:08:24 2011
@@ -22,7 +22,6 @@ import java.util.Hashtable;
 
 import org.apache.chemistry.opencmis.client.api.Session;
 import org.apache.chemistry.opencmis.client.api.SessionFactory;
-import org.apache.chemistry.opencmis.commons.SessionParameter;
 import org.apache.chemistry.opencmis.fit.runtime.Fixture;
 import org.apache.commons.logging.Log;
 import org.apache.commons.logging.LogFactory;

Modified: chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-tck/src/main/java/org/apache/chemistry/opencmis/tck/CmisTestResultStatus.java
URL: http://svn.apache.org/viewvc/chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-tck/src/main/java/org/apache/chemistry/opencmis/tck/CmisTestResultStatus.java?rev=1094656&r1=1094655&r2=1094656&view=diff
==============================================================================
--- chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-tck/src/main/java/org/apache/chemistry/opencmis/tck/CmisTestResultStatus.java (original)
+++ chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-tck/src/main/java/org/apache/chemistry/opencmis/tck/CmisTestResultStatus.java Mon Apr 18 17:08:24 2011
@@ -29,7 +29,7 @@ public enum CmisTestResultStatus {
     FAILURE(4), // check failed and it is specification violation
     UNEXPECTED_EXCEPTION(5); // exception caught that is not handled by the test
 
-    private int level;
+    private final int level;
 
     private CmisTestResultStatus(int level) {
         this.level = level;

Modified: chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-tck/src/main/java/org/apache/chemistry/opencmis/tck/impl/AbstractCmisTestGroup.java
URL: http://svn.apache.org/viewvc/chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-tck/src/main/java/org/apache/chemistry/opencmis/tck/impl/AbstractCmisTestGroup.java?rev=1094656&r1=1094655&r2=1094656&view=diff
==============================================================================
--- chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-tck/src/main/java/org/apache/chemistry/opencmis/tck/impl/AbstractCmisTestGroup.java (original)
+++ chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-tck/src/main/java/org/apache/chemistry/opencmis/tck/impl/AbstractCmisTestGroup.java Mon Apr 18 17:08:24 2011
@@ -33,7 +33,7 @@ import org.junit.Test;
 public abstract class AbstractCmisTestGroup implements CmisTestGroup {
     private Map<String, String> parameters;
     private String name;
-    private List<CmisTest> tests = new ArrayList<CmisTest>();
+    private final List<CmisTest> tests = new ArrayList<CmisTest>();
     private boolean isEnabled = true;
     private CmisTestProgressMonitor progressMonitor;
 

Modified: chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-tck/src/main/java/org/apache/chemistry/opencmis/tck/impl/AbstractSessionTest.java
URL: http://svn.apache.org/viewvc/chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-tck/src/main/java/org/apache/chemistry/opencmis/tck/impl/AbstractSessionTest.java?rev=1094656&r1=1094655&r2=1094656&view=diff
==============================================================================
--- chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-tck/src/main/java/org/apache/chemistry/opencmis/tck/impl/AbstractSessionTest.java (original)
+++ chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-tck/src/main/java/org/apache/chemistry/opencmis/tck/impl/AbstractSessionTest.java Mon Apr 18 17:08:24 2011
@@ -64,7 +64,7 @@ import org.apache.chemistry.opencmis.tck
  */
 public abstract class AbstractSessionTest extends AbstractCmisTest {
 
-    public final static OperationContext SELECT_ALL_NO_CACHE_OC = new OperationContextImpl();
+    public static final OperationContext SELECT_ALL_NO_CACHE_OC = new OperationContextImpl();
     static {
         SELECT_ALL_NO_CACHE_OC.setFilterString("*");
         SELECT_ALL_NO_CACHE_OC.setCacheEnabled(false);
@@ -75,7 +75,7 @@ public abstract class AbstractSessionTes
         SELECT_ALL_NO_CACHE_OC.setRenditionFilterString("*");
     }
 
-    private SessionFactory factory = SessionFactoryImpl.newInstance();
+    private final SessionFactory factory = SessionFactoryImpl.newInstance();
     private Folder testFolder;
 
     public BindingType getBinding() {
@@ -1241,13 +1241,13 @@ public abstract class AbstractSessionTes
     // --- helper classes ---
 
     public class CmisPropertyDefintion {
-        private String id;
-        private Boolean required;
-        private PropertyType propertyType;
-        private Cardinality cardinality;
-        private Updatability updatability;
-        private Boolean queryable;
-        private Boolean orderable;
+        private final String id;
+        private final Boolean required;
+        private final PropertyType propertyType;
+        private final Cardinality cardinality;
+        private final Updatability updatability;
+        private final Boolean queryable;
+        private final Boolean orderable;
 
         public CmisPropertyDefintion(String id, Boolean required, PropertyType propertyType, Cardinality cardinality,
                 Updatability updatability, Boolean queryable, Boolean orderable) {

Modified: chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-tck/src/main/java/org/apache/chemistry/opencmis/tck/impl/CmisTestResultImpl.java
URL: http://svn.apache.org/viewvc/chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-tck/src/main/java/org/apache/chemistry/opencmis/tck/impl/CmisTestResultImpl.java?rev=1094656&r1=1094655&r2=1094656&view=diff
==============================================================================
--- chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-tck/src/main/java/org/apache/chemistry/opencmis/tck/impl/CmisTestResultImpl.java (original)
+++ chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-tck/src/main/java/org/apache/chemistry/opencmis/tck/impl/CmisTestResultImpl.java Mon Apr 18 17:08:24 2011
@@ -28,17 +28,17 @@ import org.apache.chemistry.opencmis.tck
  * CmisTestResult implementation.
  */
 public class CmisTestResultImpl implements CmisTestResult {
-    private String groupName;
-    private String testName;
-    private String message;
-    private CmisTestResultStatus status;
-    private Throwable exception;
+    private final String groupName;
+    private final String testName;
+    private final String message;
+    private final CmisTestResultStatus status;
+    private final Throwable exception;
     private StackTraceElement[] stackTrace;
     private String url;
     private String request;
     private String response;
-    private List<CmisTestResult> children = new ArrayList<CmisTestResult>();
-    private boolean isFatal;
+    private final List<CmisTestResult> children = new ArrayList<CmisTestResult>();
+    private final boolean isFatal;
 
     public CmisTestResultImpl(String groupName, String testName, String message, CmisTestResultStatus status,
             Throwable exception, boolean isFatal) {

Modified: chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-tck/src/main/java/org/apache/chemistry/opencmis/tck/impl/WrapperCmisTestGroup.java
URL: http://svn.apache.org/viewvc/chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-tck/src/main/java/org/apache/chemistry/opencmis/tck/impl/WrapperCmisTestGroup.java?rev=1094656&r1=1094655&r2=1094656&view=diff
==============================================================================
--- chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-tck/src/main/java/org/apache/chemistry/opencmis/tck/impl/WrapperCmisTestGroup.java (original)
+++ chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-tck/src/main/java/org/apache/chemistry/opencmis/tck/impl/WrapperCmisTestGroup.java Mon Apr 18 17:08:24 2011
@@ -26,7 +26,7 @@ import org.apache.chemistry.opencmis.tck
  * Helper group implementation that just hold one test.
  */
 public class WrapperCmisTestGroup extends AbstractCmisTestGroup {
-    private CmisTest test;
+    private final CmisTest test;
 
     public WrapperCmisTestGroup(CmisTest test) throws Exception {
         if (test == null) {

Modified: chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-tck/src/main/java/org/apache/chemistry/opencmis/tck/runner/AbstractRunner.java
URL: http://svn.apache.org/viewvc/chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-tck/src/main/java/org/apache/chemistry/opencmis/tck/runner/AbstractRunner.java?rev=1094656&r1=1094655&r2=1094656&view=diff
==============================================================================
--- chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-tck/src/main/java/org/apache/chemistry/opencmis/tck/runner/AbstractRunner.java (original)
+++ chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-tck/src/main/java/org/apache/chemistry/opencmis/tck/runner/AbstractRunner.java Mon Apr 18 17:08:24 2011
@@ -41,7 +41,7 @@ public abstract class AbstractRunner {
     public static final String DEFAULT_TCK_GROUPS = "/cmis-tck-groups.txt";
 
     private Map<String, String> parameters;
-    private List<CmisTestGroup> groups = new ArrayList<CmisTestGroup>();
+    private final List<CmisTestGroup> groups = new ArrayList<CmisTestGroup>();
     private boolean isCanceled = false;
 
     // --- parameters ---

Modified: chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-tck/src/main/java/org/apache/chemistry/opencmis/tck/runner/CmisTckAntTask.java
URL: http://svn.apache.org/viewvc/chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-tck/src/main/java/org/apache/chemistry/opencmis/tck/runner/CmisTckAntTask.java?rev=1094656&r1=1094655&r2=1094656&view=diff
==============================================================================
--- chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-tck/src/main/java/org/apache/chemistry/opencmis/tck/runner/CmisTckAntTask.java (original)
+++ chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-tck/src/main/java/org/apache/chemistry/opencmis/tck/runner/CmisTckAntTask.java Mon Apr 18 17:08:24 2011
@@ -34,11 +34,11 @@ import org.apache.tools.ant.Task;
  * CMIS TCK Ant Task.
  */
 public class CmisTckAntTask extends Task {
-    private final static String REPORT_TEXT = "text";
-    private final static String REPORT_XML = "xml";
-    private final static String REPORT_HTML = "html";
+    private static final String REPORT_TEXT = "text";
+    private static final String REPORT_XML = "xml";
+    private static final String REPORT_HTML = "html";
 
-    private final static String DEFAULT_REPORT_NAME = "cmis-tck-report";
+    private static final String DEFAULT_REPORT_NAME = "cmis-tck-report";
 
     private File parameters;
     private File groups;

Modified: chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-tools/src/main/java/org/apache/chemistry/opencmis/commander/Commander.java
URL: http://svn.apache.org/viewvc/chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-tools/src/main/java/org/apache/chemistry/opencmis/commander/Commander.java?rev=1094656&r1=1094655&r2=1094656&view=diff
==============================================================================
--- chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-tools/src/main/java/org/apache/chemistry/opencmis/commander/Commander.java (original)
+++ chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-tools/src/main/java/org/apache/chemistry/opencmis/commander/Commander.java Mon Apr 18 17:08:24 2011
@@ -39,14 +39,14 @@ import org.apache.chemistry.opencmis.com
  */
 public class Commander {
 
-    private final static Map<String, Command> COMMAND_MAP = new LinkedHashMap<String, Command>();
+    private static final Map<String, Command> COMMAND_MAP = new LinkedHashMap<String, Command>();
     static {
         addCommand(new InfosCommand());
         addCommand(new ListCommand());
         addCommand(new DeleteCommand());
     }
 
-    private PrintWriter fPW;
+    private final PrintWriter fPW;
 
     /**
      * Constructor.
@@ -135,7 +135,7 @@ public class Commander {
     /**
      * Adds a command
      */
-    private final static void addCommand(Command command) {
+    private static final void addCommand(Command command) {
         if ((command == null) || (command.getCommandName() == null)) {
             return;
         }

Modified: chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-util/src/main/java/org/apache/chemistry/opencmis/util/repository/MultiThreadedObjectGenerator.java
URL: http://svn.apache.org/viewvc/chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-util/src/main/java/org/apache/chemistry/opencmis/util/repository/MultiThreadedObjectGenerator.java?rev=1094656&r1=1094655&r2=1094656&view=diff
==============================================================================
--- chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-util/src/main/java/org/apache/chemistry/opencmis/util/repository/MultiThreadedObjectGenerator.java (original)
+++ chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-util/src/main/java/org/apache/chemistry/opencmis/util/repository/MultiThreadedObjectGenerator.java Mon Apr 18 17:08:24 2011
@@ -27,12 +27,12 @@ import org.apache.chemistry.opencmis.com
 
 public class MultiThreadedObjectGenerator {
 
-    static public enum Action {
+    public static enum Action {
         CreateDocument, CreateTree, CreateFolders
     };
 
     static class ObjectGeneratorRunner implements Runnable {
-        private Action fAction;
+        private final Action fAction;
         ObjectGenerator fObjGen;
         private String fRootFolderId;
         private int fFoldersPerFolders;
@@ -73,7 +73,7 @@ public class MultiThreadedObjectGenerato
 
     } // ObjectCreatorRunner
 
-    static private ObjectGenerator createObjectGenerator(CmisBinding binding, String repoId, int docsPerFolder,
+    private static ObjectGenerator createObjectGenerator(CmisBinding binding, String repoId, int docsPerFolder,
             int foldersPerFolders, int depth, String documentType, String folderType, int contentSizeInKB,
             String rootFolderId, boolean doCleanup) {
 
@@ -95,7 +95,7 @@ public class MultiThreadedObjectGenerato
         return gen;
     }
 
-    static private String getRootFolderId(CmisBinding binding, String repositoryId, String rootFolderId) {
+    private static String getRootFolderId(CmisBinding binding, String repositoryId, String rootFolderId) {
         RepositoryService repSvc = binding.getRepositoryService();
 
         RepositoryInfo rep = repSvc.getRepositoryInfo(repositoryId, null);

Modified: chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-util/src/main/java/org/apache/chemistry/opencmis/util/repository/ObjGenApp.java
URL: http://svn.apache.org/viewvc/chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-util/src/main/java/org/apache/chemistry/opencmis/util/repository/ObjGenApp.java?rev=1094656&r1=1094655&r2=1094656&view=diff
==============================================================================
--- chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-util/src/main/java/org/apache/chemistry/opencmis/util/repository/ObjGenApp.java (original)
+++ chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-util/src/main/java/org/apache/chemistry/opencmis/util/repository/ObjGenApp.java Mon Apr 18 17:08:24 2011
@@ -48,22 +48,22 @@ public class ObjGenApp {
     public static final String DEFAULT_ATOMPUB_URL = "http://localhost:8080/opencmis/atom";
     public static final String DEFAULT_WS_URL = "http://localhost:8080/cmis/services/";
 
-    private final static String CMD = "Command";
-    private final static String REPOSITORY_ID = "RepositoryId";
-    private final static String FILLER_DOCUMENT_TYPE_ID = "DocumentTypeId";
-    private final static String FILLER_FOLDER_TYPE_ID = "FolderTypeId";
-    private final static String FILLER_DOCS_PER_FOLDER = "DocsPerFolder";
-    private final static String FILLER_FOLDERS_PER_FOLDER = "FoldersPerFolder";
-    private final static String FILLER_DEPTH = "Depth";
-    private final static String FILLER_CONTENT_SIZE = "ContentSizeInKB";
-    private final static String COUNT = "Count";
-    private final static String BINDING = "Binding";
-    private final static String CLEANUP = "Cleanup";
-    private final static String ROOTFOLDER = "RootFolder";
-    private final static String THREADS = "Threads";
+    private static final String CMD = "Command";
+    private static final String REPOSITORY_ID = "RepositoryId";
+    private static final String FILLER_DOCUMENT_TYPE_ID = "DocumentTypeId";
+    private static final String FILLER_FOLDER_TYPE_ID = "FolderTypeId";
+    private static final String FILLER_DOCS_PER_FOLDER = "DocsPerFolder";
+    private static final String FILLER_FOLDERS_PER_FOLDER = "FoldersPerFolder";
+    private static final String FILLER_DEPTH = "Depth";
+    private static final String FILLER_CONTENT_SIZE = "ContentSizeInKB";
+    private static final String COUNT = "Count";
+    private static final String BINDING = "Binding";
+    private static final String CLEANUP = "Cleanup";
+    private static final String ROOTFOLDER = "RootFolder";
+    private static final String THREADS = "Threads";
 
-    private final static String BINDING_ATOM = "AtomPub";
-    private final static String BINDING_WS = "WebService";
+    private static final String BINDING_ATOM = "AtomPub";
+    private static final String BINDING_WS = "WebService";
 
     private CmisBinding binding;
     private boolean fUsingAtom;

Modified: chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-util/src/main/java/org/apache/chemistry/opencmis/util/repository/ObjectGenerator.java
URL: http://svn.apache.org/viewvc/chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-util/src/main/java/org/apache/chemistry/opencmis/util/repository/ObjectGenerator.java?rev=1094656&r1=1094655&r2=1094656&view=diff
==============================================================================
--- chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-util/src/main/java/org/apache/chemistry/opencmis/util/repository/ObjectGenerator.java (original)
+++ chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-util/src/main/java/org/apache/chemistry/opencmis/util/repository/ObjectGenerator.java Mon Apr 18 17:08:24 2011
@@ -58,14 +58,14 @@ import org.apache.commons.logging.LogFac
  */
 public class ObjectGenerator {
 
-    private static Log log = LogFactory.getLog(ObjectGenerator.class);
-    private BindingsObjectFactory fFactory;
+    private static final Log log = LogFactory.getLog(ObjectGenerator.class);
+    private final BindingsObjectFactory fFactory;
     NavigationService fNavSvc;
     ObjectService fObjSvc;
-    private String fRepositoryId;
-    private TimeLogger fTimeLoggerCreateDoc;
-    private TimeLogger fTimeLoggerCreateFolder;
-    private TimeLogger fTimeLoggerDelete;
+    private final String fRepositoryId;
+    private final TimeLogger fTimeLoggerCreateDoc;
+    private final TimeLogger fTimeLoggerCreateFolder;
+    private final TimeLogger fTimeLoggerDelete;
     private boolean fCleanup;
     List<String> fTopLevelDocsCreated; // list of ids created on first level
     List<String> fTopLevelFoldersCreated; // list of ids created on first level

Modified: chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-util/src/main/java/org/apache/chemistry/opencmis/util/repository/TimeLogger.java
URL: http://svn.apache.org/viewvc/chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-util/src/main/java/org/apache/chemistry/opencmis/util/repository/TimeLogger.java?rev=1094656&r1=1094655&r2=1094656&view=diff
==============================================================================
--- chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-util/src/main/java/org/apache/chemistry/opencmis/util/repository/TimeLogger.java (original)
+++ chemistry/opencmis/trunk/chemistry-opencmis-test/chemistry-opencmis-test-util/src/main/java/org/apache/chemistry/opencmis/util/repository/TimeLogger.java Mon Apr 18 17:08:24 2011
@@ -30,14 +30,14 @@ import org.apache.commons.logging.LogFac
  * 
  */
 public class TimeLogger {
-    private static Log LOG = LogFactory.getLog(TimeLogger.class);
+    private static final Log LOG = LogFactory.getLog(TimeLogger.class);
 
     private static class TimeRecord {
         public long fStart;
         public long fStop;
     };
 
-    private String fAction;
+    private final String fAction;
     private LinkedList<TimeRecord> fTimeRecs = new LinkedList<TimeRecord>();
     private final int maxSize = 2500;
     TimeRecord fCurrentRec;
@@ -196,7 +196,7 @@ public class TimeLogger {
 
     }
 
-    static private long getAverageTime(TimeLogger[] loggers) {
+    private static long getAverageTime(TimeLogger[] loggers) {
         long sum = 0;
         long size = 0;
 
@@ -218,7 +218,7 @@ public class TimeLogger {
         return (sum + size / 2) / size;
     }
 
-    static private long getMaxTime(TimeLogger[] loggers) {
+    private static long getMaxTime(TimeLogger[] loggers) {
         long max = Long.MIN_VALUE;
 
         for (int i = 0; i < loggers.length; i++) {
@@ -230,7 +230,7 @@ public class TimeLogger {
         return max;
     }
 
-    static private long getMinTime(TimeLogger[] loggers) {
+    private static long getMinTime(TimeLogger[] loggers) {
         long min = Long.MAX_VALUE;
 
         for (int i = 0; i < loggers.length; i++) {
@@ -242,7 +242,7 @@ public class TimeLogger {
         return min;
     }
 
-    static private long getTotalTime(TimeLogger[] loggers) {
+    private static long getTotalTime(TimeLogger[] loggers) {
         long totalTime = Long.MIN_VALUE;
 
         for (int i = 0; i < loggers.length; i++) {

Modified: chemistry/opencmis/trunk/chemistry-opencmis-workbench/chemistry-opencmis-workbench/src/main/java/org/apache/chemistry/opencmis/workbench/ChangeLogFrame.java
URL: http://svn.apache.org/viewvc/chemistry/opencmis/trunk/chemistry-opencmis-workbench/chemistry-opencmis-workbench/src/main/java/org/apache/chemistry/opencmis/workbench/ChangeLogFrame.java?rev=1094656&r1=1094655&r2=1094656&view=diff
==============================================================================
--- chemistry/opencmis/trunk/chemistry-opencmis-workbench/chemistry-opencmis-workbench/src/main/java/org/apache/chemistry/opencmis/workbench/ChangeLogFrame.java (original)
+++ chemistry/opencmis/trunk/chemistry-opencmis-workbench/chemistry-opencmis-workbench/src/main/java/org/apache/chemistry/opencmis/workbench/ChangeLogFrame.java Mon Apr 18 17:08:24 2011
@@ -49,7 +49,7 @@ public class ChangeLogFrame extends JFra
 
     private static final String WINDOW_TITLE = "CMIS Change Log";
 
-    private ClientModel model;
+    private final ClientModel model;
 
     private JTextField changeLogTokenField;
     private ChangeLogTable changeLogTable;
@@ -157,7 +157,7 @@ public class ChangeLogFrame extends JFra
 
             private static final long serialVersionUID = 1L;
 
-            private ChangeLogTable table;
+            private final ChangeLogTable table;
 
             public ChangeLogTableModel(ChangeLogTable table) {
                 this.table = table;

Modified: chemistry/opencmis/trunk/chemistry-opencmis-workbench/chemistry-opencmis-workbench/src/main/java/org/apache/chemistry/opencmis/workbench/ClientFrame.java
URL: http://svn.apache.org/viewvc/chemistry/opencmis/trunk/chemistry-opencmis-workbench/chemistry-opencmis-workbench/src/main/java/org/apache/chemistry/opencmis/workbench/ClientFrame.java?rev=1094656&r1=1094655&r2=1094656&view=diff
==============================================================================
--- chemistry/opencmis/trunk/chemistry-opencmis-workbench/chemistry-opencmis-workbench/src/main/java/org/apache/chemistry/opencmis/workbench/ClientFrame.java (original)
+++ chemistry/opencmis/trunk/chemistry-opencmis-workbench/chemistry-opencmis-workbench/src/main/java/org/apache/chemistry/opencmis/workbench/ClientFrame.java Mon Apr 18 17:08:24 2011
@@ -79,7 +79,7 @@ public class ClientFrame extends JFrame 
     private static final String GROOVY_SCRIPT_FOLDER = "/scripts/";
     private static final String GROOVY_SCRIPT_LIBRARY = "script-library.properties";
 
-    private Preferences prefs = Preferences.userNodeForPackage(this.getClass());
+    private final Preferences prefs = Preferences.userNodeForPackage(this.getClass());
 
     private LoginDialog loginDialog;
     private LogFrame logFrame;
@@ -93,7 +93,7 @@ public class ClientFrame extends JFrame 
     private FolderPanel folderPanel;
     private DetailsTabs detailsTabs;
 
-    private ClientModel model;
+    private final ClientModel model;
 
     public ClientFrame() {
         super();

Modified: chemistry/opencmis/trunk/chemistry-opencmis-workbench/chemistry-opencmis-workbench/src/main/java/org/apache/chemistry/opencmis/workbench/ClientHelper.java
URL: http://svn.apache.org/viewvc/chemistry/opencmis/trunk/chemistry-opencmis-workbench/chemistry-opencmis-workbench/src/main/java/org/apache/chemistry/opencmis/workbench/ClientHelper.java?rev=1094656&r1=1094655&r2=1094656&view=diff
==============================================================================
--- chemistry/opencmis/trunk/chemistry-opencmis-workbench/chemistry-opencmis-workbench/src/main/java/org/apache/chemistry/opencmis/workbench/ClientHelper.java (original)
+++ chemistry/opencmis/trunk/chemistry-opencmis-workbench/chemistry-opencmis-workbench/src/main/java/org/apache/chemistry/opencmis/workbench/ClientHelper.java Mon Apr 18 17:08:24 2011
@@ -53,8 +53,8 @@ import org.apache.commons.logging.LogFac
 
 public class ClientHelper {
 
-    private static Log log = LogFactory.getLog(ClientHelper.class);
-    private static int BUFFER_SIZE = 64 * 1024;
+    private static final Log log = LogFactory.getLog(ClientHelper.class);
+    private static final int BUFFER_SIZE = 64 * 1024;
 
     public static void showError(Component parent, Exception ex) {
         if (log.isErrorEnabled()) {
@@ -343,8 +343,8 @@ public class ClientHelper {
     }
 
     public static class FileEntry implements Comparable<FileEntry> {
-        private String name;
-        private String file;
+        private final String name;
+        private final String file;
 
         public FileEntry(String name, String file) {
             this.name = name;

Modified: chemistry/opencmis/trunk/chemistry-opencmis-workbench/chemistry-opencmis-workbench/src/main/java/org/apache/chemistry/opencmis/workbench/FolderPanel.java
URL: http://svn.apache.org/viewvc/chemistry/opencmis/trunk/chemistry-opencmis-workbench/chemistry-opencmis-workbench/src/main/java/org/apache/chemistry/opencmis/workbench/FolderPanel.java?rev=1094656&r1=1094655&r2=1094656&view=diff
==============================================================================
--- chemistry/opencmis/trunk/chemistry-opencmis-workbench/chemistry-opencmis-workbench/src/main/java/org/apache/chemistry/opencmis/workbench/FolderPanel.java (original)
+++ chemistry/opencmis/trunk/chemistry-opencmis-workbench/chemistry-opencmis-workbench/src/main/java/org/apache/chemistry/opencmis/workbench/FolderPanel.java Mon Apr 18 17:08:24 2011
@@ -41,7 +41,7 @@ public class FolderPanel extends JPanel 
 
 	private static final long serialVersionUID = 1L;
 
-	private ClientModel model;
+	private final ClientModel model;
 
 	private String parentId;
 

Modified: chemistry/opencmis/trunk/chemistry-opencmis-workbench/chemistry-opencmis-workbench/src/main/java/org/apache/chemistry/opencmis/workbench/FolderTable.java
URL: http://svn.apache.org/viewvc/chemistry/opencmis/trunk/chemistry-opencmis-workbench/chemistry-opencmis-workbench/src/main/java/org/apache/chemistry/opencmis/workbench/FolderTable.java?rev=1094656&r1=1094655&r2=1094656&view=diff
==============================================================================
--- chemistry/opencmis/trunk/chemistry-opencmis-workbench/chemistry-opencmis-workbench/src/main/java/org/apache/chemistry/opencmis/workbench/FolderTable.java (original)
+++ chemistry/opencmis/trunk/chemistry-opencmis-workbench/chemistry-opencmis-workbench/src/main/java/org/apache/chemistry/opencmis/workbench/FolderTable.java Mon Apr 18 17:08:24 2011
@@ -63,7 +63,7 @@ public class FolderTable extends JTable 
     private static final int[] COLUMN_WIDTHS = { 24, 200, 150, 150, 80, 180, 100, 180, 100, 300 };
     private static final int ID_COLUMN = 9;
 
-    private ClientModel model;
+    private final ClientModel model;
 
     private Map<BaseTypeId, ImageIcon> icons;
 

Modified: chemistry/opencmis/trunk/chemistry-opencmis-workbench/chemistry-opencmis-workbench/src/main/java/org/apache/chemistry/opencmis/workbench/LoginDialog.java
URL: http://svn.apache.org/viewvc/chemistry/opencmis/trunk/chemistry-opencmis-workbench/chemistry-opencmis-workbench/src/main/java/org/apache/chemistry/opencmis/workbench/LoginDialog.java?rev=1094656&r1=1094655&r2=1094656&view=diff
==============================================================================
--- chemistry/opencmis/trunk/chemistry-opencmis-workbench/chemistry-opencmis-workbench/src/main/java/org/apache/chemistry/opencmis/workbench/LoginDialog.java (original)
+++ chemistry/opencmis/trunk/chemistry-opencmis-workbench/chemistry-opencmis-workbench/src/main/java/org/apache/chemistry/opencmis/workbench/LoginDialog.java Mon Apr 18 17:08:24 2011
@@ -476,9 +476,9 @@ public class LoginDialog extends JDialog
     static class RepositoryRenderer extends JPanel implements ListCellRenderer {
         private static final long serialVersionUID = 1L;
 
-        private JLabel nameLabel;
-        private JLabel idLabel;
-        private JLabel descriptionLabel;
+        private final JLabel nameLabel;
+        private final JLabel idLabel;
+        private final JLabel descriptionLabel;
 
         public RepositoryRenderer() {
             super();

Modified: chemistry/opencmis/trunk/chemistry-opencmis-workbench/chemistry-opencmis-workbench/src/main/java/org/apache/chemistry/opencmis/workbench/QueryFrame.java
URL: http://svn.apache.org/viewvc/chemistry/opencmis/trunk/chemistry-opencmis-workbench/chemistry-opencmis-workbench/src/main/java/org/apache/chemistry/opencmis/workbench/QueryFrame.java?rev=1094656&r1=1094655&r2=1094656&view=diff
==============================================================================
--- chemistry/opencmis/trunk/chemistry-opencmis-workbench/chemistry-opencmis-workbench/src/main/java/org/apache/chemistry/opencmis/workbench/QueryFrame.java (original)
+++ chemistry/opencmis/trunk/chemistry-opencmis-workbench/chemistry-opencmis-workbench/src/main/java/org/apache/chemistry/opencmis/workbench/QueryFrame.java Mon Apr 18 17:08:24 2011
@@ -62,7 +62,7 @@ public class QueryFrame extends JFrame {
     private static final String WINDOW_TITLE = "CMIS Query";
     private static final String DEFAULT_QUERY = "SELECT * FROM cmis:document";
 
-    private ClientModel model;
+    private final ClientModel model;
 
     private JTextArea queryText;
     private JFormattedTextField maxHitsField;
@@ -256,9 +256,9 @@ public class QueryFrame extends JFrame {
 
         private int columnCount = 0;
         private int rowCount = 0;
-        private Map<String, Integer> columnMapping = new HashMap<String, Integer>();
-        private Map<Integer, Map<Integer, Object>> data = new HashMap<Integer, Map<Integer, Object>>();
-        private Map<Integer, Class<?>> columnClass = new HashMap<Integer, Class<?>>();
+        private final Map<String, Integer> columnMapping = new HashMap<String, Integer>();
+        private final Map<Integer, Map<Integer, Object>> data = new HashMap<Integer, Map<Integer, Object>>();
+        private final Map<Integer, Class<?>> columnClass = new HashMap<Integer, Class<?>>();
 
         public ResultTableModel() {
         }

Modified: chemistry/opencmis/trunk/chemistry-opencmis-workbench/chemistry-opencmis-workbench/src/main/java/org/apache/chemistry/opencmis/workbench/RepositoryInfoFrame.java
URL: http://svn.apache.org/viewvc/chemistry/opencmis/trunk/chemistry-opencmis-workbench/chemistry-opencmis-workbench/src/main/java/org/apache/chemistry/opencmis/workbench/RepositoryInfoFrame.java?rev=1094656&r1=1094655&r2=1094656&view=diff
==============================================================================
--- chemistry/opencmis/trunk/chemistry-opencmis-workbench/chemistry-opencmis-workbench/src/main/java/org/apache/chemistry/opencmis/workbench/RepositoryInfoFrame.java (original)
+++ chemistry/opencmis/trunk/chemistry-opencmis-workbench/chemistry-opencmis-workbench/src/main/java/org/apache/chemistry/opencmis/workbench/RepositoryInfoFrame.java Mon Apr 18 17:08:24 2011
@@ -38,7 +38,7 @@ public class RepositoryInfoFrame extends
 
     private static final String WINDOW_TITLE = "CMIS Repository Info";
 
-    private ClientModel model;
+    private final ClientModel model;
 
     public RepositoryInfoFrame(ClientModel model) {
         super();
@@ -74,7 +74,7 @@ public class RepositoryInfoFrame extends
 
         private static final long serialVersionUID = 1L;
 
-        private RepositoryInfo repInfo;
+        private final RepositoryInfo repInfo;
 
         public RepositoryInfoPanel(RepositoryInfo repInfo) {
             super();

Modified: chemistry/opencmis/trunk/chemistry-opencmis-workbench/chemistry-opencmis-workbench/src/main/java/org/apache/chemistry/opencmis/workbench/TckDialog.java
URL: http://svn.apache.org/viewvc/chemistry/opencmis/trunk/chemistry-opencmis-workbench/chemistry-opencmis-workbench/src/main/java/org/apache/chemistry/opencmis/workbench/TckDialog.java?rev=1094656&r1=1094655&r2=1094656&view=diff
==============================================================================
--- chemistry/opencmis/trunk/chemistry-opencmis-workbench/chemistry-opencmis-workbench/src/main/java/org/apache/chemistry/opencmis/workbench/TckDialog.java (original)
+++ chemistry/opencmis/trunk/chemistry-opencmis-workbench/chemistry-opencmis-workbench/src/main/java/org/apache/chemistry/opencmis/workbench/TckDialog.java Mon Apr 18 17:08:24 2011
@@ -56,8 +56,8 @@ import org.apache.chemistry.opencmis.wor
  */
 public class TckDialog {
 
-    private Frame owner;
-    private TckDialogRunner runner;
+    private final Frame owner;
+    private final TckDialogRunner runner;
 
     private JProgressBar groupsProgressBar;
     private JProgressBar testsProgressBar;
@@ -147,7 +147,7 @@ public class TckDialog {
 
         private static final long serialVersionUID = 1L;
 
-        private TckTask task;
+        private final TckTask task;
 
         public TckRunDialog() {
             super(owner, "TCK");
@@ -265,8 +265,8 @@ public class TckDialog {
     }
 
     class TckTask extends SwingWorker<Void, Void> {
-        private JDialog dialog;
-        private TckDialogRunner runner;
+        private final JDialog dialog;
+        private final TckDialogRunner runner;
 
         public TckTask(JDialog dialog, TckDialogRunner runner) {
             this.dialog = dialog;

Modified: chemistry/opencmis/trunk/chemistry-opencmis-workbench/chemistry-opencmis-workbench/src/main/java/org/apache/chemistry/opencmis/workbench/TypeSplitPane.java
URL: http://svn.apache.org/viewvc/chemistry/opencmis/trunk/chemistry-opencmis-workbench/chemistry-opencmis-workbench/src/main/java/org/apache/chemistry/opencmis/workbench/TypeSplitPane.java?rev=1094656&r1=1094655&r2=1094656&view=diff
==============================================================================
--- chemistry/opencmis/trunk/chemistry-opencmis-workbench/chemistry-opencmis-workbench/src/main/java/org/apache/chemistry/opencmis/workbench/TypeSplitPane.java (original)
+++ chemistry/opencmis/trunk/chemistry-opencmis-workbench/chemistry-opencmis-workbench/src/main/java/org/apache/chemistry/opencmis/workbench/TypeSplitPane.java Mon Apr 18 17:08:24 2011
@@ -242,7 +242,7 @@ public class TypeSplitPane extends JSpli
 
             private static final long serialVersionUID = 1L;
 
-            private PropertyDefinitionTable table;
+            private final PropertyDefinitionTable table;
 
             public PropertyDefinitionTableModel(PropertyDefinitionTable table) {
                 this.table = table;

Modified: chemistry/opencmis/trunk/chemistry-opencmis-workbench/chemistry-opencmis-workbench/src/main/java/org/apache/chemistry/opencmis/workbench/TypesFrame.java
URL: http://svn.apache.org/viewvc/chemistry/opencmis/trunk/chemistry-opencmis-workbench/chemistry-opencmis-workbench/src/main/java/org/apache/chemistry/opencmis/workbench/TypesFrame.java?rev=1094656&r1=1094655&r2=1094656&view=diff
==============================================================================
--- chemistry/opencmis/trunk/chemistry-opencmis-workbench/chemistry-opencmis-workbench/src/main/java/org/apache/chemistry/opencmis/workbench/TypesFrame.java (original)
+++ chemistry/opencmis/trunk/chemistry-opencmis-workbench/chemistry-opencmis-workbench/src/main/java/org/apache/chemistry/opencmis/workbench/TypesFrame.java Mon Apr 18 17:08:24 2011
@@ -42,7 +42,7 @@ public class TypesFrame extends JFrame {
 
     private static final String WINDOW_TITLE = "CMIS Types";
 
-    private ClientModel model;
+    private final ClientModel model;
 
     private JTree typesTree;
     private TypeSplitPane typePanel;
@@ -125,7 +125,7 @@ public class TypesFrame extends JFrame {
     }
 
     static class TypeNode {
-        private ObjectType type;
+        private final ObjectType type;
 
         public TypeNode(ObjectType type) {
             this.type = type;

Modified: chemistry/opencmis/trunk/chemistry-opencmis-workbench/chemistry-opencmis-workbench/src/main/java/org/apache/chemistry/opencmis/workbench/details/AbstractDetailsTable.java
URL: http://svn.apache.org/viewvc/chemistry/opencmis/trunk/chemistry-opencmis-workbench/chemistry-opencmis-workbench/src/main/java/org/apache/chemistry/opencmis/workbench/details/AbstractDetailsTable.java?rev=1094656&r1=1094655&r2=1094656&view=diff
==============================================================================
--- chemistry/opencmis/trunk/chemistry-opencmis-workbench/chemistry-opencmis-workbench/src/main/java/org/apache/chemistry/opencmis/workbench/details/AbstractDetailsTable.java (original)
+++ chemistry/opencmis/trunk/chemistry-opencmis-workbench/chemistry-opencmis-workbench/src/main/java/org/apache/chemistry/opencmis/workbench/details/AbstractDetailsTable.java Mon Apr 18 17:08:24 2011
@@ -146,7 +146,7 @@ public abstract class AbstractDetailsTab
 
     static class DetailsTableModel extends AbstractTableModel {
 
-        private AbstractDetailsTable table;
+        private final AbstractDetailsTable table;
 
         public DetailsTableModel(AbstractDetailsTable table) {
             this.table = table;

Modified: chemistry/opencmis/trunk/chemistry-opencmis-workbench/chemistry-opencmis-workbench/src/main/java/org/apache/chemistry/opencmis/workbench/details/ActionsPanel.java
URL: http://svn.apache.org/viewvc/chemistry/opencmis/trunk/chemistry-opencmis-workbench/chemistry-opencmis-workbench/src/main/java/org/apache/chemistry/opencmis/workbench/details/ActionsPanel.java?rev=1094656&r1=1094655&r2=1094656&view=diff
==============================================================================
--- chemistry/opencmis/trunk/chemistry-opencmis-workbench/chemistry-opencmis-workbench/src/main/java/org/apache/chemistry/opencmis/workbench/details/ActionsPanel.java (original)
+++ chemistry/opencmis/trunk/chemistry-opencmis-workbench/chemistry-opencmis-workbench/src/main/java/org/apache/chemistry/opencmis/workbench/details/ActionsPanel.java Mon Apr 18 17:08:24 2011
@@ -39,7 +39,7 @@ public class ActionsPanel extends JPanel
 
 	private static final long serialVersionUID = 1L;
 
-	private ClientModel model;
+	private final ClientModel model;
 
 	private DeletePanel deletePanel;
 	private DeleteTreePanel deleteTreePanel;

Modified: chemistry/opencmis/trunk/chemistry-opencmis-workbench/chemistry-opencmis-workbench/src/main/java/org/apache/chemistry/opencmis/workbench/details/DetailsTabs.java
URL: http://svn.apache.org/viewvc/chemistry/opencmis/trunk/chemistry-opencmis-workbench/chemistry-opencmis-workbench/src/main/java/org/apache/chemistry/opencmis/workbench/details/DetailsTabs.java?rev=1094656&r1=1094655&r2=1094656&view=diff
==============================================================================
--- chemistry/opencmis/trunk/chemistry-opencmis-workbench/chemistry-opencmis-workbench/src/main/java/org/apache/chemistry/opencmis/workbench/details/DetailsTabs.java (original)
+++ chemistry/opencmis/trunk/chemistry-opencmis-workbench/chemistry-opencmis-workbench/src/main/java/org/apache/chemistry/opencmis/workbench/details/DetailsTabs.java Mon Apr 18 17:08:24 2011
@@ -27,7 +27,7 @@ public class DetailsTabs extends JTabbed
 
     private static final long serialVersionUID = 1L;
 
-    private ClientModel model;
+    private final ClientModel model;
 
     private ObjectPanel objectPanel;
     private ActionsPanel actionsPanel;

Modified: chemistry/opencmis/trunk/chemistry-opencmis-workbench/chemistry-opencmis-workbench/src/main/java/org/apache/chemistry/opencmis/workbench/details/ExtensionsPanel.java
URL: http://svn.apache.org/viewvc/chemistry/opencmis/trunk/chemistry-opencmis-workbench/chemistry-opencmis-workbench/src/main/java/org/apache/chemistry/opencmis/workbench/details/ExtensionsPanel.java?rev=1094656&r1=1094655&r2=1094656&view=diff
==============================================================================
--- chemistry/opencmis/trunk/chemistry-opencmis-workbench/chemistry-opencmis-workbench/src/main/java/org/apache/chemistry/opencmis/workbench/details/ExtensionsPanel.java (original)
+++ chemistry/opencmis/trunk/chemistry-opencmis-workbench/chemistry-opencmis-workbench/src/main/java/org/apache/chemistry/opencmis/workbench/details/ExtensionsPanel.java Mon Apr 18 17:08:24 2011
@@ -41,7 +41,7 @@ public class ExtensionsPanel extends JPa
 
     private static final long serialVersionUID = 1L;
 
-    private ClientModel model;
+    private final ClientModel model;
 
     private JTree extensionsTree;
 
@@ -143,7 +143,7 @@ public class ExtensionsPanel extends JPa
     }
 
     static class ExtensionNode {
-        private CmisExtensionElement extension;
+        private final CmisExtensionElement extension;
 
         public ExtensionNode(CmisExtensionElement extension) {
             this.extension = extension;

Modified: chemistry/opencmis/trunk/chemistry-opencmis-workbench/chemistry-opencmis-workbench/src/main/java/org/apache/chemistry/opencmis/workbench/details/ObjectPanel.java
URL: http://svn.apache.org/viewvc/chemistry/opencmis/trunk/chemistry-opencmis-workbench/chemistry-opencmis-workbench/src/main/java/org/apache/chemistry/opencmis/workbench/details/ObjectPanel.java?rev=1094656&r1=1094655&r2=1094656&view=diff
==============================================================================
--- chemistry/opencmis/trunk/chemistry-opencmis-workbench/chemistry-opencmis-workbench/src/main/java/org/apache/chemistry/opencmis/workbench/details/ObjectPanel.java (original)
+++ chemistry/opencmis/trunk/chemistry-opencmis-workbench/chemistry-opencmis-workbench/src/main/java/org/apache/chemistry/opencmis/workbench/details/ObjectPanel.java Mon Apr 18 17:08:24 2011
@@ -42,7 +42,7 @@ public class ObjectPanel extends InfoPan
 
     private static final long serialVersionUID = 1L;
 
-    private ClientModel model;
+    private final ClientModel model;
 
     private JTextField nameField;
     private JTextField idField;

Modified: chemistry/opencmis/trunk/chemistry-opencmis-workbench/chemistry-opencmis-workbench/src/main/java/org/apache/chemistry/opencmis/workbench/details/TypesPanel.java
URL: http://svn.apache.org/viewvc/chemistry/opencmis/trunk/chemistry-opencmis-workbench/chemistry-opencmis-workbench/src/main/java/org/apache/chemistry/opencmis/workbench/details/TypesPanel.java?rev=1094656&r1=1094655&r2=1094656&view=diff
==============================================================================
--- chemistry/opencmis/trunk/chemistry-opencmis-workbench/chemistry-opencmis-workbench/src/main/java/org/apache/chemistry/opencmis/workbench/details/TypesPanel.java (original)
+++ chemistry/opencmis/trunk/chemistry-opencmis-workbench/chemistry-opencmis-workbench/src/main/java/org/apache/chemistry/opencmis/workbench/details/TypesPanel.java Mon Apr 18 17:08:24 2011
@@ -28,7 +28,7 @@ public class TypesPanel extends TypeSpli
 
     private static final long serialVersionUID = 1L;
 
-    private ClientModel model;
+    private final ClientModel model;
 
     public TypesPanel(ClientModel model) {
         super();



Mime
View raw message