chemistry-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sfermig...@apache.org
Subject svn commit: r898311 - in /incubator/chemistry/trunk/chemistry: chemistry-api/src/main/java/org/apache/chemistry/ chemistry-atompub-client/src/main/java/org/apache/chemistry/atompub/client/ chemistry-atompub-client/src/main/java/org/apache/chemistry/ato...
Date Tue, 12 Jan 2010 13:11:13 GMT
Author: sfermigier
Date: Tue Jan 12 13:11:12 2010
New Revision: 898311

URL: http://svn.apache.org/viewvc?rev=898311&view=rev
Log:
Make members variables final when possible.


Modified:
    incubator/chemistry/trunk/chemistry/chemistry-api/src/main/java/org/apache/chemistry/CMISException.java
    incubator/chemistry/trunk/chemistry/chemistry-api/src/main/java/org/apache/chemistry/CMISRuntimeException.java
    incubator/chemistry/trunk/chemistry/chemistry-atompub-client/src/main/java/org/apache/chemistry/atompub/client/APPConnection.java
    incubator/chemistry/trunk/chemistry/chemistry-atompub-client/src/main/java/org/apache/chemistry/atompub/client/APPObjectEntry.java
    incubator/chemistry/trunk/chemistry/chemistry-atompub-client/src/main/java/org/apache/chemistry/atompub/client/APPObjectEntryReader.java
    incubator/chemistry/trunk/chemistry/chemistry-atompub-client/src/main/java/org/apache/chemistry/atompub/client/APPObjectFeedReader.java
    incubator/chemistry/trunk/chemistry/chemistry-atompub-client/src/main/java/org/apache/chemistry/atompub/client/APPPropertyDefinition.java
    incubator/chemistry/trunk/chemistry/chemistry-atompub-client/src/main/java/org/apache/chemistry/atompub/client/APPRepository.java
    incubator/chemistry/trunk/chemistry/chemistry-atompub-client/src/main/java/org/apache/chemistry/atompub/client/connector/APPContentManager.java
    incubator/chemistry/trunk/chemistry/chemistry-atompub-client/src/main/java/org/apache/chemistry/atompub/client/connector/DefaultIOProvider.java
    incubator/chemistry/trunk/chemistry/chemistry-atompub-client/src/main/java/org/apache/chemistry/atompub/client/connector/HttpClientConnector.java
    incubator/chemistry/trunk/chemistry/chemistry-atompub-client/src/main/java/org/apache/chemistry/atompub/client/connector/HttpClientResponse.java
    incubator/chemistry/trunk/chemistry/chemistry-atompub-client/src/main/java/org/apache/chemistry/atompub/client/stax/XmlObject.java
    incubator/chemistry/trunk/chemistry/chemistry-atompub-server/src/main/java/org/apache/chemistry/atompub/server/CMISChildrenCollection.java
    incubator/chemistry/trunk/chemistry/chemistry-atompub/src/main/java/org/apache/chemistry/atompub/URITemplate.java
    incubator/chemistry/trunk/chemistry/chemistry-commons/src/main/java/org/apache/chemistry/xml/stax/ChildrenNavigator.java
    incubator/chemistry/trunk/chemistry/chemistry-commons/src/main/java/org/apache/chemistry/xml/stax/ElementIterator.java
    incubator/chemistry/trunk/chemistry/chemistry-commons/src/main/java/org/apache/chemistry/xml/stax/SiblingsIterator.java
    incubator/chemistry/trunk/chemistry/chemistry-jcr/src/main/java/org/apache/chemistry/jcr/JcrFolder.java

Modified: incubator/chemistry/trunk/chemistry/chemistry-api/src/main/java/org/apache/chemistry/CMISException.java
URL: http://svn.apache.org/viewvc/incubator/chemistry/trunk/chemistry/chemistry-api/src/main/java/org/apache/chemistry/CMISException.java?rev=898311&r1=898310&r2=898311&view=diff
==============================================================================
--- incubator/chemistry/trunk/chemistry/chemistry-api/src/main/java/org/apache/chemistry/CMISException.java
(original)
+++ incubator/chemistry/trunk/chemistry/chemistry-api/src/main/java/org/apache/chemistry/CMISException.java
Tue Jan 12 13:11:12 2010
@@ -24,7 +24,6 @@
     private static final long serialVersionUID = 1L;
 
     public CMISException() {
-        super();
     }
 
     public CMISException(String message) {

Modified: incubator/chemistry/trunk/chemistry/chemistry-api/src/main/java/org/apache/chemistry/CMISRuntimeException.java
URL: http://svn.apache.org/viewvc/incubator/chemistry/trunk/chemistry/chemistry-api/src/main/java/org/apache/chemistry/CMISRuntimeException.java?rev=898311&r1=898310&r2=898311&view=diff
==============================================================================
--- incubator/chemistry/trunk/chemistry/chemistry-api/src/main/java/org/apache/chemistry/CMISRuntimeException.java
(original)
+++ incubator/chemistry/trunk/chemistry/chemistry-api/src/main/java/org/apache/chemistry/CMISRuntimeException.java
Tue Jan 12 13:11:12 2010
@@ -24,7 +24,6 @@
     private static final long serialVersionUID = 1L;
 
     public CMISRuntimeException() {
-        super();
     }
 
     public CMISRuntimeException(String message) {

Modified: incubator/chemistry/trunk/chemistry/chemistry-atompub-client/src/main/java/org/apache/chemistry/atompub/client/APPConnection.java
URL: http://svn.apache.org/viewvc/incubator/chemistry/trunk/chemistry/chemistry-atompub-client/src/main/java/org/apache/chemistry/atompub/client/APPConnection.java?rev=898311&r1=898310&r2=898311&view=diff
==============================================================================
--- incubator/chemistry/trunk/chemistry/chemistry-atompub-client/src/main/java/org/apache/chemistry/atompub/client/APPConnection.java
(original)
+++ incubator/chemistry/trunk/chemistry/chemistry-atompub-client/src/main/java/org/apache/chemistry/atompub/client/APPConnection.java
Tue Jan 12 13:11:12 2010
@@ -78,11 +78,11 @@
 
     public static final int DEFAULT_MAX_CHILDREN = 20;
 
-    protected APPFolder root;
+    protected final Connector connector;
 
-    protected Connector connector;
+    protected final APPRepository repository;
 
-    protected APPRepository repository;
+    protected APPFolder root;
 
     protected Map<Class<?>, Object> singletons = new Hashtable<Class<?>,
Object>();
 

Modified: incubator/chemistry/trunk/chemistry/chemistry-atompub-client/src/main/java/org/apache/chemistry/atompub/client/APPObjectEntry.java
URL: http://svn.apache.org/viewvc/incubator/chemistry/trunk/chemistry/chemistry-atompub-client/src/main/java/org/apache/chemistry/atompub/client/APPObjectEntry.java?rev=898311&r1=898310&r2=898311&view=diff
==============================================================================
--- incubator/chemistry/trunk/chemistry/chemistry-atompub-client/src/main/java/org/apache/chemistry/atompub/client/APPObjectEntry.java
(original)
+++ incubator/chemistry/trunk/chemistry/chemistry-atompub-client/src/main/java/org/apache/chemistry/atompub/client/APPObjectEntry.java
Tue Jan 12 13:11:12 2010
@@ -53,9 +53,9 @@
     protected static final ContentStream REMOTE_CONTENT_STREAM = new SimpleContentStream(
             new byte[0], null, null);
 
-    protected APPConnection connection;
+    protected final APPConnection connection;
 
-    protected Map<String, XmlProperty> properties;
+    protected final Map<String, XmlProperty> properties;
 
     protected ContentStream localContentStream = REMOTE_CONTENT_STREAM;
 

Modified: incubator/chemistry/trunk/chemistry/chemistry-atompub-client/src/main/java/org/apache/chemistry/atompub/client/APPObjectEntryReader.java
URL: http://svn.apache.org/viewvc/incubator/chemistry/trunk/chemistry/chemistry-atompub-client/src/main/java/org/apache/chemistry/atompub/client/APPObjectEntryReader.java?rev=898311&r1=898310&r2=898311&view=diff
==============================================================================
--- incubator/chemistry/trunk/chemistry/chemistry-atompub-client/src/main/java/org/apache/chemistry/atompub/client/APPObjectEntryReader.java
(original)
+++ incubator/chemistry/trunk/chemistry/chemistry-atompub-client/src/main/java/org/apache/chemistry/atompub/client/APPObjectEntryReader.java
Tue Jan 12 13:11:12 2010
@@ -36,7 +36,7 @@
  */
 public class APPObjectEntryReader extends AbstractObjectReader<APPObjectEntry> {
 
-    private static APPObjectEntryReader builder = new APPObjectEntryReader();
+    private static final APPObjectEntryReader builder = new APPObjectEntryReader();
 
     public static APPObjectEntryReader getBuilder() {
         return builder;

Modified: incubator/chemistry/trunk/chemistry/chemistry-atompub-client/src/main/java/org/apache/chemistry/atompub/client/APPObjectFeedReader.java
URL: http://svn.apache.org/viewvc/incubator/chemistry/trunk/chemistry/chemistry-atompub-client/src/main/java/org/apache/chemistry/atompub/client/APPObjectFeedReader.java?rev=898311&r1=898310&r2=898311&view=diff
==============================================================================
--- incubator/chemistry/trunk/chemistry/chemistry-atompub-client/src/main/java/org/apache/chemistry/atompub/client/APPObjectFeedReader.java
(original)
+++ incubator/chemistry/trunk/chemistry/chemistry-atompub-client/src/main/java/org/apache/chemistry/atompub/client/APPObjectFeedReader.java
Tue Jan 12 13:11:12 2010
@@ -29,7 +29,7 @@
 public class APPObjectFeedReader extends
         AbstractFeedReader<ListPage<ObjectEntry>, APPObjectEntry> {
 
-    private static APPObjectFeedReader builder = new APPObjectFeedReader();
+    private static final APPObjectFeedReader builder = new APPObjectFeedReader();
 
     public static APPObjectFeedReader getBuilder() {
         return builder;
@@ -37,7 +37,6 @@
 
     public APPObjectFeedReader(EntryReader<APPObjectEntry> entryBuilder) {
         super(entryBuilder);
-
     }
 
     public APPObjectFeedReader() {

Modified: incubator/chemistry/trunk/chemistry/chemistry-atompub-client/src/main/java/org/apache/chemistry/atompub/client/APPPropertyDefinition.java
URL: http://svn.apache.org/viewvc/incubator/chemistry/trunk/chemistry/chemistry-atompub-client/src/main/java/org/apache/chemistry/atompub/client/APPPropertyDefinition.java?rev=898311&r1=898310&r2=898311&view=diff
==============================================================================
--- incubator/chemistry/trunk/chemistry/chemistry-atompub-client/src/main/java/org/apache/chemistry/atompub/client/APPPropertyDefinition.java
(original)
+++ incubator/chemistry/trunk/chemistry/chemistry-atompub-client/src/main/java/org/apache/chemistry/atompub/client/APPPropertyDefinition.java
Tue Jan 12 13:11:12 2010
@@ -47,7 +47,7 @@
 
     public static final Log log = LogFactory.getLog(APPPropertyDefinition.class);
 
-    protected Map<String, Object> map;
+    protected final Map<String, Object> map;
 
     protected String id;
 
@@ -285,7 +285,7 @@
         return "multi".equals(text);
     }
 
-    private static Map<String, ValueAdapter> adapters = new HashMap<String, ValueAdapter>();
+    private static final Map<String, ValueAdapter> adapters = new HashMap<String,
ValueAdapter>();
     static {
         adapters.put(CMIS.INHERITED.getLocalPart(), ValueAdapter.BOOLEAN);
         adapters.put(CMIS.REQUIRED.getLocalPart(), ValueAdapter.BOOLEAN);

Modified: incubator/chemistry/trunk/chemistry/chemistry-atompub-client/src/main/java/org/apache/chemistry/atompub/client/APPRepository.java
URL: http://svn.apache.org/viewvc/incubator/chemistry/trunk/chemistry/chemistry-atompub-client/src/main/java/org/apache/chemistry/atompub/client/APPRepository.java?rev=898311&r1=898310&r2=898311&view=diff
==============================================================================
--- incubator/chemistry/trunk/chemistry/chemistry-atompub-client/src/main/java/org/apache/chemistry/atompub/client/APPRepository.java
(original)
+++ incubator/chemistry/trunk/chemistry/chemistry-atompub-client/src/main/java/org/apache/chemistry/atompub/client/APPRepository.java
Tue Jan 12 13:11:12 2010
@@ -42,7 +42,7 @@
  */
 public class APPRepository implements Repository {
 
-    protected APPContentManager cm;
+    protected final APPContentManager cm;
 
     protected RepositoryInfo info;
 
@@ -50,9 +50,9 @@
 
     protected TypeManager typeManager;
 
-    protected Map<String, String> collections = new HashMap<String, String>();
+    protected final Map<String, String> collections = new HashMap<String, String>();
 
-    protected Map<String, URITemplate> uriTemplates = new HashMap<String, URITemplate>();
+    protected final Map<String, URITemplate> uriTemplates = new HashMap<String,
URITemplate>();
 
     public APPRepository(APPContentManager cm) {
         this(cm, null);

Modified: incubator/chemistry/trunk/chemistry/chemistry-atompub-client/src/main/java/org/apache/chemistry/atompub/client/connector/APPContentManager.java
URL: http://svn.apache.org/viewvc/incubator/chemistry/trunk/chemistry/chemistry-atompub-client/src/main/java/org/apache/chemistry/atompub/client/connector/APPContentManager.java?rev=898311&r1=898310&r2=898311&view=diff
==============================================================================
--- incubator/chemistry/trunk/chemistry/chemistry-atompub-client/src/main/java/org/apache/chemistry/atompub/client/connector/APPContentManager.java
(original)
+++ incubator/chemistry/trunk/chemistry/chemistry-atompub-client/src/main/java/org/apache/chemistry/atompub/client/connector/APPContentManager.java
Tue Jan 12 13:11:12 2010
@@ -31,26 +31,23 @@
  */
 public class APPContentManager implements ContentManager {
 
-    protected String baseUrl;
+    protected final String baseUrl;
 
-    protected Connector connector;
+    protected final Connector connector;
 
     protected Repository[] repos;
 
     protected String username;
 
-    public APPContentManager(String url) {
-        this(url, null);
-    }
-
     protected APPContentManager(String url, Connector connector) {
         this.baseUrl = url;
-        if (connector == null) {
-            connector = new HttpClientConnector(new DefaultIOProvider());
-        }
         this.connector = connector;
     }
 
+    public APPContentManager(String url) {
+        this(url, new HttpClientConnector(new DefaultIOProvider()));
+    }
+
     public String getBaseUrl() {
         return baseUrl;
     }

Modified: incubator/chemistry/trunk/chemistry/chemistry-atompub-client/src/main/java/org/apache/chemistry/atompub/client/connector/DefaultIOProvider.java
URL: http://svn.apache.org/viewvc/incubator/chemistry/trunk/chemistry/chemistry-atompub-client/src/main/java/org/apache/chemistry/atompub/client/connector/DefaultIOProvider.java?rev=898311&r1=898310&r2=898311&view=diff
==============================================================================
--- incubator/chemistry/trunk/chemistry/chemistry-atompub-client/src/main/java/org/apache/chemistry/atompub/client/connector/DefaultIOProvider.java
(original)
+++ incubator/chemistry/trunk/chemistry/chemistry-atompub-client/src/main/java/org/apache/chemistry/atompub/client/connector/DefaultIOProvider.java
Tue Jan 12 13:11:12 2010
@@ -41,18 +41,18 @@
  */
 public class DefaultIOProvider implements IOProvider {
 
-    protected APPObjectEntryReader objectReader = new APPObjectEntryReader();
+    protected final APPObjectEntryReader objectReader = new APPObjectEntryReader();
 
-    protected APPObjectFeedReader objectFeedReader = new APPObjectFeedReader(
+    protected final APPObjectFeedReader objectFeedReader = new APPObjectFeedReader(
             objectReader);
 
-    protected TypeEntryReader typeReader = new TypeEntryReader();
+    protected final TypeEntryReader typeReader = new TypeEntryReader();
 
-    protected TypeFeedReader typeFeedReader = new TypeFeedReader(typeReader);
+    protected final TypeFeedReader typeFeedReader = new TypeFeedReader(typeReader);
 
-    protected APPServiceDocumentReader serviceDocumentReader = new APPServiceDocumentReader();
+    protected final APPServiceDocumentReader serviceDocumentReader = new APPServiceDocumentReader();
 
-    protected APPObjectEntryWriter objectWriter = new APPObjectEntryWriter();
+    protected final APPObjectEntryWriter objectWriter = new APPObjectEntryWriter();
 
     public EntryReader<? extends ObjectEntry> getObjectEntryReader() {
         return objectReader;

Modified: incubator/chemistry/trunk/chemistry/chemistry-atompub-client/src/main/java/org/apache/chemistry/atompub/client/connector/HttpClientConnector.java
URL: http://svn.apache.org/viewvc/incubator/chemistry/trunk/chemistry/chemistry-atompub-client/src/main/java/org/apache/chemistry/atompub/client/connector/HttpClientConnector.java?rev=898311&r1=898310&r2=898311&view=diff
==============================================================================
--- incubator/chemistry/trunk/chemistry/chemistry-atompub-client/src/main/java/org/apache/chemistry/atompub/client/connector/HttpClientConnector.java
(original)
+++ incubator/chemistry/trunk/chemistry/chemistry-atompub-client/src/main/java/org/apache/chemistry/atompub/client/connector/HttpClientConnector.java
Tue Jan 12 13:11:12 2010
@@ -47,7 +47,7 @@
  */
 public class HttpClientConnector implements Connector {
 
-    protected HttpClient client;
+    protected final HttpClient client;
 
     protected final IOProvider io;
 
@@ -252,9 +252,9 @@
     public static class XmlObjectWriterRequestEntity<T> implements
             RequestEntity {
 
-        protected XmlObjectWriter<T> writer;
+        protected final XmlObjectWriter<T> writer;
 
-        protected T obj;
+        protected final T obj;
 
         public XmlObjectWriterRequestEntity(XmlObjectWriter<T> writer, T obj) {
             this.writer = writer;

Modified: incubator/chemistry/trunk/chemistry/chemistry-atompub-client/src/main/java/org/apache/chemistry/atompub/client/connector/HttpClientResponse.java
URL: http://svn.apache.org/viewvc/incubator/chemistry/trunk/chemistry/chemistry-atompub-client/src/main/java/org/apache/chemistry/atompub/client/connector/HttpClientResponse.java?rev=898311&r1=898310&r2=898311&view=diff
==============================================================================
--- incubator/chemistry/trunk/chemistry/chemistry-atompub-client/src/main/java/org/apache/chemistry/atompub/client/connector/HttpClientResponse.java
(original)
+++ incubator/chemistry/trunk/chemistry/chemistry-atompub-client/src/main/java/org/apache/chemistry/atompub/client/connector/HttpClientResponse.java
Tue Jan 12 13:11:12 2010
@@ -42,7 +42,7 @@
 
     static final int MAX_BUF_LEN = 128 * 1024;
 
-    protected HttpMethod method;
+    protected final HttpMethod method;
 
     protected final IOProvider io;
 

Modified: incubator/chemistry/trunk/chemistry/chemistry-atompub-client/src/main/java/org/apache/chemistry/atompub/client/stax/XmlObject.java
URL: http://svn.apache.org/viewvc/incubator/chemistry/trunk/chemistry/chemistry-atompub-client/src/main/java/org/apache/chemistry/atompub/client/stax/XmlObject.java?rev=898311&r1=898310&r2=898311&view=diff
==============================================================================
--- incubator/chemistry/trunk/chemistry/chemistry-atompub-client/src/main/java/org/apache/chemistry/atompub/client/stax/XmlObject.java
(original)
+++ incubator/chemistry/trunk/chemistry/chemistry-atompub-client/src/main/java/org/apache/chemistry/atompub/client/stax/XmlObject.java
Tue Jan 12 13:11:12 2010
@@ -31,9 +31,9 @@
 
     protected Type type;
 
-    protected Connection connection;
+    protected final Connection connection;
 
-    protected Map<String, Serializable> properties;
+    protected final Map<String, Serializable> properties;
 
     protected Set<String> allowableActions;
 

Modified: incubator/chemistry/trunk/chemistry/chemistry-atompub-server/src/main/java/org/apache/chemistry/atompub/server/CMISChildrenCollection.java
URL: http://svn.apache.org/viewvc/incubator/chemistry/trunk/chemistry/chemistry-atompub-server/src/main/java/org/apache/chemistry/atompub/server/CMISChildrenCollection.java?rev=898311&r1=898310&r2=898311&view=diff
==============================================================================
--- incubator/chemistry/trunk/chemistry/chemistry-atompub-server/src/main/java/org/apache/chemistry/atompub/server/CMISChildrenCollection.java
(original)
+++ incubator/chemistry/trunk/chemistry/chemistry-atompub-server/src/main/java/org/apache/chemistry/atompub/server/CMISChildrenCollection.java
Tue Jan 12 13:11:12 2010
@@ -59,7 +59,7 @@
  */
 public class CMISChildrenCollection extends CMISObjectsCollection {
 
-    protected static Pattern PAT_PARAM_SKIP_COUNT = Pattern.compile("(.*[?&]"
+    protected static final Pattern PAT_PARAM_SKIP_COUNT = Pattern.compile("(.*[?&]"
             + AtomPubCMIS.PARAM_SKIP_COUNT + "=)(-?[0-9]+)(.*)");
 
     public CMISChildrenCollection(String type, String id, Repository repository) {

Modified: incubator/chemistry/trunk/chemistry/chemistry-atompub/src/main/java/org/apache/chemistry/atompub/URITemplate.java
URL: http://svn.apache.org/viewvc/incubator/chemistry/trunk/chemistry/chemistry-atompub/src/main/java/org/apache/chemistry/atompub/URITemplate.java?rev=898311&r1=898310&r2=898311&view=diff
==============================================================================
--- incubator/chemistry/trunk/chemistry/chemistry-atompub/src/main/java/org/apache/chemistry/atompub/URITemplate.java
(original)
+++ incubator/chemistry/trunk/chemistry/chemistry-atompub/src/main/java/org/apache/chemistry/atompub/URITemplate.java
Tue Jan 12 13:11:12 2010
@@ -21,11 +21,11 @@
  */
 public class URITemplate {
 
-    public String type;
+    public final String type;
 
-    public String mediaType;
+    public final String mediaType;
 
-    public String template;
+    public final String template;
 
     public URITemplate(String type, String mediaType, String template) {
         this.type = type;

Modified: incubator/chemistry/trunk/chemistry/chemistry-commons/src/main/java/org/apache/chemistry/xml/stax/ChildrenNavigator.java
URL: http://svn.apache.org/viewvc/incubator/chemistry/trunk/chemistry/chemistry-commons/src/main/java/org/apache/chemistry/xml/stax/ChildrenNavigator.java?rev=898311&r1=898310&r2=898311&view=diff
==============================================================================
--- incubator/chemistry/trunk/chemistry/chemistry-commons/src/main/java/org/apache/chemistry/xml/stax/ChildrenNavigator.java
(original)
+++ incubator/chemistry/trunk/chemistry/chemistry-commons/src/main/java/org/apache/chemistry/xml/stax/ChildrenNavigator.java
Tue Jan 12 13:11:12 2010
@@ -23,7 +23,7 @@
  */
 public class ChildrenNavigator {
 
-    protected StaxReader sr;
+    protected final StaxReader sr;
 
     protected int depth;
 

Modified: incubator/chemistry/trunk/chemistry/chemistry-commons/src/main/java/org/apache/chemistry/xml/stax/ElementIterator.java
URL: http://svn.apache.org/viewvc/incubator/chemistry/trunk/chemistry/chemistry-commons/src/main/java/org/apache/chemistry/xml/stax/ElementIterator.java?rev=898311&r1=898310&r2=898311&view=diff
==============================================================================
--- incubator/chemistry/trunk/chemistry/chemistry-commons/src/main/java/org/apache/chemistry/xml/stax/ElementIterator.java
(original)
+++ incubator/chemistry/trunk/chemistry/chemistry-commons/src/main/java/org/apache/chemistry/xml/stax/ElementIterator.java
Tue Jan 12 13:11:12 2010
@@ -27,7 +27,7 @@
  */
 public abstract class ElementIterator<T> implements Iterator<T> {
 
-    protected StaxReader reader;
+    protected final StaxReader reader;
 
     /** If null, then the state is not known. */
     protected Boolean hasNext;

Modified: incubator/chemistry/trunk/chemistry/chemistry-commons/src/main/java/org/apache/chemistry/xml/stax/SiblingsIterator.java
URL: http://svn.apache.org/viewvc/incubator/chemistry/trunk/chemistry/chemistry-commons/src/main/java/org/apache/chemistry/xml/stax/SiblingsIterator.java?rev=898311&r1=898310&r2=898311&view=diff
==============================================================================
--- incubator/chemistry/trunk/chemistry/chemistry-commons/src/main/java/org/apache/chemistry/xml/stax/SiblingsIterator.java
(original)
+++ incubator/chemistry/trunk/chemistry/chemistry-commons/src/main/java/org/apache/chemistry/xml/stax/SiblingsIterator.java
Tue Jan 12 13:11:12 2010
@@ -23,7 +23,7 @@
  */
 public abstract class SiblingsIterator<T> extends ElementIterator<T> {
 
-    protected int depth;
+    protected final int depth;
 
     public SiblingsIterator(StaxReader sr) throws XMLStreamException {
         this(sr, sr.getElementDepth());

Modified: incubator/chemistry/trunk/chemistry/chemistry-jcr/src/main/java/org/apache/chemistry/jcr/JcrFolder.java
URL: http://svn.apache.org/viewvc/incubator/chemistry/trunk/chemistry/chemistry-jcr/src/main/java/org/apache/chemistry/jcr/JcrFolder.java?rev=898311&r1=898310&r2=898311&view=diff
==============================================================================
--- incubator/chemistry/trunk/chemistry/chemistry-jcr/src/main/java/org/apache/chemistry/jcr/JcrFolder.java
(original)
+++ incubator/chemistry/trunk/chemistry/chemistry-jcr/src/main/java/org/apache/chemistry/jcr/JcrFolder.java
Tue Jan 12 13:11:12 2010
@@ -61,7 +61,7 @@
             NodeIterator iter = node.getNodes();
             while (iter.hasNext()) {
                 Node child = iter.nextNode();
-                CMISObject entry = null;
+                CMISObject entry;
                 if (JcrCmisMap.isNodeDocument(child)) {
                     entry = new JcrDocument(child);
                 } else {



Mime
View raw message