From dev-return-1758-archive-asf-public=cust-asf.ponee.io@celix.apache.org Wed Mar 11 08:06:32 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 91F7618060E for ; Wed, 11 Mar 2020 09:06:32 +0100 (CET) Received: (qmail 91544 invoked by uid 500); 11 Mar 2020 08:06:31 -0000 Mailing-List: contact dev-help@celix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@celix.apache.org Delivered-To: mailing list dev@celix.apache.org Received: (qmail 91532 invoked by uid 99); 11 Mar 2020 08:06:31 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 11 Mar 2020 08:06:31 +0000 From: GitBox To: dev@celix.apache.org Subject: [GitHub] [celix] abroekhuis commented on a change in pull request #168: Refactors dfi tests from cpputest to google test Message-ID: <158391399155.2898.5367779399648018748.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Wed, 11 Mar 2020 08:06:31 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit abroekhuis commented on a change in pull request #168: Refactors dfi tests from cpputest to google test URL: https://github.com/apache/celix/pull/168#discussion_r390799111 ########## File path: libs/dfi/gtest/src/dyn_avpr_function_tests.cpp ########## @@ -219,27 +219,32 @@ const char* theAvprFile = "{ \ }\ }"; -TEST_GROUP(DynAvprFunctionTests) { - void setup() override { + +class DynAvprFunctionTests : public ::testing::Test { +public: + DynAvprFunctionTests() { int lvl = 1; dynAvprFunction_logSetup(stdLog, nullptr, lvl); dynAvprType_logSetup(stdLog, nullptr, lvl); } + ~DynAvprFunctionTests() override { + } + }; // Test 1, simple function with three arguments and a return type static int avpr_example1(__attribute__((unused)) void* handle, int32_t a, int32_t b, int32_t c, int32_t * out) { - CHECK_EQUAL(2, a); - CHECK_EQUAL(4, b); - CHECK_EQUAL(8, c); + EXPECT_EQ(2, a); Review comment: Sometimes I see EXPECT_xxx and sometimes ASSERT_xxx, what is the preferred variant? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services