celix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [celix] Oipo commented on a change in pull request #143: Feature/pubsub websocket full duplex communication
Date Sun, 26 Jan 2020 20:56:45 GMT
Oipo commented on a change in pull request #143: Feature/pubsub websocket full duplex communication
URL: https://github.com/apache/celix/pull/143#discussion_r371027573
 
 

 ##########
 File path: bundles/pubsub/pubsub_admin_websocket/src/pubsub_websocket_topic_receiver.c
 ##########
 @@ -558,34 +586,88 @@ static void* psa_websocket_recvThread(void * data) {
     return NULL;
 }
 
+static void psa_websocketTopicReceiver_ready(struct mg_connection *connection, void *handle)
{
+    if (handle != NULL) {
 
 Review comment:
   You can reduce nesting by changing this to `if(handle == null) { return; }`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message