Mailing-List: contact dev-help@celix.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@celix.apache.org
Received-SPF: pass (nike.apache.org: domain of pepijnnoltes@gmail.com
 designates 74.125.82.44 as permitted sender)
MIME-Version: 1.0
In-Reply-To: 
 <CA+T-u8cSLUsWh0LhbywgMo1k=jrm7TZYQD1BjtS4-8z5A8URKw@mail.gmail.com>
References: 
 <CA+T-u8cSLUsWh0LhbywgMo1k=jrm7TZYQD1BjtS4-8z5A8URKw@mail.gmail.com>
Date: Thu, 2 Oct 2014 21:49:28 +0200
Message-ID: 
 <CAPhv5g9dyDq0zHGZ4x6aDLdpT73bK_6HPsbWDachBbvPFsmS4g@mail.gmail.com>
Subject: Re: Symbol visibility
From: Pepijn Noltes <pepijnnoltes@gmail.com>
To: dev@celix.apache.org
Content-Type: text/plain; charset=UTF-8

Hi,


On Thu, Oct 2, 2014 at 9:25 AM, Alexander Broekhuis
<a.broekhuis@gmail.com> wrote:
> Hi all,
>
> In the past I have done some work for symbol visibility, this has never
> been enabled properly (or has been disabled for some reason). I'd like to
> enable this now in the build.
>
> I did some local testing, and I don't see any problems with it. Besides
> setting visibility in the framework and the utils, something has to be
> setup for use in private/exported/imported libraries as well. I can add
> something for this.
>
> What is a problem however, is the fw_log function which is now used in some
> bundles as well. The fw_log function is specifically for the framework
> itself, and not for others, so it should not be exported.
> In places where logging is needed, the log_service should be used. Bjoern
> already proposed to write some helper code to easily get a logger and use
> it. I'd like to see this as well.
>
> Besides the fw_log I assume several other (framework private) functions are
> now exported as well, this will need to be addressed later on as well.
>
> What do you all think?

+1

Sounds like a good idea, I assume that if a compiler/linker does not
support this you can easily turn if off ?

Greetings,
Pepijn