celix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Broekhuis <a.broekh...@gmail.com>
Subject Re: [jira] [Created] (CELIX-152) Added Discovery/ETCD support
Date Mon, 22 Sep 2014 17:27:08 GMT
2014-09-22 17:39 GMT+02:00 Bjoern Petri <bjoern.petri@sundevil.de>:

>
>
> A first remark I have is the use of the config.properties file.  Right
> now, the specified server needs to be set as a configuration option within
> the config.properties file. This in turn means that we probably have to
> automatically generate this file during the start-up of the node or - even
> worse - during the startup of the celix service.
>

Instead of in the properties file, you can define properties as environment
variables. The BundleContext_getProperty first checks the configuration of
the running framework, and then checks if there is a environment variable.


>
> I am not really sure what is supported by the launcher at the moment but
> wouldn't it be a good idea to have named arguments for the launcher anyway?


I am not really in favour of adding named arguments to the launcher. Some
framework specific settings would be ok, but anything related to bundles
should not be in the launcher (imho). One way I could possibly see is to
add support for arbitrary key/value pairs to the launcher. But I am not
sure what this adds to the usage of the environment.

What would be a nice addition, and perhaps makes more sense, is to add
configuration options to the deploy targets. That way it is possible to set
properties in the actual target setup. Adding those to the
config.properties isn't that difficult.


-- 
Met vriendelijke groet,

Alexander Broekhuis

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message